Re: [PATCH 0/2] Add support for Skov Rev.C HDMI variant

Marco Felsch
2025-11-12T08:47:39Z

On 25-11-10, Marco Felsch wrote:
> On 25-11-10, Rob Herring (Arm) wrote:
> >
> > On Fri, 07 Nov 2025 15:49:50 +0100, Marco Felsch wrote:
> > > Hi,
> > >
> > > this small patchset adds the support for the Rev.C HDMI board variant.
> > >
> > > Regards,
> > > Marco
> > >
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > > Marco Felsch (2):
> > > dt-bindings: arm: fsl: add Skov Rev.C HDMI support
> > > arm64: dts: imx8mp-skov: add Rev.C HDMI support
> > >
> > > Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> > > arch/arm64/boot/dts/freescale/Makefile | 1 +
> > > arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dts | 8 ++++++++
> > > 3 files changed, 10 insertions(+)
> > > ---
> > > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> > > change-id: 20251107-v6-18-skov-revc-hdmi-1e8d4bbac26a
> > >
> > > Best regards,
> > > --
> > > Marco Felsch <m.felsch@pengutronix.de>
> > >
> > >
> > >
> >
> >
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> >
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> >
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> >
> > pip3 install dtschema --upgrade
> >
> >
> > This patch series was applied (using b4) to base:
> > Base: 3a8660878839faadb4f1a6dd72c3179c1df56787 (use --merge-base to override)
> >
> > If this is not the correct base, please add 'base-commit' tag
> > (or use b4 which does this automatically)
> >
> > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20251107-v6-18-skov-revc-hdmi-v1-0-595549e5b496@pengutronix.de:
> >
> > arch/arm64/boot/dts/freescale/imx8mp-skov-revc-hdmi.dtb: switch@5f (microchip,ksz9893): pinctrl-names: ['default'] is too short
> > from schema $id: http://devicetree.org/schemas/net/dsa/microchip,ksz.yaml
>
> This may be a valid issue, but it's rather an additional patch worth it
> since this patchset doesn't touch the imx8mp-skov-reva.dtsi include at
> all.

FTR: If I get the binding right, the regression is caused by commit
https://lore.kernel.org/all/20250918-ksz-strap-pins-v3-2-16662e881728@bootlin.com/.

Since this commit, pinctrl-names always need to have the "default" and
"reset" value, which is wrong.

Regards,
Marco

>
> Regards, Marco
>
> >
> >
> >
> >
> >
> >
>
> -- #gernperDu #CallMeByMyFirstName
>
> Pengutronix e.K. |
> | Steuerwalder Str. 21 |
> https://www.pengutronix.de/ | 31137 Hildesheim, Germany
> | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686
> | Fax: +49-5121-206917-9 |
>
>