From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Srinivas Kandagatla <srini@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH 0/4] ASoC / rpmsg / remoteproc / soc: qcom: Constify buffer passed to send functions
Date: Mon, 1 Dec 2025 09:20:35 -0700 [thread overview]
Message-ID: <aS3AU0gEEOvWs4Uw@p14s> (raw)
In-Reply-To: <20251130-rpmsg-send-const-v1-0-cb11c7e0a024@oss.qualcomm.com>
On Sun, Nov 30, 2025 at 01:36:07PM +0100, Krzysztof Kozlowski wrote:
> Dependencies / merging
> ======================
> Entire patchset is one logical chain, all further patches depend on
> previous ones, thus everything should be taken via same tree or shared
> between trees with tags. Probably everything should go via ASoC with
> necessary acks.
>
> Also, first patch or two patches could be taken now for this merge
> window...
>
> Description
> ===========
> The remoteproc and rpmsg send-like functions should not modify data
> being sent, so buffer should be marked as pointer to const. This is not
> only self-documenting code but actually increases the actual safety and
> clearly documents who is the owner of passed buffer.
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (4):
> remoteproc: mtp_scp_ipi: Constify buffer passed to scp_ipi_send()
> remoteproc: mtp_scp: Constify buffer passed to scp_send_ipi()
> rpmsg: Constify buffer passed to send API
> ASoC: qcom:: Constify GPR packet being send over GPR interface
>
> drivers/remoteproc/mtk_scp.c | 2 +-
> drivers/remoteproc/mtk_scp_ipi.c | 2 +-
> drivers/rpmsg/mtk_rpmsg.c | 4 ++--
> drivers/rpmsg/qcom_glink_native.c | 13 ++++++++-----
> drivers/rpmsg/qcom_smd.c | 10 ++++++----
> drivers/rpmsg/rpmsg_core.c | 8 ++++----
> drivers/rpmsg/rpmsg_internal.h | 8 ++++----
> drivers/rpmsg/virtio_rpmsg_bus.c | 24 +++++++++++++-----------
> drivers/soc/qcom/apr.c | 8 ++++----
> include/linux/remoteproc/mtk_scp.h | 2 +-
> include/linux/rpmsg.h | 17 +++++++++--------
> include/linux/rpmsg/mtk_rpmsg.h | 2 +-
> include/linux/soc/qcom/apr.h | 4 ++--
Acked-by: Mathieu Poirier <mathieuu.poirier@linaro.org>
I'll let Bjorn decide if he wants to include this in his upcoming pull request.
Thanks,
Mathieu
> sound/soc/qcom/qdsp6/audioreach.c | 6 +++---
> sound/soc/qcom/qdsp6/audioreach.h | 4 ++--
> sound/soc/qcom/qdsp6/q6apm.c | 3 ++-
> sound/soc/qcom/qdsp6/q6apm.h | 2 +-
> 17 files changed, 64 insertions(+), 55 deletions(-)
> ---
> base-commit: 7a9e871ce4c7c8a7d75eaef8407083a0525de2dd
> change-id: 20251130-rpmsg-send-const-ae216a1fbd8f
>
> Best regards,
> --
> Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
prev parent reply other threads:[~2025-12-01 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 12:36 [PATCH 0/4] ASoC / rpmsg / remoteproc / soc: qcom: Constify buffer passed to send functions Krzysztof Kozlowski
2025-11-30 12:36 ` [PATCH 1/4] remoteproc: mtp_scp_ipi: Constify buffer passed to scp_ipi_send() Krzysztof Kozlowski
2025-11-30 12:36 ` [PATCH 2/4] remoteproc: mtp_scp: Constify buffer passed to scp_send_ipi() Krzysztof Kozlowski
2025-11-30 12:36 ` [PATCH 3/4] rpmsg: Constify buffer passed to send API Krzysztof Kozlowski
2025-11-30 12:36 ` [PATCH 4/4] ASoC: qcom:: Constify GPR packet being send over GPR interface Krzysztof Kozlowski
2025-12-01 16:20 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS3AU0gEEOvWs4Uw@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).