Re: [PATCH] arm64: dts: imx93-9x9-qsb: add CAN support

[Frank Li <Frank.li@nxp.com>]

On Thu, Nov 27, 2025 at 02:01:47AM +0000, Bough Chen wrote:
> > -----Original Message-----
> > From: Frank Li <frank.li@nxp.com>
> > Sent: 2025年11月27日 0:22
> > To: Bough Chen <haibo.chen@nxp.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>; Sascha Hauer
> > <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob
> > Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
> > Dooley <conor+dt@kernel.org>; imx@lists.linux.dev;
> > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] arm64: dts: imx93-9x9-qsb: add CAN support
> >
> > On Wed, Nov 26, 2025 at 02:20:07PM +0800, Haibo Chen wrote:
> >
> > subject suggested,  add CAN support overlay file
> >
> > > CAN1 and Micfil share pins on imx93-9x9-qsb board, use TMUX1574RSVR to
> > > control the connection: put sel to high, select CAN1, put sel to low,
> > > select Micfil. In default, sel keep low.
> > >
> > > To support CAN1, need to put the sel to high. Besides, CAN1 use phy
> > > TJA1057GT/3.
> > >
> > > ---
> > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/Makefile             |  2 +
> > >  .../boot/dts/freescale/imx93-9x9-qsb-can1.dtso     | 63
> > ++++++++++++++++++++++
> > >  2 files changed, 65 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> > > b/arch/arm64/boot/dts/freescale/Makefile
> > > index
> > >
> > f30d3fd724d0ce6b38f7bef10e3970ac34f70f4a..1142d3312c8651b4292837bce3
> > cb
> > > e46ab95f7e09 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -373,7 +373,9 @@ dtb-$(CONFIG_ARCH_MXC) +=
> > > imx91-tqma9131-mba91xxca.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb.dtb
> > >
> > >  imx93-9x9-qsb-i3c-dtbs += imx93-9x9-qsb.dtb imx93-9x9-qsb-i3c.dtbo
> > > +imx93-9x9-qsb-can1-dtbs += imx93-9x9-qsb.dtb imx93-9x9-qsb-can1.dtbo
> >
> > Keep order by alphabet.
> >
> > >  dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-i3c.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb-can1.dtb
> >
> > the same here
> >
> > can1 should before i3c.
>
> Okay
>
> >
> > >
> > >  dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx93-14x14-evk.dtb diff --git
> > > a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb-can1.dtso
> > > b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb-can1.dtso
> > > new file mode 100644
> > > index
> > >
> > 0000000000000000000000000000000000000000..62d4fa6c21d794f91da59f51
> > 1d6f
> > > 0162037e9271
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb-can1.dtso
> > > @@ -0,0 +1,63 @@
> > ...
> > > +
> > > +&pcal6524 {
> > > +	/*
> > > +	 * mic-can-sel-hog have property 'output-low', dt overlay don't
> > > +	 * support /delete-property/. Both 'output-low' and 'output-high'
> > > +	 * will be exist under hog nodes if overlay file set 'output-high'.
> > > +	 * Workaround is disable this hog and create new hog with
> > > +	 * 'output-high'.
> > > +	 */
> > > +	mic-can-sel-hog {
> > > +		status = "disabled";
> > > +	};
> >
> > are you sure 'status' work for hogs?
>
> Yes, I test on board, this method works.
>

Okay, I just want to make sure it works.

Frank

> Any better solution?
>
> Regards
> Haibo Chen
> >
> > Frank
> > > +
> > > +	/*
> > > +	 * Config the MIC/CAN_SEL to high, chose B
> > > +	 * port, connect to CAN.
> > > +	 */
> > > +	mic-can-high-sel-hog {
> > > +		gpio-hog;
> > > +		gpios = <0x11 0x00>;
> > > +		output-high;
> > > +	};
> > > +};
> > >
> > > ---
> > > base-commit: 422f3140bbcb657e1b86c484296972ab76f6d1ff
> > > change-id: 20251125-b4-9391-can-dts-2f4849978fc2
> > >
> > > Best regards,
> > > --
> > > Haibo Chen <haibo.chen@nxp.com>
> > >