linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* i2c-xiic driver changes from Cisco
@ 2025-12-02 17:04 Daniel Walker (danielwa)
  2025-12-04  8:47 ` Michal Simek
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Walker (danielwa) @ 2025-12-02 17:04 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-arm-kernel@lists.infradead.org, Gopal Saha (gopasaha),
	xe-linux-external(mailer list)

Hi,

We have a slightly modified version of the Xilinx IP which the i2c-xiic.c
sources seem to support.

We made one (or at least one) change to the IP were we don't supply it with an
interrupt line. It doesn't appear the driver supports this configuration.
Is that accurate to your knowledge ?

If the drivers doesn't support some type of polling mode, is Xilinx willing to accept
changes which would make the driver compatible with a polling mode if an
interrupt is not supplied thru the device tree ?

It seems like it makes sense the driver should support a polling mode because
Xilinx customers may make a product where the interrupt line doesn't function
properly. In that case the customer would need a contingency which could be
polling for interrupts.

Daniel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: i2c-xiic driver changes from Cisco
  2025-12-02 17:04 i2c-xiic driver changes from Cisco Daniel Walker (danielwa)
@ 2025-12-04  8:47 ` Michal Simek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2025-12-04  8:47 UTC (permalink / raw)
  To: Daniel Walker (danielwa), Michal Simek
  Cc: linux-arm-kernel@lists.infradead.org, Gopal Saha (gopasaha),
	xe-linux-external(mailer list)

Hi,

On 12/2/25 18:04, Daniel Walker (danielwa) wrote:
> Hi,
> 
> We have a slightly modified version of the Xilinx IP which the i2c-xiic.c
> sources seem to support.
> 
> We made one (or at least one) change to the IP were we don't supply it with an
> interrupt line. It doesn't appear the driver supports this configuration.
> Is that accurate to your knowledge ?
> 
> If the drivers doesn't support some type of polling mode, is Xilinx willing to accept
> changes which would make the driver compatible with a polling mode if an
> interrupt is not supplied thru the device tree ?
> 
> It seems like it makes sense the driver should support a polling mode because
> Xilinx customers may make a product where the interrupt line doesn't function
> properly. In that case the customer would need a contingency which could be
> polling for interrupts.

Not sure what that change means but if you don't connect IRQ in design I expect 
vivado removes the whole logic around it at synthesis time.

Anyway using this IP without IRQ is perfectly valid use case and no issue from 
my side to also support it in the kernel.

Thanks,
Michal


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-04  8:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 17:04 i2c-xiic driver changes from Cisco Daniel Walker (danielwa)
2025-12-04  8:47 ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).