From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Will McVicker <willmcvicker@google.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Donghoon Yu" <hoony.yu@samsung.com>,
"Hosung Kim" <hosung0.kim@samsung.com>,
"Rob Herring" <robh@kernel.org>,
"John Stultz" <jstultz@google.com>,
"Youngmin Nam" <youngmin.nam@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, kernel-team@android.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/6] Add module support for Arm64 Exynos MCT driver
Date: Fri, 21 Nov 2025 15:11:37 +0000 [thread overview]
Message-ID: <aSCBKRpA4jSw1iuF@shell.armlinux.org.uk> (raw)
In-Reply-To: <20251120184242.1625820-1-willmcvicker@google.com>
On Thu, Nov 20, 2025 at 06:42:28PM +0000, Will McVicker wrote:
> This series adds support to build the Arm64 Exynos MCT driver as a module.
There are parts of this that are just totally incompatible with it
being a module. For example, you can't register a replacement udelay
loop after the system has booted.
This is the second time I've faced a patch series wanting to remove
__init anntations to call it from a module, where the author has
clearly not analysed the code to see whether that is a valid thing
to do. This is unfair on reviewers - it is the submitters
responsibility to check that what they are doing is valid.
Moreover, in _this_ case, you will have received a kernel diagnostic
message stating that the call to register_current_timer_delay()
was ignored, so I also question whether you bothered to run-time
test this change.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-11-21 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251120184253eucas1p17d9dea24d56e4eefc283a738a94f2634@eucas1p1.samsung.com>
2025-11-20 18:42 ` [PATCH v6 0/6] Add module support for Arm64 Exynos MCT driver Will McVicker
2025-11-20 18:42 ` [PATCH v6 1/6] ARM: make register_current_timer_delay() accessible after init Will McVicker
2025-11-21 14:37 ` Daniel Lezcano
2025-11-21 15:04 ` Russell King (Oracle)
2025-11-21 17:51 ` William McVicker
2025-11-20 18:42 ` [PATCH v6 2/6] clocksource/drivers/exynos_mct: Don't register as a sched_clock on arm64 Will McVicker
2025-11-20 18:42 ` [PATCH v6 3/6] clocksource/drivers/exynos_mct: Set percpu local timer interrupts for ARM64 Will McVicker
2025-11-20 18:42 ` [PATCH v6 4/6] clocksource/drivers/exynos_mct: Fix uninitialized irq name warning Will McVicker
2025-11-20 18:42 ` [PATCH v6 5/6] clocksource/drivers/exynos_mct: Add module support for ARM64 Will McVicker
2025-11-20 18:42 ` [PATCH v6 6/6] arm64: exynos: Drop select CLKSRC_EXYNOS_MCT Will McVicker
2025-11-21 12:16 ` [PATCH v6 0/6] Add module support for Arm64 Exynos MCT driver Marek Szyprowski
2025-11-21 15:11 ` Russell King (Oracle) [this message]
2025-11-21 17:55 ` William McVicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSCBKRpA4jSw1iuF@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=hoony.yu@samsung.com \
--cc=hosung0.kim@samsung.com \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
--cc=tudor.ambarus@linaro.org \
--cc=will@kernel.org \
--cc=willmcvicker@google.com \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).