Re: [PATCH v5 2/6] reset: imx8mp-audiomix: Replace mask with bit index

[Frank Li <Frank.li@nxp.com>]

On Mon, Nov 24, 2025 at 01:28:32AM -0800, Laurentiu Mihalcea wrote:
>
> On 11/21/2025 7:38 AM, Frank Li wrote:
> > On Fri, Nov 14, 2025 at 05:37:34AM -0800, Laurentiu Mihalcea wrote:
> >> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> >>
> >> Replace the reset map mask with the bit index to make it clear that all
> >> reset lines are managed by exactly 1 bit.
> > I don't think there are benefit because I met some periphal need a magic
> > number to reset.
>
>
> Please provide more information. What SoC? Which peripherals? What block control?
>

I can't reminder exact one. I grep some code

[IMX8MP_MEDIABLK_PD_LCDIF_1] = {
                .name = "mediablk-lcdif-1",
                .clk_names = (const char *[]){ "disp1", "apb", "axi", },
                .num_clks = 3,
                .gpc_name = "lcdif1",
                .rst_mask = BIT(4) | BIT(5) | BIT(23),
                .clk_mask = BIT(4) | BIT(5) | BIT(23),
                .path_names = (const char *[]){"lcdif-rd", "lcdif-wr"},
                .num_paths = 2,
        },

mask is more extenable and easily support more hardware in future. Change
to bit number have not big benefit.

Frank