* [PATCH] remoteproc: st: Fix indexing of memory-regions
@ 2025-11-26 18:17 Bjorn Andersson
2025-11-27 15:36 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2025-11-26 18:17 UTC (permalink / raw)
To: Patrice Chotard, Bjorn Andersson, Mathieu Poirier,
Rob Herring (Arm), Arnaud Pouliquen, Geert Uytterhoeven
Cc: linux-arm-msm, linux-arm-kernel, linux-remoteproc, linux-kernel,
Bjorn Andersson
The recent transition to use of_reserved_mem_region_to_resource()
changes the while loop to a for loop, but the increment of the "index"
variable was left behind at the end of the loop, as highlighted by the
following error/warning:
error: variable 'index' is incremented both in the loop header and in the loop body [-Werror,-Wfor-loop-analysis]
Drop the extra increment to avoid skipping over every other
memory-region in the loop.
Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
---
drivers/remoteproc/st_remoteproc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
index 747bbe7f6f7c6be160f4f6a0202eb8df20dc5bc9..a07edf7217d21a3f08d26592e8a14814608507f8 100644
--- a/drivers/remoteproc/st_remoteproc.c
+++ b/drivers/remoteproc/st_remoteproc.c
@@ -155,7 +155,6 @@ static int st_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
return -ENOMEM;
rproc_add_carveout(rproc, mem);
- index++;
}
return rproc_elf_load_rsc_table(rproc, fw);
---
base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f
change-id: 20251126-st-remoteproc-double-index-29a2e40e74bb
Best regards,
--
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] remoteproc: st: Fix indexing of memory-regions
2025-11-26 18:17 [PATCH] remoteproc: st: Fix indexing of memory-regions Bjorn Andersson
@ 2025-11-27 15:36 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2025-11-27 15:36 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Patrice Chotard, Bjorn Andersson, Rob Herring (Arm),
Arnaud Pouliquen, Geert Uytterhoeven, linux-arm-msm,
linux-arm-kernel, linux-remoteproc, linux-kernel
On Wed, Nov 26, 2025 at 12:17:59PM -0600, Bjorn Andersson wrote:
> The recent transition to use of_reserved_mem_region_to_resource()
> changes the while loop to a for loop, but the increment of the "index"
> variable was left behind at the end of the loop, as highlighted by the
> following error/warning:
>
> error: variable 'index' is incremented both in the loop header and in the loop body [-Werror,-Wfor-loop-analysis]
>
> Drop the extra increment to avoid skipping over every other
> memory-region in the loop.
>
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
> ---
> drivers/remoteproc/st_remoteproc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index 747bbe7f6f7c6be160f4f6a0202eb8df20dc5bc9..a07edf7217d21a3f08d26592e8a14814608507f8 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -155,7 +155,6 @@ static int st_rproc_parse_fw(struct rproc *rproc, const struct firmware *fw)
> return -ENOMEM;
>
> rproc_add_carveout(rproc, mem);
> - index++;
Really good - applied.
Thanks,
Mathieu
> }
>
> return rproc_elf_load_rsc_table(rproc, fw);
>
> ---
> base-commit: 663d0d1af3faefe673cabf4b6b077149a87ad71f
> change-id: 20251126-st-remoteproc-double-index-29a2e40e74bb
>
> Best regards,
> --
> Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-27 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 18:17 [PATCH] remoteproc: st: Fix indexing of memory-regions Bjorn Andersson
2025-11-27 15:36 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).