From: Sumit Garg <sumit.garg@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Cristian Marussi <cristian.marussi@arm.com>,
op-tee@lists.trustedfirmware.org, arm-scmi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 10/17] firmware: arm_scmi: optee: Make use of module_tee_client_driver()
Date: Mon, 15 Dec 2025 16:30:54 +0900 [thread overview]
Message-ID: <aT-5LtYnLSF_MwW4@sumit-X1> (raw)
In-Reply-To: <537c48e3db243b5c68c3192179a948efb3a180c7.1765472125.git.u.kleine-koenig@baylibre.com>
On Thu, Dec 11, 2025 at 06:15:04PM +0100, Uwe Kleine-König wrote:
> Reduce boilerplate by using the newly introduced module_tee_client_driver().
> That takes care of assigning the driver's bus, so the explicit assigning
> in this driver can be dropped.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> drivers/firmware/arm_scmi/transports/optee.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
-Sumit
>
> diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmware/arm_scmi/transports/optee.c
> index dc0f46340153..8fdb80d3fabd 100644
> --- a/drivers/firmware/arm_scmi/transports/optee.c
> +++ b/drivers/firmware/arm_scmi/transports/optee.c
> @@ -612,23 +612,12 @@ static struct tee_client_driver scmi_optee_service_driver = {
> .id_table = scmi_optee_service_id,
> .driver = {
> .name = "scmi-optee",
> - .bus = &tee_bus_type,
> .probe = scmi_optee_service_probe,
> .remove = scmi_optee_service_remove,
> },
> };
>
> -static int __init scmi_transport_optee_init(void)
> -{
> - return driver_register(&scmi_optee_service_driver.driver);
> -}
> -module_init(scmi_transport_optee_init);
> -
> -static void __exit scmi_transport_optee_exit(void)
> -{
> - driver_unregister(&scmi_optee_service_driver.driver);
> -}
> -module_exit(scmi_transport_optee_exit);
> +module_tee_client_driver(scmi_optee_service_driver);
>
> MODULE_AUTHOR("Etienne Carriere <etienne.carriere@foss.st.com>");
> MODULE_DESCRIPTION("SCMI OPTEE Transport driver");
> --
> 2.47.3
>
next prev parent reply other threads:[~2025-12-15 7:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 17:14 [PATCH v1 00/17] tee: Use bus callbacks instead of driver callbacks Uwe Kleine-König
2025-12-11 17:15 ` [PATCH v1 08/17] efi: stmm: Make use of module_tee_client_driver() Uwe Kleine-König
2025-12-15 7:55 ` Sumit Garg
2025-12-11 17:15 ` [PATCH v1 09/17] efi: stmm: Make use of tee bus methods Uwe Kleine-König
2025-12-15 7:55 ` Sumit Garg
2025-12-11 17:15 ` [PATCH v1 10/17] firmware: arm_scmi: optee: Make use of module_tee_client_driver() Uwe Kleine-König
2025-12-12 12:33 ` Sudeep Holla
2025-12-15 7:30 ` Sumit Garg [this message]
2025-12-11 17:15 ` [PATCH v1 11/17] firmware: arm_scmi: Make use of tee bus methods Uwe Kleine-König
2025-12-12 12:34 ` Sudeep Holla
2025-12-15 7:32 ` Sumit Garg
2025-12-15 7:54 ` [PATCH v1 00/17] tee: Use bus callbacks instead of driver callbacks Sumit Garg
2025-12-15 9:32 ` Uwe Kleine-König
2025-12-16 7:38 ` Sumit Garg
2025-12-16 11:08 ` Uwe Kleine-König
2025-12-17 7:55 ` Sumit Garg
2025-12-17 8:21 ` Uwe Kleine-König
2025-12-17 9:02 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aT-5LtYnLSF_MwW4@sumit-X1 \
--to=sumit.garg@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cristian.marussi@arm.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sudeep.holla@arm.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).