Re: [RESEND PATCH v11 02/11] usb: typec: Export typec bus and typec altmode device type

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

Thu, Dec 04, 2025 at 02:31:00PM +0800, Chaoyi Chen kirjoitti:
> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> The DRM may want to register a notifier on the typec bus to know when
> a typec altmode device is added, and distinguish between different
> types of typec altmode device.
> 
> Export these things.
> 
> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
> 
> Changes in v11:
> - Also export typec bus.
> - Add more detailed comments.
> 
> (no changes since v9)
> 
>  drivers/usb/typec/bus.c           |  1 +
>  drivers/usb/typec/bus.h           | 10 ----------
>  drivers/usb/typec/class.c         |  3 +++
>  include/linux/usb/typec.h         |  3 +++
>  include/linux/usb/typec_altmode.h |  8 ++++++++
>  5 files changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/usb/typec/bus.c b/drivers/usb/typec/bus.c
> index a33da7f458a5..e84b134a3381 100644
> --- a/drivers/usb/typec/bus.c
> +++ b/drivers/usb/typec/bus.c
> @@ -569,3 +569,4 @@ const struct bus_type typec_bus = {
>  	.probe = typec_probe,
>  	.remove = typec_remove,
>  };
> +EXPORT_SYMBOL_GPL(typec_bus);
> diff --git a/drivers/usb/typec/bus.h b/drivers/usb/typec/bus.h
> index b58e131450d1..7df5deb1dd3a 100644
> --- a/drivers/usb/typec/bus.h
> +++ b/drivers/usb/typec/bus.h
> @@ -5,7 +5,6 @@
>  
>  #include <linux/usb/typec_altmode.h>
>  
> -struct bus_type;
>  struct typec_mux;
>  struct typec_retimer;
>  
> @@ -28,13 +27,4 @@ struct altmode {
>  
>  #define to_altmode(d) container_of(d, struct altmode, adev)
>  
> -extern const struct bus_type typec_bus;
> -extern const struct device_type typec_port_altmode_dev_type;
> -extern const struct device_type typec_plug_altmode_dev_type;
> -extern const struct device_type typec_partner_altmode_dev_type;
> -
> -#define is_typec_port_altmode(dev) ((dev)->type == &typec_port_altmode_dev_type)
> -#define is_typec_plug_altmode(dev) ((dev)->type == &typec_plug_altmode_dev_type)
> -#define is_typec_partner_altmode(dev) ((dev)->type == &typec_partner_altmode_dev_type)
> -
>  #endif /* __USB_TYPEC_ALTMODE_H__ */
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index d6b88317f8a4..c4ff4310ff58 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -537,18 +537,21 @@ const struct device_type typec_port_altmode_dev_type = {
>  	.groups = typec_altmode_groups,
>  	.release = typec_altmode_release,
>  };
> +EXPORT_SYMBOL_GPL(typec_port_altmode_dev_type);
>  
>  const struct device_type typec_plug_altmode_dev_type = {
>  	.name = "typec_plug_alternate_mode",
>  	.groups = typec_altmode_groups,
>  	.release = typec_altmode_release,
>  };
> +EXPORT_SYMBOL_GPL(typec_plug_altmode_dev_type);
>  
>  const struct device_type typec_partner_altmode_dev_type = {
>  	.name = "typec_partner_alternate_mode",
>  	.groups = typec_altmode_groups,
>  	.release = typec_altmode_release,
>  };
> +EXPORT_SYMBOL_GPL(typec_partner_altmode_dev_type);
>  
>  static struct typec_altmode *
>  typec_register_altmode(struct device *parent,
> diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h
> index 309251572e2e..c6fd46902fce 100644
> --- a/include/linux/usb/typec.h
> +++ b/include/linux/usb/typec.h
> @@ -20,12 +20,15 @@ struct typec_port;
>  struct typec_altmode_ops;
>  struct typec_cable_ops;
>  
> +struct bus_type;
>  struct fwnode_handle;
>  struct device;
>  
>  struct usb_power_delivery;
>  struct usb_power_delivery_desc;
>  
> +extern const struct bus_type typec_bus;
> +
>  enum typec_port_type {
>  	TYPEC_PORT_SRC,
>  	TYPEC_PORT_SNK,
> diff --git a/include/linux/usb/typec_altmode.h b/include/linux/usb/typec_altmode.h
> index f7db3bd4c90e..9197a4637a93 100644
> --- a/include/linux/usb/typec_altmode.h
> +++ b/include/linux/usb/typec_altmode.h
> @@ -9,6 +9,14 @@
>  
>  #define MODE_DISCOVERY_MAX	6
>  
> +extern const struct device_type typec_port_altmode_dev_type;
> +extern const struct device_type typec_plug_altmode_dev_type;
> +extern const struct device_type typec_partner_altmode_dev_type;
> +
> +#define is_typec_port_altmode(dev) ((dev)->type == &typec_port_altmode_dev_type)
> +#define is_typec_plug_altmode(dev) ((dev)->type == &typec_plug_altmode_dev_type)
> +#define is_typec_partner_altmode(dev) ((dev)->type == &typec_partner_altmode_dev_type)
> +
>  struct typec_altmode_ops;
>  
>  /**
> -- 
> 2.51.1

-- 
heikki