Re: [PATCH 1/2] dt-bindings: power: fsl,imx-gpc: Document address-cells

[Frank Li <Frank.li@nxp.com>]

On Mon, Dec 15, 2025 at 08:31:47AM +0100, Alexander Stein wrote:
> Hi,
>
> Am Freitag, 12. Dezember 2025, 18:02:32 CET schrieb Frank Li:
> > On Fri, Dec 12, 2025 at 09:58:59AM +0100, Alexander Stein wrote:
> > > The GPC power controller is an interrupt controllers and can be referenced
> > > in interrupt-map properties, e.g. PCIe controller, thus the node should
> > > have address-cells property.
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >
> > Strange, there are not #address-cells property for gic if there are not
> > ITS node. gic is widely used.
> >
> > Does gic node also missed #address-cells?
>
> Yes and no.
> Yes: see commit faf183a02ed6b ("arm64: dts: imx8mp: Add default GIC address cells")
> No: AFAICS this is only necessary if an interrupt-controller is referenced
> from within interrupt-map. But on imx6qdl.dtsi 'intc' (GIC) is not used that way.

Thanks.

Frank

>
> Best regards,
> Alexander
>
> >
> > Frank
> >
> > > ---
> > >  Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > > index 9de3fe73c1eb6..d49a5130b87c7 100644
> > > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
> > > @@ -38,6 +38,9 @@ properties:
> > >    reg:
> > >      maxItems: 1
> > >
> > > +  "#address-cells":
> > > +    const: 0
> > > +
> > >    interrupts:
> > >      maxItems: 1
> > >
> > > --
> > > 2.43.0
> > >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/