From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59423D6ACD4 for ; Thu, 18 Dec 2025 09:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eIkJKJ52ISK1XSyElgoQQvt41nWa/8DG8BntQE59pR4=; b=X+OSSXtqLdUlUQflQFUGtH1Gg3 K1kuo4GUnPQ5chPznUJIPpZksyZUTAmU8C+tZYIEc9TAem1phZveyJF5GtwPlTfjwIK1lZpBSIRBg t3KFzMZaGGM1OkMV9SIo2PNNrLOA2lhxcNbB4zpi4wplP677H5dG7YQ1KUFhg8tZZDRi1WyRzfZPZ DBZCwc333YswfpM3b16Iw51cn/Sr2ewSDK+2O3QlIoQLmSs0K8ZF0bSE3fdonbFQH7xowD1eBoZa3 5iWuJmrusHA3a+MvCMFiPc2f0SzRSVE1ds+G3F7cMx/ZDMXyJwNhmRptxlyiqDyTa6YDWLQp+qdDt l82VNx1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWA0j-000000087U0-0Jaw; Thu, 18 Dec 2025 09:09:25 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWA0f-000000087TQ-4BtU for linux-arm-kernel@lists.infradead.org; Thu, 18 Dec 2025 09:09:23 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vWA0S-0000bE-Cz; Thu, 18 Dec 2025 10:09:08 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vWA0R-006FaQ-1N; Thu, 18 Dec 2025 10:09:07 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1vWA0R-00EXba-0t; Thu, 18 Dec 2025 10:09:07 +0100 Date: Thu, 18 Dec 2025 10:09:07 +0100 From: Michael Tretter To: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Pengutronix Kernel Team , Fabio Estevam , Hans Verkuil Cc: linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Michael Tretter , Frank Li Subject: Re: [PATCH v2 0/2] media: staging: imx: fix multiple video input Message-ID: Mail-Followup-To: Michael Tretter , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Pengutronix Kernel Team , Fabio Estevam , Hans Verkuil , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Michael Tretter , Frank Li References: <20251107-media-imx-fixes-v2-0-07d949964194@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251107-media-imx-fixes-v2-0-07d949964194@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: m.tretter@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251218_010922_034844_5579310E X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 07 Nov 2025 11:34:32 +0100, Michael Tretter wrote: > If the IMX media pipeline is configured to receive multiple video > inputs, the second input stream may be broken on start. This happens if > the IMX CSI hardware has to be reconfigured for the second stream, while > the first stream is already running. > > The IMX CSI driver configures the IMX CSI in the link_validate callback. > The media pipeline is only validated on the first start. Thus, any later > start of the media pipeline skips the validation and directly starts > streaming. This may leave the hardware in an inconsistent state compared > to the driver configuration. Moving the hardware configuration to the > stream start to make sure that the hardware is configured correctly. > > Patch 1 removes the caching of the upstream mbus_config in > csi_link_validate and explicitly request the mbus_config in csi_start, > to get rid of this implicit dependency. > > Patch 2 actually moves the hardware register setting from > csi_link_validate to csi_start to fix the skipped hardware > reconfiguration. Gentle ping. Michael > > Signed-off-by: Michael Tretter > --- > Changes in v2: > - Document changed locking in commit message > - Link to v1: https://lore.kernel.org/r/20251105-media-imx-fixes-v1-0-99e48b4f5cbc@pengutronix.de > > --- > Michael Tretter (2): > media: staging: imx: request mbus_config in csi_start > media: staging: imx: configure src_mux in csi_start > > drivers/staging/media/imx/imx-media-csi.c | 84 ++++++++++++++++++------------- > 1 file changed, 48 insertions(+), 36 deletions(-) > --- > base-commit: 27afd6e066cfd80ddbe22a4a11b99174ac89cced > change-id: 20251105-media-imx-fixes-acef77c7ba12