* [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin for ArmSoM Sige5
2025-12-20 10:00 [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5 Chukun Pan
@ 2025-12-20 10:00 ` Chukun Pan
2025-12-22 13:28 ` Sebastian Reichel
2025-12-20 10:00 ` [PATCH 3/3] arm64: dts: rockchip: enable saradc " Chukun Pan
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Chukun Pan @ 2025-12-20 10:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Chukun Pan, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
Although the hp_det pin is not used, according to the schematic,
the headphone detection pin is GPIO4_B0. Fix the incorrect pin.
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index 392ba83ab05a..a0d8f52a706f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -812,8 +812,8 @@ gmac1_rst: gmac1-rst {
};
headphone {
- hp_det: hp-det {
- rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
+ hp_det_l: hp-det-l {
+ rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin for ArmSoM Sige5
2025-12-20 10:00 ` [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin " Chukun Pan
@ 2025-12-22 13:28 ` Sebastian Reichel
0 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2025-12-22 13:28 UTC (permalink / raw)
To: Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]
Hi,
On Sat, Dec 20, 2025 at 06:00:09PM +0800, Chukun Pan wrote:
> Although the hp_det pin is not used, according to the schematic,
> the headphone detection pin is GPIO4_B0. Fix the incorrect pin.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
Apparently all of the public schematics (board rev 1.1 - 1.3) have
HP_DET_L connected to GPIO4_B0. It's also easy to see how the wrong
pin ended up in the DT: the schematics also added HP_DET_L as a
comment to GPIO0_D3 (which is actually connected to TP_RST_L)!
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> index 392ba83ab05a..a0d8f52a706f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> @@ -812,8 +812,8 @@ gmac1_rst: gmac1-rst {
> };
>
> headphone {
> - hp_det: hp-det {
> - rockchip,pins = <0 RK_PD3 RK_FUNC_GPIO &pcfg_pull_up>;
> + hp_det_l: hp-det-l {
> + rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> };
> };
>
> --
> 2.25.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
2025-12-20 10:00 [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5 Chukun Pan
2025-12-20 10:00 ` [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin " Chukun Pan
@ 2025-12-20 10:00 ` Chukun Pan
2025-12-22 13:32 ` Sebastian Reichel
2025-12-22 13:24 ` [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator " Sebastian Reichel
2025-12-22 13:38 ` Heiko Stuebner
3 siblings, 1 reply; 8+ messages in thread
From: Chukun Pan @ 2025-12-20 10:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Chukun Pan, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
Add ADC support to ArmSoM Sige5 board.
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index a0d8f52a706f..d372ba252af8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -897,6 +897,11 @@ &sai6 {
status = "okay";
};
+&saradc {
+ vref-supply = <&vcca_1v8_s0>;
+ status = "okay";
+};
+
&sdhci {
bus-width = <8>;
full-pwr-cycle-in-suspend;
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
2025-12-20 10:00 ` [PATCH 3/3] arm64: dts: rockchip: enable saradc " Chukun Pan
@ 2025-12-22 13:32 ` Sebastian Reichel
2025-12-22 13:39 ` Heiko Stuebner
0 siblings, 1 reply; 8+ messages in thread
From: Sebastian Reichel @ 2025-12-22 13:32 UTC (permalink / raw)
To: Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
Hi,
On Sat, Dec 20, 2025 at 06:00:10PM +0800, Chukun Pan wrote:
> Add ADC support to ArmSoM Sige5 board.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
The reference voltage is different between the different board
revisions. Older boards (1.1 and 1.2) have SARADC_AVDD1V8 connected
to &vcca_1v8_s0, but newer boards (1.3) use VCCA1V8_PLDO2_S0
instead. I guess considering &vcca1v8_pldo2_s0 is marked as always
on, we can ignore this difference, but I think it's worth a comment
in the DT and the commit description. Otherwise:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> index a0d8f52a706f..d372ba252af8 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> @@ -897,6 +897,11 @@ &sai6 {
> status = "okay";
> };
>
> +&saradc {
> + vref-supply = <&vcca_1v8_s0>;
> + status = "okay";
> +};
> +
> &sdhci {
> bus-width = <8>;
> full-pwr-cycle-in-suspend;
> --
> 2.25.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
2025-12-22 13:32 ` Sebastian Reichel
@ 2025-12-22 13:39 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-12-22 13:39 UTC (permalink / raw)
To: Chukun Pan, Sebastian Reichel
Cc: Rob Herring, Conor Dooley, Krzysztof Kozlowski, linux-arm-kernel,
linux-rockchip, linux-kernel, devicetree
Am Montag, 22. Dezember 2025, 14:32:53 Mitteleuropäische Normalzeit schrieb Sebastian Reichel:
> Hi,
>
> On Sat, Dec 20, 2025 at 06:00:10PM +0800, Chukun Pan wrote:
> > Add ADC support to ArmSoM Sige5 board.
> >
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > ---
>
> The reference voltage is different between the different board
> revisions. Older boards (1.1 and 1.2) have SARADC_AVDD1V8 connected
> to &vcca_1v8_s0, but newer boards (1.3) use VCCA1V8_PLDO2_S0
> instead. I guess considering &vcca1v8_pldo2_s0 is marked as always
> on, we can ignore this difference, but I think it's worth a comment
> in the DT and the commit description. Otherwise:
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
darn, too late for this one - should've waited longer for
this possible Rb :-) ... I did add the others before pushing
though.
Heiko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5
2025-12-20 10:00 [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5 Chukun Pan
2025-12-20 10:00 ` [PATCH 2/3] arm64: dts: rockchip: fix hp-det pin " Chukun Pan
2025-12-20 10:00 ` [PATCH 3/3] arm64: dts: rockchip: enable saradc " Chukun Pan
@ 2025-12-22 13:24 ` Sebastian Reichel
2025-12-22 13:38 ` Heiko Stuebner
3 siblings, 0 replies; 8+ messages in thread
From: Sebastian Reichel @ 2025-12-22 13:24 UTC (permalink / raw)
To: Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]
Hi,
On Sat, Dec 20, 2025 at 06:00:08PM +0800, Chukun Pan wrote:
> According to the schematic, RTC is powered by vcc_3v3_s3.
> The vcc_3v3_rtc_s5 regulator does not exist, remove it.
>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
That's true for all board revisions that have a public schematic
(1.1, 1.2 and 1.3), so:
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> index 3386084f6318..392ba83ab05a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
> @@ -156,16 +156,6 @@ vcc_3v3_pcie: regulator-vcc-3v3-pcie {
> vin-supply = <&vcc_5v0_sys>;
> };
>
> - vcc_3v3_rtc_s5: regulator-vcc-3v3-rtc-s5 {
> - compatible = "regulator-fixed";
> - regulator-name = "vcc_3v3_rtc_s5";
> - regulator-boot-on;
> - regulator-always-on;
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - vin-supply = <&vcc_5v0_sys>;
> - };
> -
> vcc_3v3_s0: regulator-vcc-3v3-s0 {
> compatible = "regulator-fixed";
> regulator-name = "vcc_3v3_s0";
> --
> 2.25.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5
2025-12-20 10:00 [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5 Chukun Pan
` (2 preceding siblings ...)
2025-12-22 13:24 ` [PATCH 1/3] arm64: dts: rockchip: remove rtc regulator " Sebastian Reichel
@ 2025-12-22 13:38 ` Heiko Stuebner
3 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-12-22 13:38 UTC (permalink / raw)
To: Chukun Pan
Cc: Heiko Stuebner, Rob Herring, Conor Dooley, Krzysztof Kozlowski,
linux-arm-kernel, linux-rockchip, linux-kernel, devicetree
On Sat, 20 Dec 2025 18:00:08 +0800, Chukun Pan wrote:
> According to the schematic, RTC is powered by vcc_3v3_s3.
> The vcc_3v3_rtc_s5 regulator does not exist, remove it.
>
>
Applied, thanks!
[1/3] arm64: dts: rockchip: remove rtc regulator for ArmSoM Sige5
commit: 3fc7029d3009682b27be2fa2cd2269bc6f104c2e
[2/3] arm64: dts: rockchip: fix hp-det pin for ArmSoM Sige5
commit: 341735d92ff868eb4c46beafb313d66f015809be
[3/3] arm64: dts: rockchip: enable saradc for ArmSoM Sige5
commit: 3025d360f03515d3f6396a5cec339e776d62b2da
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread