* [PATCH 1/2] arm64: dts: arm: Use hyphen in node names
@ 2025-12-23 15:24 Krzysztof Kozlowski
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-23 15:24 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vincenzo Frascino, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
linux-arm-kernel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DTS coding style prefers hyphens instead of underscores in the node
names. Change should be safe, because node names are not considered an
ABI.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Patches done with sed, verified with comparing unflattened DTB and
dtx_diff.
---
arch/arm64/boot/dts/arm/morello-fvp.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/arm/morello-fvp.dts b/arch/arm64/boot/dts/arm/morello-fvp.dts
index 2072c0b72325..4a3f217555f7 100644
--- a/arch/arm64/boot/dts/arm/morello-fvp.dts
+++ b/arch/arm64/boot/dts/arm/morello-fvp.dts
@@ -25,25 +25,25 @@ bp_refclock24mhz: clock-24000000 {
clock-output-names = "bp:clock24mhz";
};
- block_0: virtio_block@1c170000 {
+ block_0: virtio-block@1c170000 {
compatible = "virtio,mmio";
reg = <0x0 0x1c170000 0x0 0x200>;
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
};
- net_0: virtio_net@1c180000 {
+ net_0: virtio-net@1c180000 {
compatible = "virtio,mmio";
reg = <0x0 0x1c180000 0x0 0x200>;
interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
};
- rng_0: virtio_rng@1c190000 {
+ rng_0: virtio-rng@1c190000 {
compatible = "virtio,mmio";
reg = <0x0 0x1c190000 0x0 0x200>;
interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
};
- p9_0: virtio_p9@1c1a0000 {
+ p9_0: virtio-p9@1c1a0000 {
compatible = "virtio,mmio";
reg = <0x0 0x1c1a0000 0x0 0x200>;
interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] arm64: dts: arm: Use lowercase hex
2025-12-23 15:24 [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Krzysztof Kozlowski
@ 2025-12-23 15:24 ` Krzysztof Kozlowski
2025-12-24 11:59 ` Vincenzo Frascino
2026-01-01 17:15 ` Sudeep Holla
2025-12-24 11:58 ` [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Vincenzo Frascino
2026-01-01 17:52 ` Sudeep Holla
2 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-23 15:24 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vincenzo Frascino, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
linux-arm-kernel, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The DTS code coding style expects lowercase hex for values and unit
addresses.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/arm/arm-realview-eb.dtsi | 2 +-
arch/arm/boot/dts/arm/arm-realview-pb1176.dts | 2 +-
arch/arm/boot/dts/arm/arm-realview-pb11mp.dts | 2 +-
arch/arm/boot/dts/arm/arm-realview-pbx.dtsi | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/arm/arm-realview-eb.dtsi b/arch/arm/boot/dts/arm/arm-realview-eb.dtsi
index 16f784da5a55..ae370d4eb9d8 100644
--- a/arch/arm/boot/dts/arm/arm-realview-eb.dtsi
+++ b/arch/arm/boot/dts/arm/arm-realview-eb.dtsi
@@ -234,7 +234,7 @@ oscclk0: clock-controller@c {
reg = <0x0c 0x04>;
#clock-cells = <0>;
lock-offset = <0x20>;
- vco-offset = <0x0C>;
+ vco-offset = <0x0c>;
clocks = <&xtal24mhz>;
};
oscclk1: clock-controller@10 {
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
index b9b10cbd65aa..a75d8b107fe1 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
@@ -260,7 +260,7 @@ oscclk0: clock-controller@c {
reg = <0x0c 0x04>;
#clock-cells = <0>;
lock-offset = <0x20>;
- vco-offset = <0x0C>;
+ vco-offset = <0x0c>;
clocks = <&xtal24mhz>;
};
oscclk1: clock-controller@10 {
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts b/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
index db1b6793cd2c..59c78def83f2 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
@@ -343,7 +343,7 @@ oscclk0: clock-controller@c {
reg = <0x0c 0x04>;
#clock-cells = <0>;
lock-offset = <0x20>;
- vco-offset = <0x0C>;
+ vco-offset = <0x0c>;
clocks = <&xtal24mhz>;
};
oscclk1: clock-controller@10 {
diff --git a/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi b/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi
index e625403a9456..0d3d96ffa6e6 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi
+++ b/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi
@@ -256,7 +256,7 @@ oscclk0: clock-controller@c {
reg = <0x0c 0x04>;
#clock-cells = <0>;
lock-offset = <0x20>;
- vco-offset = <0x0C>;
+ vco-offset = <0x0c>;
clocks = <&xtal24mhz>;
};
oscclk1: clock-controller@10 {
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: arm: Use lowercase hex
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
@ 2025-12-24 11:59 ` Vincenzo Frascino
2026-01-01 17:15 ` Sudeep Holla
1 sibling, 0 replies; 6+ messages in thread
From: Vincenzo Frascino @ 2025-12-24 11:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liviu Dudau, Sudeep Holla,
Lorenzo Pieralisi, linux-arm-kernel, devicetree, linux-kernel
On 23/12/2025 15:24, Krzysztof Kozlowski wrote:
> The DTS code coding style expects lowercase hex for values and unit
> addresses.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
> arch/arm/boot/dts/arm/arm-realview-eb.dtsi | 2 +-
> arch/arm/boot/dts/arm/arm-realview-pb1176.dts | 2 +-
> arch/arm/boot/dts/arm/arm-realview-pb11mp.dts | 2 +-
> arch/arm/boot/dts/arm/arm-realview-pbx.dtsi | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/arm/arm-realview-eb.dtsi b/arch/arm/boot/dts/arm/arm-realview-eb.dtsi
> index 16f784da5a55..ae370d4eb9d8 100644
> --- a/arch/arm/boot/dts/arm/arm-realview-eb.dtsi
> +++ b/arch/arm/boot/dts/arm/arm-realview-eb.dtsi
> @@ -234,7 +234,7 @@ oscclk0: clock-controller@c {
> reg = <0x0c 0x04>;
> #clock-cells = <0>;
> lock-offset = <0x20>;
> - vco-offset = <0x0C>;
> + vco-offset = <0x0c>;
> clocks = <&xtal24mhz>;
> };
> oscclk1: clock-controller@10 {
> diff --git a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
> index b9b10cbd65aa..a75d8b107fe1 100644
> --- a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
> +++ b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
> @@ -260,7 +260,7 @@ oscclk0: clock-controller@c {
> reg = <0x0c 0x04>;
> #clock-cells = <0>;
> lock-offset = <0x20>;
> - vco-offset = <0x0C>;
> + vco-offset = <0x0c>;
> clocks = <&xtal24mhz>;
> };
> oscclk1: clock-controller@10 {
> diff --git a/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts b/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
> index db1b6793cd2c..59c78def83f2 100644
> --- a/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
> +++ b/arch/arm/boot/dts/arm/arm-realview-pb11mp.dts
> @@ -343,7 +343,7 @@ oscclk0: clock-controller@c {
> reg = <0x0c 0x04>;
> #clock-cells = <0>;
> lock-offset = <0x20>;
> - vco-offset = <0x0C>;
> + vco-offset = <0x0c>;
> clocks = <&xtal24mhz>;
> };
> oscclk1: clock-controller@10 {
> diff --git a/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi b/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi
> index e625403a9456..0d3d96ffa6e6 100644
> --- a/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi
> +++ b/arch/arm/boot/dts/arm/arm-realview-pbx.dtsi
> @@ -256,7 +256,7 @@ oscclk0: clock-controller@c {
> reg = <0x0c 0x04>;
> #clock-cells = <0>;
> lock-offset = <0x20>;
> - vco-offset = <0x0C>;
> + vco-offset = <0x0c>;
> clocks = <&xtal24mhz>;
> };
> oscclk1: clock-controller@10 {
--
Regards,
Vincenzo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: arm: Use lowercase hex
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
2025-12-24 11:59 ` Vincenzo Frascino
@ 2026-01-01 17:15 ` Sudeep Holla
1 sibling, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2026-01-01 17:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vincenzo Frascino, Liviu Dudau, Lorenzo Pieralisi,
linux-arm-kernel, devicetree, linux-kernel
On Tue, Dec 23, 2025 at 04:24:59PM +0100, Krzysztof Kozlowski wrote:
> The DTS code coding style expects lowercase hex for values and unit
> addresses.
>
s/arm64/ARM in $subject would be ideal.
Anyways,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Linus,
I assume you will send it to arm-soc. Please shout if you want be to act
on this.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: arm: Use hyphen in node names
2025-12-23 15:24 [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Krzysztof Kozlowski
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
@ 2025-12-24 11:58 ` Vincenzo Frascino
2026-01-01 17:52 ` Sudeep Holla
2 siblings, 0 replies; 6+ messages in thread
From: Vincenzo Frascino @ 2025-12-24 11:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Liviu Dudau, Sudeep Holla,
Lorenzo Pieralisi, linux-arm-kernel, devicetree, linux-kernel
On 23/12/2025 15:24, Krzysztof Kozlowski wrote:
> DTS coding style prefers hyphens instead of underscores in the node
> names. Change should be safe, because node names are not considered an
> ABI.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
Acked-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>
> Patches done with sed, verified with comparing unflattened DTB and
> dtx_diff.
> ---
> arch/arm64/boot/dts/arm/morello-fvp.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/arm/morello-fvp.dts b/arch/arm64/boot/dts/arm/morello-fvp.dts
> index 2072c0b72325..4a3f217555f7 100644
> --- a/arch/arm64/boot/dts/arm/morello-fvp.dts
> +++ b/arch/arm64/boot/dts/arm/morello-fvp.dts
> @@ -25,25 +25,25 @@ bp_refclock24mhz: clock-24000000 {
> clock-output-names = "bp:clock24mhz";
> };
>
> - block_0: virtio_block@1c170000 {
> + block_0: virtio-block@1c170000 {
> compatible = "virtio,mmio";
> reg = <0x0 0x1c170000 0x0 0x200>;
> interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - net_0: virtio_net@1c180000 {
> + net_0: virtio-net@1c180000 {
> compatible = "virtio,mmio";
> reg = <0x0 0x1c180000 0x0 0x200>;
> interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - rng_0: virtio_rng@1c190000 {
> + rng_0: virtio-rng@1c190000 {
> compatible = "virtio,mmio";
> reg = <0x0 0x1c190000 0x0 0x200>;
> interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - p9_0: virtio_p9@1c1a0000 {
> + p9_0: virtio-p9@1c1a0000 {
> compatible = "virtio,mmio";
> reg = <0x0 0x1c1a0000 0x0 0x200>;
> interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
--
Regards,
Vincenzo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: arm: Use hyphen in node names
2025-12-23 15:24 [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Krzysztof Kozlowski
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
2025-12-24 11:58 ` [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Vincenzo Frascino
@ 2026-01-01 17:52 ` Sudeep Holla
2 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2026-01-01 17:52 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vincenzo Frascino, Liviu Dudau, Lorenzo Pieralisi,
linux-arm-kernel, devicetree, linux-kernel, Krzysztof Kozlowski
Cc: Sudeep Holla
On Tue, 23 Dec 2025 16:24:58 +0100, Krzysztof Kozlowski wrote:
> DTS coding style prefers hyphens instead of underscores in the node
> names. Change should be safe, because node names are not considered an
> ABI.
>
Applied to sudeep.holla/linux (for-next/juno/updates), thanks!
[1/2] arm64: dts: arm: Use hyphen in node names
https://git.kernel.org/sudeep.holla/c/f0d0f087227c
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-01-01 17:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-23 15:24 [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Krzysztof Kozlowski
2025-12-23 15:24 ` [PATCH 2/2] arm64: dts: arm: Use lowercase hex Krzysztof Kozlowski
2025-12-24 11:59 ` Vincenzo Frascino
2026-01-01 17:15 ` Sudeep Holla
2025-12-24 11:58 ` [PATCH 1/2] arm64: dts: arm: Use hyphen in node names Vincenzo Frascino
2026-01-01 17:52 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).