From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3CB0C79F86 for ; Mon, 5 Jan 2026 12:15:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pALCUxgG0Sih3gS1zvT5EYeP9u7uxFAHJ/wplVNqgIA=; b=tPQRuY3xDVaQZcnxdzTku+jW1i OZb+SUaoawxiQutob3kRqyntfti0bkpn9+YaERWWs0tyjz4T4ZeMJvwddk8dvWLLnORk+aFRWWdBW Adv5hahWhTvZXXaalgoPn7gO2x58Pfj0gc0mqnv9ekl6CJ35BP2DGvA5WHnsFDr9fLagDDTYr7ID6 v1iUsG1YoYv13mxtNHyLATYF+A3MOlDv1hk0S9IuRzebHAyFCrJUuFNMZm57geWC9mSukkYg7F89+ 8l+X7Ze/Cta29YwAqLFYYXbCH0WivudV6779m4bTZkLjHarTLk03lNyxqzLvVFRw+r1phtgw+ITg9 4LPP3lug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcjU7-0000000BGFZ-0o5Z; Mon, 05 Jan 2026 12:14:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vcjU4-0000000BGDi-17kG for linux-arm-kernel@lists.infradead.org; Mon, 05 Jan 2026 12:14:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767615289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pALCUxgG0Sih3gS1zvT5EYeP9u7uxFAHJ/wplVNqgIA=; b=CL8esZY1GYAaPV/IZ7WsWlwGBj13y/IQcaqsIRArVMNb5/Q+NTkVPMf6qcDry5aokXap+e Qp3p7aLxStjtEwdF7suBn1LLJZHAcxe29ykATjuPh/UQWkCkZjh/RbkOKXgCNOGU26R51K fLMcj8qiKFH4EZ8ys6ngGpc5mZR7w5M= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-jIYIrZp1OYWi42NdnK7joQ-1; Mon, 05 Jan 2026 07:14:48 -0500 X-MC-Unique: jIYIrZp1OYWi42NdnK7joQ-1 X-Mimecast-MFC-AGG-ID: jIYIrZp1OYWi42NdnK7joQ_1767615287 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8ba026720eeso2340169485a.1 for ; Mon, 05 Jan 2026 04:14:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767615287; x=1768220087; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pALCUxgG0Sih3gS1zvT5EYeP9u7uxFAHJ/wplVNqgIA=; b=HryvFGiUBR+WF706dQ/vhT7r22eY4pISImMT+H62YmAZvBBWWBX6mZt13kApws6FA9 10TFmdAj0MGIreIxe4md21PWC4GD7Dnv5AhUjlBVGmbUtBI83yYYsatjBhfLUo6LMb/A XVWOxlGU7AJjrYSo2gvZFJQ2G5Rzum28bNZwAzou1NmcHvl5Hp2wiz2rFAm5l9qWvbmI +4jlxUkU2IQ2yHOHz+OmPvIjdM+PZ3eh3jLqueBJA9ww00fylrPdr3Yz3DGfrsE/4Pya 1upNuiUoHwDuL5zifHcpFgeWPtvN+cRHJlaYI0IsEojVvTuB6dx4roWjFQv2ajFwGIM2 5+9Q== X-Forwarded-Encrypted: i=1; AJvYcCXn3SQSlowPL5bbCHDD28Px7TO/AIwOAeQ58OooHTSMzgkFJogDzcsG9QRGYflg4vq9ifgPWIT63xjJ9jAK4Xaw@lists.infradead.org X-Gm-Message-State: AOJu0Yw351s3O7cRkNvm4rkB8ZwOBYtrlvVbSfcEpdgJMA08RlDqqE76 igeACUq1oUsyzDyn5LyzrBbmxO3owM+XzJ53ewRdP4qzHfEGnx6zgREPbKceKssp3pX3ORwa4BL q3I3jzZ1cOI7t9ZuQA/5uORZMjOZo4LF/c+gViZ8VFOG3VGCihO59Dmax09PJK047hgx+eeBQus 2Z X-Gm-Gg: AY/fxX4FLviz4quCt3JOCUfZ9uhXuQuX0T6IBxEzySnCX9uRgl7iHWYcc4p4vqt59g7 uUOBz/sQsKa1ErltKoqR7bnZtagAwGGSGmP0mZP5lyMxOLgK1HxsQK6W9gy0vpjLJprMZbNydaw 3QMRZXd2kN2mK2N1MZzGzSdUOfQM0K02a928gGhgkrrJtFAYn+adlzR+UvrOBCjVS00ts8LUHZv ySkZlLlwm5rWMhLJw4UwK9h7zsjYo+WgyDXBf1XyZiDVZbGGdutAIvr656Mk2V947Q7zboy3w++ zCBEYCBaxrc8R1LdUjA1xJFzScH5opK/w7vUzlE+nJZHGf5CjAP5nB6JtEemrzxG2jRFQPzMbUq 7mtBTJfm+pp/JapFgEbG6ybMwq1Sa+kOzOnRUrirLqkge X-Received: by 2002:a05:620a:44d5:b0:8b2:d6eb:8203 with SMTP id af79cd13be357-8c090501db3mr7123131185a.69.1767615287428; Mon, 05 Jan 2026 04:14:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFX37kzKtyI4pVa2B6zkJ45mbfVDYf5b4bq6gq1EC+G2OfHkde7TEgVCraCyU1NH7StTtKeCg== X-Received: by 2002:a05:620a:44d5:b0:8b2:d6eb:8203 with SMTP id af79cd13be357-8c090501db3mr7123126885a.69.1767615286882; Mon, 05 Jan 2026 04:14:46 -0800 (PST) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c0971ee247sm3701650785a.27.2026.01.05.04.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 04:14:45 -0800 (PST) Date: Mon, 5 Jan 2026 07:14:43 -0500 From: Brian Masney To: Geert Uytterhoeven Cc: Vinod Koul , Kishon Vijay Abraham I , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heiko Stuebner , Neil Armstrong , Stephen Boyd , Maxime Ripard , linux-clk@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 9/9] phy: ti: phy-j721e-wiz: convert from round_rate() to determine_rate() Message-ID: References: <20251212-phy-clk-round-rate-v3-0-beae3962f767@redhat.com> <20251212-phy-clk-round-rate-v3-9-beae3962f767@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: O04IgqkexL_gEYvgX4vt0eahFoVG39HZPigaZ-Gq2SU_1767615287 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260105_041452_370461_6A3A5FDD X-CRM114-Status: GOOD ( 23.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Mon, Dec 29, 2025 at 11:18:52AM +0100, Geert Uytterhoeven wrote: > Hi Brian, > > On Fri, 12 Dec 2025 at 00:21, Brian Masney wrote: > > The round_rate() clk ops is deprecated, so migrate this driver from > > round_rate() to determine_rate() using the Coccinelle semantic patch > > on the cover letter of this series. > > > > Signed-off-by: Brian Masney > > Thanks for your patch, which is now commit 27287e3b52b5954b ("phy: > ti: phy-j721e-wiz: convert from round_rate() to determine_rate()") > in phy/next > > > --- a/drivers/phy/ti/phy-j721e-wiz.c > > +++ b/drivers/phy/ti/phy-j721e-wiz.c > > @@ -934,12 +934,15 @@ static unsigned long wiz_clk_div_recalc_rate(struct clk_hw *hw, > > return divider_recalc_rate(hw, parent_rate, val, div->table, 0x0, 2); > > } > > > > -static long wiz_clk_div_round_rate(struct clk_hw *hw, unsigned long rate, > > - unsigned long *prate) > > +static int wiz_clk_div_determine_rate(struct clk_hw *hw, > > + struct clk_rate_request *req) > > { > > struct wiz_clk_divider *div = to_wiz_clk_div(hw); > > > > - return divider_round_rate(hw, rate, prate, div->table, 2, 0x0); > > + req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, > > + div->table, 2, 0x0); > > Is this correct? divider_round_rate() can return a negative error code > (from divider_ro_determine_rate()), which is not handled here? > > Looks like several other users of divider_round_rate() use this > same logic, and thus are affected, too. Thanks for the review! You are correct that this is a bug. I had planned once round_rate is removed from the clk core to post a series to remove divider_round_rate() and divider_ro_round_rate() (plus the _parent functions) since they call the corresponding determine_rate functions. I'll bump that up on my todo list this week. Brian