Re: [PATCH] arm64: dts: rockchip: Fix wrong register range of rk3576 gpu

Chaoyi Chen
2026-01-06T01:14:09Z

Hi Sebasitian,

On 1/6/2026 3:24 AM, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Dec 30, 2025 at 05:02:46PM +0800, Chaoyi Chen wrote:
>> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>>
>> According to RK3576 TRM part1 page13, the size of the GPU registers
>> is 128 KB.
>
> RK3576 TRM V1.2 has the address mapping on page 15. Maybe just
> reference "Table 1-1 Address Mapping" instead of giving a page
> number?
>
> I think it makes sense to add the following extra text:
>
> The current mapping incorrectly includes the addresses of multiple
> following IP like the eInk interface at 0x27900000. This has not
> been detected by the DT tooling as none of the extra mapped IP is
> described in the upstream RK3576 DT so far.
>

I will add these info in v2. Thank you :)

>> Fixes: 57b1ce903966 ("arm64: dts: rockchip: Add rk3576 SoC base DT")
>> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>> ---
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Greetings,
>
> -- Sebastian
>
>> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> index 6284e7bdc442..b375015f0662 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> @@ -1271,7 +1271,7 @@ power-domain@RK3576_PD_VO1 {
>>
>> gpu: gpu@27800000 {
>> compatible = "rockchip,rk3576-mali", "arm,mali-bifrost";
>> - reg = <0x0 0x27800000 0x0 0x200000>;
>> + reg = <0x0 0x27800000 0x0 0x20000>;
>> assigned-clocks = <&scmi_clk SCMI_CLK_GPU>;
>> assigned-clock-rates = <198000000>;
>> clocks = <&cru CLK_GPU>;
>> --
>> 2.51.1
>>

--
Best,
Chaoyi