* [PATCH v2] remoteproc: imx_dsp_rproc: only reset carveout memory at RPROC_OFFLINE state
@ 2025-12-18 7:17 Shengjiu Wang
2025-12-18 15:39 ` Frank Li
2026-01-05 21:09 ` Mathieu Poirier
0 siblings, 2 replies; 3+ messages in thread
From: Shengjiu Wang @ 2025-12-18 7:17 UTC (permalink / raw)
To: andersson, mathieu.poirier, shawnguo, s.hauer, kernel, festevam,
daniel.baluta, linux-remoteproc, imx, linux-arm-kernel,
linux-kernel
Do not reset memory at suspend and resume stage, because some
memory is used to save the software state for resume, if it is cleared,
the resume operation can fail.
Fixes: c4c432dfb00f ("remoteproc: imx_dsp_rproc: Add support of recovery and coredump process")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
---
changes in v2:
- refine commit message.
drivers/remoteproc/imx_dsp_rproc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
index d03017d6b214..ac8aa71aa56c 100644
--- a/drivers/remoteproc/imx_dsp_rproc.c
+++ b/drivers/remoteproc/imx_dsp_rproc.c
@@ -984,9 +984,11 @@ static int imx_dsp_rproc_load(struct rproc *rproc, const struct firmware *fw)
* Clear buffers after pm rumtime for internal ocram is not
* accessible if power and clock are not enabled.
*/
- list_for_each_entry(carveout, &rproc->carveouts, node) {
- if (carveout->va)
- memset(carveout->va, 0, carveout->len);
+ if (rproc->state == RPROC_OFFLINE) {
+ list_for_each_entry(carveout, &rproc->carveouts, node) {
+ if (carveout->va)
+ memset(carveout->va, 0, carveout->len);
+ }
}
ret = imx_dsp_rproc_elf_load_segments(rproc, fw);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] remoteproc: imx_dsp_rproc: only reset carveout memory at RPROC_OFFLINE state
2025-12-18 7:17 [PATCH v2] remoteproc: imx_dsp_rproc: only reset carveout memory at RPROC_OFFLINE state Shengjiu Wang
@ 2025-12-18 15:39 ` Frank Li
2026-01-05 21:09 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-12-18 15:39 UTC (permalink / raw)
To: Shengjiu Wang
Cc: andersson, mathieu.poirier, shawnguo, s.hauer, kernel, festevam,
daniel.baluta, linux-remoteproc, imx, linux-arm-kernel,
linux-kernel
On Thu, Dec 18, 2025 at 03:17:50PM +0800, Shengjiu Wang wrote:
> Do not reset memory at suspend and resume stage, because some
> memory is used to save the software state for resume, if it is cleared,
> the resume operation can fail.
>
> Fixes: c4c432dfb00f ("remoteproc: imx_dsp_rproc: Add support of recovery and coredump process")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> ---
> changes in v2:
> - refine commit message.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> drivers/remoteproc/imx_dsp_rproc.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index d03017d6b214..ac8aa71aa56c 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -984,9 +984,11 @@ static int imx_dsp_rproc_load(struct rproc *rproc, const struct firmware *fw)
> * Clear buffers after pm rumtime for internal ocram is not
> * accessible if power and clock are not enabled.
> */
> - list_for_each_entry(carveout, &rproc->carveouts, node) {
> - if (carveout->va)
> - memset(carveout->va, 0, carveout->len);
> + if (rproc->state == RPROC_OFFLINE) {
> + list_for_each_entry(carveout, &rproc->carveouts, node) {
> + if (carveout->va)
> + memset(carveout->va, 0, carveout->len);
> + }
> }
>
> ret = imx_dsp_rproc_elf_load_segments(rproc, fw);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] remoteproc: imx_dsp_rproc: only reset carveout memory at RPROC_OFFLINE state
2025-12-18 7:17 [PATCH v2] remoteproc: imx_dsp_rproc: only reset carveout memory at RPROC_OFFLINE state Shengjiu Wang
2025-12-18 15:39 ` Frank Li
@ 2026-01-05 21:09 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2026-01-05 21:09 UTC (permalink / raw)
To: Shengjiu Wang
Cc: andersson, shawnguo, s.hauer, kernel, festevam, daniel.baluta,
linux-remoteproc, imx, linux-arm-kernel, linux-kernel
On Thu, Dec 18, 2025 at 03:17:50PM +0800, Shengjiu Wang wrote:
> Do not reset memory at suspend and resume stage, because some
> memory is used to save the software state for resume, if it is cleared,
> the resume operation can fail.
>
> Fixes: c4c432dfb00f ("remoteproc: imx_dsp_rproc: Add support of recovery and coredump process")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>
> ---
> changes in v2:
> - refine commit message.
>
Applied.
Thanks,
Mathieu
> drivers/remoteproc/imx_dsp_rproc.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
> index d03017d6b214..ac8aa71aa56c 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -984,9 +984,11 @@ static int imx_dsp_rproc_load(struct rproc *rproc, const struct firmware *fw)
> * Clear buffers after pm rumtime for internal ocram is not
> * accessible if power and clock are not enabled.
> */
> - list_for_each_entry(carveout, &rproc->carveouts, node) {
> - if (carveout->va)
> - memset(carveout->va, 0, carveout->len);
> + if (rproc->state == RPROC_OFFLINE) {
> + list_for_each_entry(carveout, &rproc->carveouts, node) {
> + if (carveout->va)
> + memset(carveout->va, 0, carveout->len);
> + }
> }
>
> ret = imx_dsp_rproc_elf_load_segments(rproc, fw);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-05 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-18 7:17 [PATCH v2] remoteproc: imx_dsp_rproc: only reset carveout memory at RPROC_OFFLINE state Shengjiu Wang
2025-12-18 15:39 ` Frank Li
2026-01-05 21:09 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).