From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B399D29C2E for ; Mon, 19 Jan 2026 14:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oa6ROnre6vr29aI4SNzN9w1inyxLiiLWv/B/wldB++Y=; b=bgFjJLUCXBX2GqIgYbUBnCgSaB EIeEpjzfSbIcsRCNCQ2emrCwdF2/Oyx6Ru5Kr0iakFwcoCBO3tIox4WK+95y9z2eyG42OzAFGS+v2 N7ttjZ6SDt8fwpr9zjfjysSbesdbGkFKH11XNmhnGKvQea6LNsPLwqXBc7a0Aoq7lE4SsQ1cU1VH2 /4v7APiAfjqFAoQDjR8BBWk2UJOXnzi7iFOri3hhPDDIp/vsL+E94uOWpTwY+nnVnpR0rvX+UC2/Z uKRn7eTvhWv6DpvHRszl3sLeNLOkPE+GAaa+emCrNu4c7HYOkszBIC7P0AJMSf5MWZRkYdfGLjLbU dYxVJuzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vhqEQ-00000002G4I-2VPZ; Mon, 19 Jan 2026 14:27:50 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vhqEO-00000002G1F-3UmX; Mon, 19 Jan 2026 14:27:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oa6ROnre6vr29aI4SNzN9w1inyxLiiLWv/B/wldB++Y=; b=EByHMWRUchgU/DLs8hq0L/dHWD 5zjuKjJVshFuMrahXJ97rRLOWXT4lg8Khdi+FurcsHRmp9K23Qrr+pb9Ni802OPXiWGImH1MB9899 5YA6gGkGVdQdoZSZnI+kqH67ez+gy3ye1dCYk1mn5x97JQ1Jga0290Ng8Fb/XNyttVviHN9IadMhS PCzgIDyYIoJ2+mVJzUsBlBKiqRex1wSbhd3dBWFvXjw/SkAr1K0VYS8HkVag3ITLGt5mOLMyCjt31 JAeD9vVdIE81zOjAwOyJJQRjGN8+Nqsh0jMUmARIYdqc18JVL18kVri1ry9Cr/E2+NMB5a27FijmA +KotNvRA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45064) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vhqEH-000000005IS-46Rj; Mon, 19 Jan 2026 14:27:42 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vhqEE-000000006d8-2VLt; Mon, 19 Jan 2026 14:27:38 +0000 Date: Mon, 19 Jan 2026 14:27:38 +0000 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Maxime Coquelin , Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH net-next 14/14] net: stmmac: report PCS configuration changes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260119_062748_873317_FED5741E X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 19, 2026 at 12:34:47PM +0000, Russell King (Oracle) wrote: > Report if/when qcom-ethqos changes the PCS configuration. With phylink > now setting the PCS configuration, there should be no need for drivers > to change this. > > Signed-off-by: Russell King (Oracle) > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h > index f9e7a7ed840b..6a1e30b10740 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pcs.h > @@ -71,6 +71,7 @@ static inline void dwmac_ctrl_ane(void __iomem *ioaddr, u32 reg, bool ane, > bool srgmi_ral) > { > u32 value = readl(ioaddr + GMAC_AN_CTRL(reg)); > + u32 old = value, diff; > > /* Enable and restart the Auto-Negotiation */ > if (ane) > @@ -84,6 +85,20 @@ static inline void dwmac_ctrl_ane(void __iomem *ioaddr, u32 reg, bool ane, > if (srgmi_ral) > value |= GMAC_AN_CTRL_SGMRAL; > > + diff = old ^ value; > + if (diff & ~GMAC_AN_CTRL_RAN) { > + pr_warn("dwmac: PCS configuration changed from phylink by glue, please report: 0x%08x -> 0x%08x\n", > + old & ~GMAC_AN_CTRL_RAN, value & ~GMAC_AN_CTRL_RAN); > +#define REPORT_BIT(x) \ > + if (diff & GMAC_AN_CTRL_##x) \ > + pr_warn("dwmac: %8s %u -> %u\n", #x, \ > + !!(old & GMAC_AN_CTRL_##x), \ > + !!(value & GMAC_AN_CTRL_##x)) > + REPORT_BIT(ANE); > + REPORT_BIT(SGMRAL); > +#undef REPORT_BIT I notice in patchwork, checkpatch doesn't like the "if" starting the in the macro definition. While that would be true of definitions in kernel header files which can be used anwhere, for such a simple limited usage here, wrapping the thing in do { } while(0) is needless baggage, over- complicates the code, and makes it less readable. So, IMHO, checkpatch is wrong. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!