From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Qiang Ma <maqianga@uniontech.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] kexec: add kexec flag to control debug printing
Date: Tue, 20 Jan 2026 18:15:33 +0800 [thread overview]
Message-ID: <aW9VxaXD60X36ZFV@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20260119154947.e351bfb8e97d91305932e2eb@linux-foundation.org>
On 01/19/26 at 03:49pm, Andrew Morton wrote:
> On Fri, 19 Dec 2025 17:31:30 +0800 Qiang Ma <maqianga@uniontech.com> wrote:
>
> > The commit cbc2fe9d9cb2 ("kexec_file: add kexec_file flag to control
> > debug printing") added the kexec_file flag to control debug printing.
> > However, for arm64, after commit 6f8c1da071a4 ("kexec_file, arm64: print
> > out debugging message if required"), when using the kexec_load interface,
> > the kexec_image_info function is called to print debug message, but
> > it uses kexec_dprintk, which is only available under kexec_file,
> > then when specifying 'kexec -d', kexec_load interface will print nothing.
> >
> > For riscv, commit eb7622d908a09 ("kexec_file, riscv: print out debugging
> > message if required") remove kexec_image_info(), because the content has
> > been printed out in generic code in kexec_file_load, but not in kexec_load.
> >
> > Therefore, in order to solve the two problems mentioned above, for this
> > patchset, several things need to be done:
> >
> > 1. Enabling kexec_dprintk is available for kexec_load.
> > 2. Add some debugging message of the deleted kexec_image_info
> > to generic code.
> > 3. Remove duplicate debugging prints for arm64.
>
> Some additional review input on this series would be good, if someone
> has the time.
As I have said before, I am not fan of this patchset becuase I think
it's not necessary, even though it has no much harm except of adding code.
Leave this to those who like it.
prev parent reply other threads:[~2026-01-20 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 9:31 [PATCH v2 0/4] kexec: add kexec flag to control debug printing Qiang Ma
2025-12-19 9:31 ` [PATCH v2 1/4] kexec: Replace the goto out_unlock with out Qiang Ma
2025-12-19 9:31 ` [PATCH v2 2/4] kexec: add kexec flag to control debug printing Qiang Ma
2025-12-19 9:31 ` [PATCH v2 3/4] kexec: print out debugging message if required for kexec_load Qiang Ma
2025-12-19 9:31 ` [PATCH v2 4/4] arm64: kexec: Adjust the debug print of kexec_image_info Qiang Ma
2026-01-05 20:41 ` Will Deacon
2026-01-19 23:49 ` [PATCH v2 0/4] kexec: add kexec flag to control debug printing Andrew Morton
2026-01-20 10:15 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW9VxaXD60X36ZFV@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maqianga@uniontech.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox