From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19224D2ECF7 for ; Tue, 20 Jan 2026 11:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VjkNqktI4MZMt6SSfHT5UbzSxH8+GJApfRaBdqEuizY=; b=Lu8fLB6Ci6+XFAdltZm5zW9yvx eqD7ECRTNI3TALO8nP5MvwV3rWSNCByGgRWnHjsCUkTjuAN4mBy/5n5gpR/m16fnc9rxBPhxpLACs 4lP9QpMUhF85Yn/6PGcJOiMxgwwSjQnfaA/91A8jmWtrlIwN/RiQYoBPJcpz9YES1ENHaXwgHndPR aOWwE9H7hl24LRxqeZy9LCF2HajmTNh7KR9V3YYnrvPLlaGGI+qUJcw12uJXiM2szn9XFoYqVrfNw cspNYT+t3DpDqAwbaHupbHczcnsp5hAPShAe8R25KD1FVxX6j9iYpGqSSPfcQPce/1HpeWi7sM8ik oua1JJIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1viA7H-00000003jVN-0DIy; Tue, 20 Jan 2026 11:41:47 +0000 Received: from mail-dy1-x132f.google.com ([2607:f8b0:4864:20::132f]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1viA7E-00000003jU8-1hkP for linux-arm-kernel@lists.infradead.org; Tue, 20 Jan 2026 11:41:46 +0000 Received: by mail-dy1-x132f.google.com with SMTP id 5a478bee46e88-2b6b0500e06so5416388eec.1 for ; Tue, 20 Jan 2026 03:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768909303; x=1769514103; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VjkNqktI4MZMt6SSfHT5UbzSxH8+GJApfRaBdqEuizY=; b=K304N57KHAwAA95nanJWLfeu67Lu3UEUIXwQUcqaXbR0VsK874buSw7AJq4pE+clvj N2trdzhtjP+MovDAwdYxXUNZSy0fuYRTUf61g0d306q99UT9XciaTRlS6uV1yeR3/7pH +ciH3j72Og1g845GobKSLOQg6BDfY8Z+kVRbCdS8+Z6dm31u3Lf8DWErDviCrj1RnVqq dL16RaJgUTHcbM92U9mgJlEoxytDemzvX28cKOcZPcbUD43xkqiZ5KatMysg3f3XNjTw xcOJmYJ9ZpmytmnUGjooT82uHBX1VvB7K5JyYOTzTosO/qdqcwz461bIbV98L6itagd5 5yVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768909303; x=1769514103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VjkNqktI4MZMt6SSfHT5UbzSxH8+GJApfRaBdqEuizY=; b=WUzzOm2mgLD57bcV9/9KPCfWM0ccCIZKsvOw1b0dOzRiDqiNpTrXpdGwJMOl0Roo+8 OpMFotcdNJQfpN2aazN+CCah5mXlBvJpZTlx6qet3/oo1qQLSlUWgzrQ3BZCWe7/NKU7 KZGmMxmeYM3p3JnMf3G6NarCTor1CB3Ju/r2b/KCfMt8f4QU5F0jWJzMXgqqZ+gda5Rl Fu8mujCviXjYabVL/3hn4Mizjgj0+680crhtbMN4eGVPUBenb+ya+CBN0K+nq61YBg+Y 7h7ROJR132pR5p9ETKgch3FZi6c/qikn8yLgOEe6vdfHgZWyyzDWnU/mqIx2wxUwlQEv OCcA== X-Forwarded-Encrypted: i=1; AJvYcCXqW+cK2osIpF/r8ItLVsj8qrUgGlF5bOzGS1EmU9IsIjyFrn+7vMuy8R9VrOAKv9T01zQB3MxUomRm/yn7vWNC@lists.infradead.org X-Gm-Message-State: AOJu0YwIzF6IDP4BEO7eG/thrdJys5L6H45Yiz0pDebgjEUaaR+XRguY mCThMQBqEoNZ7TnUvU/OY26bHzPKqr1xzSX51/xwRpx2nJkiJbJDF2G7 X-Gm-Gg: AZuq6aIY7XHQthPB8V79x7u1SoCvFiN3HUoi0VOYCVwviL3X0UIecBmRA+ZIsL4zMsA lNzWq+zRssnMun1sBpDZenyIHZmP8jmqOhhLKlrteAvyAW+POiWBqj6LQkGDAOkEZg1Zrc1hjzJ /6Z6JDw+55fytaFlbIo4vTzWpoEtFYxNahj7HUiXDEvSzy3UWCuxGuQTkI7bfjqtCsWFMh+XBwf MMTb5a8wg/BkWxKs0iKDLBscnIGnbSSIFQfe70dv2L2tTMwaj/1g2ibo2FZ0zwTm6e9DHmFwydi 1Q4Novi+2/Ge0XXWLGsooxl3CF9uo+KWjhwckhBVqyhnuDyvziWhVnVhebe+vVa3iZl6bytHUhH Au3mBsYvVwnjsgB+n9JOx+mq/Q+D4drjIDUtUqkkC0RrhdYSHrK7gwDd403G9BvqIOldtEywgze MotFGGDdcs/g== X-Received: by 2002:a05:7301:3d0d:b0:2ab:ca55:89c6 with SMTP id 5a478bee46e88-2b6b412b2cemr9952612eec.41.1768909302992; Tue, 20 Jan 2026 03:41:42 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6c2de1f29sm14737037eec.15.2026.01.20.03.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 03:41:42 -0800 (PST) Date: Tue, 20 Jan 2026 19:41:32 +0800 From: Inochi Amaoto To: Yao Zi , Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Russell King (Oracle)" , Yanteng Si , Yao Zi , Vladimir Oltean , Lad Prabhakar , Choong Yong Liang , Maxime Chevallier , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260120043609.910302-1-inochiama@gmail.com> <20260120043609.910302-4-inochiama@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260120_034144_454356_1511A854 X-CRM114-Status: GOOD ( 34.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 20, 2026 at 11:13:50AM +0000, Yao Zi wrote: > On Tue, Jan 20, 2026 at 12:36:08PM +0800, Inochi Amaoto wrote: > > Adds Spacemit dwmac driver support on the Spacemit K3 SoC. > > > > Signed-off-by: Inochi Amaoto > > --- > > drivers/net/ethernet/stmicro/stmmac/Kconfig | 12 + > > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > > .../ethernet/stmicro/stmmac/dwmac-spacemit.c | 224 ++++++++++++++++++ > > 3 files changed, 237 insertions(+) > > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > > ... > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > > new file mode 100644 > > index 000000000000..72744e60d02a > > --- /dev/null > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > > @@ -0,0 +1,224 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Spacemit DWMAC platform driver > > + * > > + * Copyright (C) 2026 Inochi Amaoto > > + */ > > + > > +#include > > +#include > > +#include > > These are the only two headers listed out-of-order. Is this intended? > I will fix this. > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > ... > > > +static int spacemit_dwmac_detected_delay_value(unsigned int delay, > > + unsigned int *config) > > +{ > > + int i; > > + int code, best_code = 0; > > + unsigned int best_delay = 0; > > + unsigned int best_config = 0; > > + > > + if (delay == 0) > > + return 0; > > + > > + for (i = 0; i < ARRAY_SIZE(k3_delay_step_10x); i++) { > > + unsigned int step = k3_delay_step_10x[i]; > > + > > + for (code = 1; code <= MAX_DLINE_DELAY_CODE; code++) { > > + /* > > + * Note K3 require a specific factor for calculate > > + * the delay, in this scenario it is 0.9. So the > > + * formula is code * step / 10 * 0.9 > > + */ > > + unsigned int tmp = code * step * 9 / 10 / 10; > > + > > + if (abs(tmp - delay) < abs(best_delay - delay)) { > > + best_code = code; > > + best_delay = tmp; > > + best_config = i; > > + } > > Is the inner loop really necessary? Could it be replaced by > > this_code = DIV_ROUND_CLOSEST(delay * 10 * 10, step * 9); > this_delay = this_code * step * 9 / 10 / 10; > > Then comparing abs(this_delay - delay) and abs(best_delay - delay)? > This is a good idea, thanks. > > + } > > + } > > + > > + *config = best_config; > > + > > + return best_code; > > +} > > ... > > > +static int spacemit_dwmac_update_ifconfig(struct plat_stmmacenet_data *plat_dat, > > + struct stmmac_resources *stmmac_res, > > + struct regmap *apmu, > > + unsigned int ctrl_offset) > > +{ > > + unsigned int mask = PHY_INTF_MII | PHY_INTF_RGMII | WAKE_IRQ_EN; > > + unsigned int val = 0; > > + > > + switch (plat_dat->phy_interface) { > > + case PHY_INTERFACE_MODE_MII: > > + val |= PHY_INTF_MII; > > + break; > > The OR operation seems unnecessary and could be replaced with an > assignment. Same for PHY_INTERFACE_MODE_RGMII's case. > That's tree, an assignment is better than the OR operation, I will change this in the next version. > > + > > + case PHY_INTERFACE_MODE_RMII: > > + break; > > + > > + case PHY_INTERFACE_MODE_RGMII: > > + case PHY_INTERFACE_MODE_RGMII_ID: > > + case PHY_INTERFACE_MODE_RGMII_RXID: > > + case PHY_INTERFACE_MODE_RGMII_TXID: > > + val |= PHY_INTF_RGMII; > > + break; > > + > > + default: > > + return -EOPNOTSUPP; > > + } > > ... > > > +static int spacemit_dwmac_probe(struct platform_device *pdev) > > +{ > > ... > > > + of_property_read_u32(pdev->dev.of_node, "tx-internal-delay-ps", &tx_delay); > > + of_property_read_u32(pdev->dev.of_node, "rx-internal-delay-ps", &rx_delay); > > According to of.h, of_property_read_u32, which in turn calls > of_property_read_u32_array, could fail with -ENODATA if there's no value > associated with the property. Should the case be handled? > > Regards, > Yao Zi