From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Haibo Chen <haibo.chen@nxp.com>, Han Xu <han.xu@nxp.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
Date: Thu, 15 Jan 2026 10:15:40 -0500 [thread overview]
Message-ID: <aWkEnEJRj01JSZj5@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260115-imaginary-banana-beaver-7b45ea@quoll>
On Thu, Jan 15, 2026 at 10:39:20AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> > oneOf:
> > - enum:
> > - nxp,imx94-xspi
> > + - items:
> > + - enum:
> > + - nxp,imx952-xspi
> > + - const: nxp,imx94-xspi
>
> You never checked your DTS and broke all existing users. And existing
> tools would clearly tell you that if you tried.
Krzysztof:
what's wrong?
I have not find any warnings under arch/arm64/boot/dts/freescale by
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y dtbs
Frank
>
> Use tools instead of reviewers. Reviewers time is more important, so if
> you just disregard it I find it quite disrespectful.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-01-15 15:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 6:49 [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Haibo Chen
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
2026-01-15 9:39 ` Krzysztof Kozlowski
2026-01-15 11:51 ` Bough Chen
2026-01-15 15:15 ` Frank Li [this message]
2026-01-15 20:55 ` Krzysztof Kozlowski
2026-01-15 20:55 ` Krzysztof Kozlowski
2026-01-15 21:07 ` Frank Li
2026-02-08 10:24 ` Krzysztof Kozlowski
2026-01-14 6:49 ` [PATCH 2/3] arm64: dts: imx952: Add xspi node Haibo Chen
2026-01-14 6:49 ` [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash Haibo Chen
2026-01-14 16:43 ` Han Xu
2026-02-24 15:05 ` Frank Li
2026-01-20 17:58 ` (subset) [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWkEnEJRj01JSZj5@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox