public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Francesco Valla <francesco@valla.it>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx91-11x11-frdm: fix CAN transceiver gpio
Date: Fri, 16 Jan 2026 14:03:57 +0100	[thread overview]
Message-ID: <aWo3PZni1Pb9T6FI@bywater> (raw)
In-Reply-To: <CAEnQRZD2CvQLO2hBDbX2H8PeeNkzQmLoK6jzeF6HKw8HHa8ukg@mail.gmail.com>

Hi Daniel,

On Fri, Jan 16, 2026 at 01:40:11PM +0200, Daniel Baluta wrote:
> On Thu, Jan 15, 2026 at 8:25 PM Francesco Valla <francesco@valla.it> wrote:
> >
> > According to the HW schematic, the CAN transceiver does not have an
> > enable pin but a silent one. Fix the GPIO property name and polarity.
> >
> > Fixes: b4bf5e55899e ("arm64: dts: freescale: Add FRDM-IMX91 basic support")
> 
> Just for clarification GPIO 23 is connected to a pin named CAN_STBY.
> So I wonder if it isn't
> better to use standby-gpios instead of silent-gpios?
> 
> I am looking at FRDM-IMX91 schematic file SPF-94610_A1.pdf.
> 
> But on the other hand we have
> 
> static const struct can_transceiver_data tja1051_drvdata = {
> »       .flags = CAN_TRANSCEIVER_SILENT_PRESENT | CAN_TRANSCEIVER_EN_PRESENT,
> };
> 
> So TJA1051 is not advertised as having a stdby flag.

Regardless of the name of the net, the functionality of a standby vs a
silent pin is very different. In this case, since the TJA1051 is
including a silent pin (pin S in he datasheet [0]), I think it's better
to declare it that way.

In case someone adds the support for a phy-oriented listen-only mode
(which is something I am thinking), this wouldn't break the integartion.

Regards,
Francesco

[0] https://www.nxp.com/docs/en/data-sheet/TJA1051.pdf



  reply	other threads:[~2026-01-16 13:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 17:41 [PATCH] arm64: dts: imx91-11x11-frdm: fix CAN transceiver gpio Francesco Valla
2026-01-16 11:40 ` Daniel Baluta
2026-01-16 13:03   ` Francesco Valla [this message]
2026-01-16 13:15     ` Daniel Baluta
2026-01-18  6:32 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWo3PZni1Pb9T6FI@bywater \
    --to=francesco@valla.it \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox