* [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable()
@ 2026-01-13 22:12 Peng Fan (OSS)
2026-01-14 6:38 ` Marco Felsch
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2026-01-13 22:12 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marco Felsch
Cc: imx, linux-arm-kernel, linux-kernel, Peng Fan, kernel test robot,
Dan Carpenter
From: Peng Fan <peng.fan@nxp.com>
imx8m_soc_prepare() directly returns the result of clk_prepare_enable(),
which skips proper cleanup if the clock enable fails. Check the return
value of clk_prepare_enable() and release resources if failure.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202601111406.ZVV3YaiU-lkp@intel.com/
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/soc/imx/soc-imx8m.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 04a1b60f2f2b52cc374714f9a1205496c1762f39..8e2322999f0996d2723768469c6893b0ea22eb9d 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -148,7 +148,11 @@ static int imx8m_soc_prepare(struct platform_device *pdev, const char *ocotp_com
goto err_clk;
}
- return clk_prepare_enable(drvdata->clk);
+ ret = clk_prepare_enable(drvdata->clk);
+ if (ret)
+ goto err_clk;
+
+ return 0;
err_clk:
iounmap(drvdata->ocotp_base);
---
base-commit: 0f853ca2a798ead9d24d39cad99b0966815c582a
change-id: 20260114-fix-soc-imx8m-52bec6e4c7d6
Best regards,
--
Peng Fan <peng.fan@nxp.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable()
2026-01-13 22:12 [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable() Peng Fan (OSS)
@ 2026-01-14 6:38 ` Marco Felsch
2026-01-14 8:07 ` Daniel Baluta
2026-01-18 2:34 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Marco Felsch @ 2026-01-14 6:38 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
imx, linux-arm-kernel, linux-kernel, Peng Fan, kernel test robot,
Dan Carpenter
On 26-01-14, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> imx8m_soc_prepare() directly returns the result of clk_prepare_enable(),
> which skips proper cleanup if the clock enable fails. Check the return
> value of clk_prepare_enable() and release resources if failure.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202601111406.ZVV3YaiU-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable()
2026-01-13 22:12 [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable() Peng Fan (OSS)
2026-01-14 6:38 ` Marco Felsch
@ 2026-01-14 8:07 ` Daniel Baluta
2026-01-18 2:34 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Baluta @ 2026-01-14 8:07 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marco Felsch, imx, linux-arm-kernel, linux-kernel, Peng Fan,
kernel test robot, Dan Carpenter
On Wed, Jan 14, 2026 at 12:13 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> imx8m_soc_prepare() directly returns the result of clk_prepare_enable(),
> which skips proper cleanup if the clock enable fails. Check the return
> value of clk_prepare_enable() and release resources if failure.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202601111406.ZVV3YaiU-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable()
2026-01-13 22:12 [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable() Peng Fan (OSS)
2026-01-14 6:38 ` Marco Felsch
2026-01-14 8:07 ` Daniel Baluta
@ 2026-01-18 2:34 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2026-01-18 2:34 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Marco Felsch, imx, linux-arm-kernel, linux-kernel, Peng Fan,
kernel test robot, Dan Carpenter
On Wed, Jan 14, 2026 at 06:12:41AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> imx8m_soc_prepare() directly returns the result of clk_prepare_enable(),
> which skips proper cleanup if the clock enable fails. Check the return
> value of clk_prepare_enable() and release resources if failure.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202601111406.ZVV3YaiU-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-18 2:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-13 22:12 [PATCH] soc: imx8m: Fix error handling for clk_prepare_enable() Peng Fan (OSS)
2026-01-14 6:38 ` Marco Felsch
2026-01-14 8:07 ` Daniel Baluta
2026-01-18 2:34 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox