From: Mark Brown <broonie@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/arm64: Use syscall() macro over nolibc my_syscall()
Date: Sun, 18 Jan 2026 15:16:36 +0000 [thread overview]
Message-ID: <aWz5VDoGPiOrfsTN@sirena.co.uk> (raw)
In-Reply-To: <20260117-nolibc-mysyscall-arm64-v1-1-f70266a3db15@weissschuh.net>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Sat, Jan 17, 2026 at 01:10:51PM +0100, Thomas Weißschuh wrote:
> The my_syscall*() macros are internal implementation details of nolibc.
> Nolibc also provides the regular syscall(2), which is also a macro
> and directly expands to the correct my_syscall().
>
> Use syscall() instead.
>
> As a side-effect this fixes some return value checks, as my_syscall()
> returns the raw value as set by the kernel and does not set errno.
Acked-by: Mark Brown <broonie@kernel.org>
Looking at the history the nolibc syscall() was added after we started
doing this in the arm64 selftests, it was 2023 while the tpidr2 test
is from 2022.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-01-18 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-17 12:10 [PATCH] kselftest/arm64: Use syscall() macro over nolibc my_syscall() Thomas Weißschuh
2026-01-18 15:16 ` Mark Brown [this message]
2026-01-22 16:59 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWz5VDoGPiOrfsTN@sirena.co.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox