From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] i2c: xiic: switch to generic device property accessors
Date: Fri, 23 Jan 2026 10:33:37 +0200 [thread overview]
Message-ID: <aXMyYbDVZjS4aFA2@smile.fi.intel.com> (raw)
In-Reply-To: <20260123-i2c-xiic-v3-4-eb7cd4254dfb@nexthop.ai>
On Fri, Jan 23, 2026 at 08:02:47AM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Use generic device property accessors.
...
> + data = device_get_match_data(&pdev->dev);
Should use 'dev'.
> + if (data)
> i2c->quirks = data->quirks;
...
> + device_set_node(&i2c->adap.dev, dev_fwnode(&pdev->dev));
Ditto.
> + ret = device_property_read_u32(&pdev->dev, "clock-frequency",
> + &i2c->i2c_clk);
Ditto and it will be a single line, I think.
ret = device_property_read_u32(dev, "clock-frequency", &i2c->i2c_clk);
(yep, only 78 characters).
...
> - of_property_read_bool(pdev->dev.of_node, "single-master");
> + device_property_read_bool(&pdev->dev, "single-master");
Use 'dev'.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-23 8:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 8:02 [PATCH v3 0/5] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-23 8:02 ` [PATCH v3 1/5] i2c: xiic: make the clock optional Abdurrahman Hussain via B4 Relay
2026-01-23 8:29 ` Andy Shevchenko
2026-01-23 19:20 ` Andrew Lunn
2026-01-23 19:56 ` Abdurrahman Hussain
2026-01-23 8:02 ` [PATCH v3 2/5] i2c: xiic: switch to managed version of mutex_init Abdurrahman Hussain via B4 Relay
2026-01-23 8:30 ` Andy Shevchenko
2026-01-23 19:22 ` Andrew Lunn
2026-01-23 20:20 ` Abdurrahman Hussain
2026-01-23 21:36 ` Andrew Lunn
2026-01-23 22:25 ` Abdurrahman Hussain
2026-01-23 8:02 ` [PATCH v3 3/5] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-01-23 19:23 ` Andrew Lunn
2026-01-23 8:02 ` [PATCH v3 4/5] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-23 8:33 ` Andy Shevchenko [this message]
2026-01-23 8:02 ` [PATCH v3 5/5] i2c: xiic: minor cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-01-23 8:28 ` Andy Shevchenko
2026-01-23 8:37 ` Andy Shevchenko
2026-01-23 8:31 ` [PATCH v3 0/5] i2c: xiic: use generic device property accessors Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXMyYbDVZjS4aFA2@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox