From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/5] i2c: xiic: use generic device property accessors
Date: Fri, 23 Jan 2026 18:56:55 +0200 [thread overview]
Message-ID: <aXOoV-rbEGRur_UI@smile.fi.intel.com> (raw)
In-Reply-To: <20260123-i2c-xiic-v4-0-4a3eba3510ce@nexthop.ai>
On Fri, Jan 23, 2026 at 04:34:13PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Switch to generic device property accessors.
>
> Switch to managed devm_ functions to simplify error handling.
>
> Make the clock optional since the driver is designed to operate without
> explicit configuration in firmware thus making it useful on platforms
> where clock is not or cannot be provided.
...
> Changes in v4:
> - Reorder the cosmetic patch to be the first in the series.
No. that's not what I meant. I meant that the line that adds a temporary
variable should be moved from the last patch to the first one. The order
of the _patches_ was fine, now it's broken again.
Take your time and try to play with the patches locally to see my point.
Next week v5 would be nice to have that addresses my point.
> - Amend the mutex_init patch to also switch to the managed pm_runtime_
> variant.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-01-23 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 16:34 [PATCH v4 0/5] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-23 16:34 ` [PATCH v4 1/5] i2c: xiic: minor cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-01-23 16:34 ` [PATCH v4 2/5] i2c: xiic: make the clock optional Abdurrahman Hussain via B4 Relay
2026-01-23 16:34 ` [PATCH v4 3/5] i2c: xiic: switch to devm_ managed apis to simplify the error code paths Abdurrahman Hussain via B4 Relay
2026-01-23 16:34 ` [PATCH v4 4/5] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-01-23 16:34 ` [PATCH v4 5/5] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-23 16:56 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXOoV-rbEGRur_UI@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox