From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Alexey Charkov <alchark@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Heiko Stuebner <heiko@sntech.de>,
Sjoerd Simons <sjoerd.simons@collabora.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/10] ASoC: rockchip: spdif: Use dev_err_probe
Date: Tue, 27 Jan 2026 23:12:03 +0100 [thread overview]
Message-ID: <aXk31GTmK_5wUQ9t@venus> (raw)
In-Reply-To: <CABjd4YxVQfp=ZuovBhAzqX9pDBnBmntQoxkr5vXnToPc3pRARw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
Hello Alexey,
On Tue, Jan 27, 2026 at 09:31:18PM +0400, Alexey Charkov wrote:
> > ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
> > - if (ret) {
> > - dev_err(&pdev->dev, "Could not register PCM\n");
> > - return ret;
> > - }
> > + if (ret)
> > + dev_err_probe(&pdev->dev, ret, "Could not register PCM\n");
>
> Shouldn't this one return the error code, instead of falling through
> to 'return 0'?
Yes, good catch. I will fix that up in v2.
Thanks,
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-01-27 22:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 16:08 [PATCH 00/10] ASoC: rockchip: spdif: Cleanups and port features from Rockchip's BSP kernel Sebastian Reichel
2026-01-27 16:08 ` [PATCH 01/10] ASoC: rockchip: spdif: Use device_get_match_data() Sebastian Reichel
2026-01-27 16:08 ` [PATCH 02/10] ASoC: rockchip: spdif: Move DT compatible table Sebastian Reichel
2026-01-27 16:08 ` [PATCH 03/10] ASoC: rockchip: spdif: Fully convert to device managed resources Sebastian Reichel
2026-01-27 16:08 ` [PATCH 04/10] ASoC: rockchip: spdif: Use dev_err_probe Sebastian Reichel
2026-01-27 17:31 ` Alexey Charkov
2026-01-27 22:12 ` Sebastian Reichel [this message]
2026-01-27 16:08 ` [PATCH 05/10] ASoC: rockchip: spdif: Improve sample rate support Sebastian Reichel
2026-01-27 16:28 ` Mark Brown
2026-01-27 16:59 ` Sebastian Reichel
2026-01-27 16:08 ` [PATCH 06/10] ASoC: rockchip: spdif: Swap PCM and DAI component registration order Sebastian Reichel
2026-01-27 16:08 ` [PATCH 07/10] ASoC: rockchip: spdif: Add support for set mclk rate Sebastian Reichel
2026-01-27 16:08 ` [PATCH 08/10] ASoC: rockchip: spdif: Add support for format S32_LE Sebastian Reichel
2026-01-27 16:08 ` [PATCH 09/10] ASoC: rockchip: spdif: Fill IEC958 CS info per params Sebastian Reichel
2026-01-27 16:08 ` [PATCH 10/10] ASoC: rockchip: spdif: Convert to FIELD_PREP Sebastian Reichel
2026-01-28 3:54 ` kernel test robot
2026-01-28 10:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXk31GTmK_5wUQ9t@venus \
--to=sebastian.reichel@collabora.com \
--cc=alchark@gmail.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sjoerd.simons@collabora.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox