From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
info@mocean-labs.com, linux-arm-kernel@lists.infradead.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 3/7] i2c: xiic: switch to devres managed APIs
Date: Tue, 27 Jan 2026 23:24:52 +0200 [thread overview]
Message-ID: <aXktJPe2YMkWEqEI@smile.fi.intel.com> (raw)
In-Reply-To: <20260127-i2c-xiic-v6-3-e82e2f6f657c@nexthop.ai>
On Tue, Jan 27, 2026 at 09:03:57PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Simplify the error code paths by switching to devres managed helper
> functions.
...
> + if (ret)
> + return dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n");
I told you to use slightly different parameter. Please, read reviews carefully.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-27 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 21:03 [PATCH v6 0/7] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-27 21:03 ` [PATCH v6 1/7] dt-bindings: i2c: xiic: make clocks optional Abdurrahman Hussain via B4 Relay
2026-01-28 10:37 ` Krzysztof Kozlowski
2026-01-28 11:21 ` Michal Simek
2026-01-28 14:34 ` Andrew Lunn
2026-01-28 14:38 ` Michal Simek
2026-01-28 14:40 ` Conor Dooley
2026-01-28 14:45 ` Andy Shevchenko
2026-01-28 15:00 ` Michal Simek
2026-01-28 15:43 ` Andy Shevchenko
2026-01-28 16:40 ` Abdurrahman Hussain
2026-01-29 16:14 ` Rob Herring
2026-01-30 5:33 ` Andy Shevchenko
2026-01-27 21:03 ` [PATCH v6 2/7] i2c: xiic: make the clock optional Abdurrahman Hussain via B4 Relay
2026-01-27 21:03 ` [PATCH v6 3/7] i2c: xiic: switch to devres managed APIs Abdurrahman Hussain via B4 Relay
2026-01-27 21:24 ` Andy Shevchenko [this message]
2026-01-27 21:03 ` [PATCH v6 4/7] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-01-27 21:03 ` [PATCH v6 5/7] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-27 21:04 ` [PATCH v6 6/7] i2c: xiic: cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-01-27 21:04 ` [PATCH v6 7/7] i2c xiic: cosmetic: use resource format specifier in debug log Abdurrahman Hussain via B4 Relay
2026-01-27 21:23 ` [PATCH v6 0/7] i2c: xiic: use generic device property accessors Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXktJPe2YMkWEqEI@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=info@mocean-labs.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox