Re: [PATCH v11 7/7] i2c: xiic: skip input clock setup on non-OF systems

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Fri, Feb 13, 2026 at 12:15:22AM +0000, Abdurrahman Hussain via B4 Relay wrote:

> Currently Linux does not implement ACPI ClockInput() resource to describe
> clocks, unlike DT. However the xiic driver is happy if something
> magically enables the clock before the driver probes, and does not
> turn it off again. The clock should always be considered optional for
> ACPI.

...

> +	if (is_of_node(dev_fwnode(dev))) {

You would want to have

	struct fwnode_handle *fwnode = dev_fwnode(dev);

at the top now, as here is the second time it's being used.
Perhaps it makes sense to do in the patch that switches to
agnostic device property interface.

In any case, wait a few days before doing any new version, unless Andi asks
you for it. The first 6 patches may be already applied as is, in such a case
the above comment can be addressed here (with a little churn of touching
a line that has been already modified in the series).

> +		i2c->clk = devm_clk_get_enabled(dev, NULL);
> +		if (IS_ERR(i2c->clk))
> +			return dev_err_probe(dev, PTR_ERR(i2c->clk),
> +					"failed to enable input clock.\n");
> +	}

-- 
With Best Regards,
Andy Shevchenko