From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FA8EE7DEF2 for ; Mon, 2 Feb 2026 14:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r9CT2H+uz3ERa2jBFKO6fCNSKr0uIo64StJcK6hJkgg=; b=wHYyWsbhgyLJy1AdqTwUZl4vU3 g9N1O9o/AtfycFYY4/QWck+Alyi2b7LBBjxZZlTQJTdDyF1SArFVZnyQatPLRYvXPBEgQweCNaHoi qK6nmwhFZI2VRJ6/mvaI3ze8yRgT/YiNeFIwZnrakAhkIvNLh3TWVeKRUIbHqNdYZf5uB8t33Naxq zyqa/L71IgoyweqNj4moczp7RO4H26qQmjl+w1vxiHcDmnIydyuK2BatXMryrK+KqIGM6Oj3dT1Ri 4CVZkdjvHWUYZ/BmsGj0h88w+YUMqVJGE1ZSpRDRmTI+dbUqqSAURsCxgYpXU4S4Cnlz9Ims9XhwZ 6zfEygYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vmvLT-000000058Vu-3oGZ; Mon, 02 Feb 2026 14:56:07 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vmvLR-000000058Uy-2Ip4 for linux-arm-kernel@lists.infradead.org; Mon, 02 Feb 2026 14:56:06 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 521BF4358D; Mon, 2 Feb 2026 14:56:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30355C116C6; Mon, 2 Feb 2026 14:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770044163; bh=/EEdBOPFOkFatjqAoJx76sQaNiSIsTwcgFVOLGrY1HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SJKoBUVBwIEdP0ez+/+iTLxXI9dg2/8/e4Bi+0zzGtm/ZM3a5rwzNfaDvlJHvIjZd T7pS1A93ZyE5Wpc9Pwx3A0B+cgdd+iqB6TgZLF3pD2zxmmb0HxGqI6H2JDOPpcKB0C CeeNhyKCh5wcM3TQQH3jOvc5mCS+GW12lXy9IP2F+L9uyue/G8URz1KY2CWoSEnZv3 pA9NE+O5KpZ7XI0nlBPVipwVgrYa02pp1G/hdlNs0VIB2B5TylOWqkak+yGMKfLlM3 JgTwJHxmBLDuS+7ooKAjibaPjdn5rpxa6pC1zIDFMUMgU5Jn8/R6UTKXG7hdVStaV1 Aag9mpgttmYyQ== Date: Mon, 2 Feb 2026 14:55:58 +0000 From: Will Deacon To: Jinjiang Tu Cc: akpm@linux-foundation.org, david@kernel.org, catalin.marinas@arm.com, zengheng4@huawei.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, wangkefeng.wang@huawei.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v3] arm64: mm: fix pass user prot to ioremap_prot in generic_access_phys Message-ID: References: <20260130073807.99474-1-tujinjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260130073807.99474-1-tujinjiang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260202_065605_625681_5D3A6E98 X-CRM114-Status: GOOD ( 23.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 30, 2026 at 03:38:07PM +0800, Jinjiang Tu wrote: > Here is a syzkaller error log: > [0000000020ffc000] pgd=080000010598d403, p4d=080000010598d403, pud=0800000125ddb403, > pmd=080000007833c403, pte=01608000007fcfcf > Unable to handle kernel read from unreadable memory at virtual address ffff80008ea89000 > KASAN: probably user-memory-access in range [0x0000000475448000-0x0000000475448007] > Mem abort info: > ESR = 0x000000009600000f > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x0f: level 3 permission fault > Data abort info: > ISV = 0, ISS = 0x0000000f, ISS2 = 0x00000000 > CM = 0, WnR = 0, TnD = 0, TagAccess = 0 > GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000001244aa000 > [ffff80008ea89000] pgd=100000013ffff403, p4d=100000013ffff403, pud=100000013fffe403, > pmd=100000010a453403, pte=01608000007fcfcf > Internal error: Oops: 000000009600000f [#1] SMP > Modules linked in: team > CPU: 1 PID: 10840 Comm: syz.9.83 Kdump: loaded Tainted: G > Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015 > pstate: 20400005 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : __memcpy_fromio+0x80/0xf8 > lr : generic_access_phys+0x20c/0x2b8 > sp : ffff8000a0507960 > x29: ffff8000a0507960 x28: 1ffff000140a0f44 x27: ffff00003833cfe0 > x26: 0000000000000000 x25: 0000000000001000 x24: 0010000000000001 > x23: ffff80008ea89000 x22: ffff00004ea63000 x21: 0000000000001000 > x20: ffff80008ea89000 x19: ffff00004ea62000 x18: 0000000000000000 > x17: 0000000000000000 x16: 0000000000000000 x15: ffff8000806f1e3c > x14: ffff8000806f1d44 x13: 0000000041b58ab3 x12: ffff7000140a0f23 > x11: 1ffff000140a0f22 x10: ffff7000140a0f22 x9 : ffff800080579d24 > x8 : 0000000000000004 x7 : 0000000000000003 x6 : 0000000000000001 > x5 : ffff8000a0507910 x4 : ffff7000140a0f22 x3 : dfff800000000000 > x2 : 0000000000001000 x1 : ffff80008ea89000 x0 : ffff00004ea62000 > Call trace: > __memcpy_fromio+0x80/0xf8 > generic_access_phys+0x20c/0x2b8 > __access_remote_vm+0x46c/0x5b8 > access_remote_vm+0x18/0x30 > environ_read+0x238/0x3e8 > vfs_read+0xe4/0x2b0 > ksys_read+0xcc/0x178 > __arm64_sys_read+0x4c/0x68 > invoke_syscall+0x68/0x1a0 > el0_svc_common.constprop.0+0x11c/0x150 > do_el0_svc+0x38/0x50 > el0_svc+0x50/0x258 > el0t_64_sync_handler+0xc0/0xc8 > el0t_64_sync+0x1a4/0x1a8 > Code: 91002339 aa1403f7 8b190276 d503201f (f94002f8) > > The local syzkaller first maps I/O address from /dev/mem to userspace, > overiding the stack vma with MAP_FIXED flag. As a result, when reading > /proc/$pid/environ, generic_access_phys() is called to access the region, > which triggers a PAN permission-check fault and causes a kernel access > fault. > > The root cause is that generic_access_phys() passes a user pte to > ioremap_prot(), the user pte sets PTE_USER and PTE_NG bits. Consequently, > any subsequent kernel-mode access to the remapped address raises a fault. > > To fix it, define arch_mk_kernel_prot() to convert user prot to kernel > prot for arm64, and call arch_mk_kernel_prot() in generic_access_phys(), > so that a user prot is passed to ioremap_prot(). > > Fixes: 893dea9ccd08 ("arm64: Add HAVE_IOREMAP_PROT support") > Signed-off-by: Zeng Heng > Signed-off-by: Jinjiang Tu > --- > Changes in v3: > * arch_mk_kernel_prot() always grant read/write permissions. > > arch/arm64/include/asm/io.h | 8 ++++++++ > mm/memory.c | 12 +++++++++++- > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index 83e03abbb2ca..fe3040d59119 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -267,6 +267,14 @@ int arm64_ioremap_prot_hook_register(const ioremap_prot_hook_t hook); > > #define ioremap_prot ioremap_prot > > +#define arch_mk_kernel_prot arch_mk_kernel_prot > +static inline pgprot_t arch_mk_kernel_prot(pgprot_t user_prot) > +{ > + ptdesc_t mem_type = pgprot_val(user_prot) & PTE_ATTRINDX_MASK; > + > + return __pgprot_modify(PAGE_KERNEL, PTE_ATTRINDX_MASK, mem_type); > +} Do we really need another arch helper here? It looks to me like generic_access_phys() is the only caller of ioremap_prot() outside of arch/, so why not just handle the user_prot in there on arm64? You could rename the existing ioremap_prot() function in arch/arm64/mm/ioremap.c to e.g. __ioremap_prot(), switch over the callers in arch/arm64 and then add ioremap_prot() to wrap that with your pgprot modification above. Will