From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29511E8784C for ; Tue, 3 Feb 2026 17:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8+rZdHUALqDXCYWomEbTBBbdF709hbUaxOu7TxGSuck=; b=mxjTWndxgmHrGx+N9EFeB5bT+Y tTrE79NL2oNZf/aICNfwa+0V+JWr4sOpU7srHAyr+ExC/JoYLBYk6ZafH3tJih+HRSJ1IOpi+pu5S pjm+jGyafrq7rpfWiq5PuFDfhn/fCnV/6oSQnf14TqM68Uf/u2JT+S7YVc10G7Av/tUnOHu8N0fr1 F3cdzvL1eot47fK7/yMA8inUANA9rVke498kuiWfETqJwo+kurPPs/1PU2z9BDkHRwJcZTOsZvqMK w71B2K2GcSIj4lNSFXS62vbWo0ouOHP79H330DHI/fa3c2NMNJ3OFDAMa2XtaWUvpCuzdf9yxec0l zUE1h50w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnKVw-0000000758C-3iBR; Tue, 03 Feb 2026 17:48:36 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnKVu-0000000757b-0fte; Tue, 03 Feb 2026 17:48:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8+rZdHUALqDXCYWomEbTBBbdF709hbUaxOu7TxGSuck=; b=mnmCHRwgVvO2uVu8vPwzL3jlaQ 9e3s28tK2RkxDDz+wudnKFLlMgf8rsID3pS07Xd03nfUi/IOgHTvc4AYPkDSWkg8uZopukn03su/q P7/A9g0eLJSwzR58O0WDaJVRC1VQO83NBE+KNK+wygGw/N/ZhhRad/Ht4honZ9Qc9Qo242neo8wKi PIQ0qpcgMEmUQKrModpz+SkByA7jDdHARbBl5sgvopqaFP2qFctC8BEN+2kBzFlRlhaAMy2i3aCeK DUf9JTguGfJOZXEOyc14Hbq6dAcCcmBDoL+92a34ygVVMMDNOsAfUug0efvdF/PZgHiZpVrcoCea1 hbGxnchg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46968) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vnKVS-000000005Pd-2TsJ; Tue, 03 Feb 2026 17:48:06 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vnKVM-000000004ZO-2y1I; Tue, 03 Feb 2026 17:48:00 +0000 Date: Tue, 3 Feb 2026 17:48:00 +0000 From: "Russell King (Oracle)" To: Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yanteng Si , Yao Zi , Lad Prabhakar , Shangjuan Wei , Maxime Chevallier , Chen-Yu Tsai , Zhi Li , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v4 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260130022705.1059214-1-inochiama@gmail.com> <20260130022705.1059214-4-inochiama@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260130022705.1059214-4-inochiama@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260203_094834_221000_7A817A2E X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 30, 2026 at 10:27:04AM +0800, Inochi Amaoto wrote: > +/* ctrl register bits */ > +#define CTRL_PHY_INTF_RGMII BIT(3) > +#define CTRL_PHY_INTF_MII BIT(4) > +#define CTRL_WAKE_IRQ_EN BIT(9) > +#define CTRL_PHY_IRQ_EN BIT(12) Thanks for updating these. > +static int spacemit_dwmac_update_ifconfig(struct plat_stmmacenet_data *plat_dat, > + struct stmmac_resources *stmmac_res, > + struct regmap *apmu, > + unsigned int ctrl_offset) > +{ > + unsigned int mask = CTRL_PHY_INTF_MII | CTRL_PHY_INTF_RGMII | CTRL_WAKE_IRQ_EN; > + unsigned int val = 0; > + > + switch (plat_dat->phy_interface) { > + case PHY_INTERFACE_MODE_MII: > + val = CTRL_PHY_INTF_MII; > + break; > + > + case PHY_INTERFACE_MODE_RMII: > + break; > + > + case PHY_INTERFACE_MODE_RGMII: > + case PHY_INTERFACE_MODE_RGMII_ID: > + case PHY_INTERFACE_MODE_RGMII_RXID: > + case PHY_INTERFACE_MODE_RGMII_TXID: > + val = CTRL_PHY_INTF_RGMII; > + break; > + > + default: > + return -EOPNOTSUPP; > + } > + > + if (stmmac_res->wol_irq >= 0) > + val |= CTRL_WAKE_IRQ_EN; > + > + return regmap_update_bits(apmu, ctrl_offset, mask, val); I would suggest that this is split into two parts - first, this is renamed and reduced to just controlling CTRL_WAKE_IRQ_EN. Next, a function hooked into plat_dat->set_phy_intf_sel which sets the CTRL_PHY_INTF_RGMII and CTRL_PHY_INTF_MII bits as appropriate. Note that this function is passed the dwmac's own phy_intf_sel value from common.h which will be PHY_INTF_SEL_GMII_MII, PHY_INTF_SEL_RGMII or PHY_INTF_SEL_RMII for you. It would also be good to have plat_dat->get_interfaces populated using phy_interface_set_rgmii(), and __set_bit(PHY_INTERFACE_MODE_MII) and __set_bit(PHY_INTERFACE_MODE_RMII) to indicate to phylink which interface modes are permissable. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!