From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0FB0E8784E for ; Tue, 3 Feb 2026 17:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cszXiMlqsjG1D2pn004woeOK5A9sc8alD/Og/RoPjPI=; b=KrBvlkES5fneLVAAvrgYa0A4J4 uh//+gmMxSoa1rx/Yhf5v8ZLBQAz/j0GMppXtO4DXfEY9GL1zrhQEAcPCLcBZ+Dt5HANg9q+GO8wz Gfj8F2jCPXo85cLH/6SsxFwsym3H4QdkpafihiJL/202oisudT4cT8g5C6fNeeajCvx3bm3LAZnyd CeK8x3zxNOJKKA8Cb983o/Nn6ueYuJ0lIQ2nH/q7DE86fnRv9BxM2JSGsjD7fXipjzLHr57SxzDlL H4lKwcsxWYyxXU9Lkzs2GdTAM03jgdLTDc5P29qcX0M36mlUsE3WLbG+OZlMaPdBOQgvchv2mD0O2 x0vnaDYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnK68-000000072Ym-24gg; Tue, 03 Feb 2026 17:21:56 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnK63-000000072Xd-20Cf for linux-arm-kernel@lists.infradead.org; Tue, 03 Feb 2026 17:21:55 +0000 Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DFB265B2; Tue, 3 Feb 2026 18:11:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770138667; bh=uv/ua4SyFTeWme9R2HrUzPu7c2XRAYMDkdaAjA1vo7k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F1TZfolXvPsvgFLxHYfMti7S+L2cWPijXVQdBHQnwiaOIz0ZQclg1PbGR7+eMH8TB Ufxc0ASBOyJWaaEzeRj1kY05nZoFfkuMM1cK9ZM6fuW2G6COVY3q57DEiZRoJwUTu4 jLGRYegmsoBlFPvHJIzYRjgI5KgWXWwkqbFU4QLU= Date: Tue, 3 Feb 2026 18:11:44 +0100 From: Jacopo Mondi To: Antoine Bouyer Cc: julien.vuillaumier@nxp.com, alexi.birlinger@nxp.com, daniel.baluta@nxp.com, peng.fan@nxp.com, frank.li@nxp.com, jacopo.mondi@ideasonboard.com, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC v1 07/11] media: Add meta formats supported by NXP neoisp driver Message-ID: References: <20260123080938.3367348-1-antoine.bouyer@nxp.com> <20260123080938.3367348-8-antoine.bouyer@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260123080938.3367348-8-antoine.bouyer@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260203_092151_657425_B772FF1B X-CRM114-Status: GOOD ( 17.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Antoine On Fri, Jan 23, 2026 at 09:09:34AM +0100, Antoine Bouyer wrote: > This patch adds new v4l2 meta formats definitions and descriptions used by > neoisp driver for the parameters and statistics buffers: > - `V4L2_META_FMT_NEO_ISP_PARAMS` used for the legacy fixed-size > parameters buffer structure. > - `V4L2_META_FMT_NEO_ISP_EXT_PARAMS` used for the generic v4l2-isp > extensible parameters structure, supporting a non-fixed-size buffer and > changeable ISP configuration blocks. > - `V4L2_META_FMT_NEO_ISP_STATS` used for the legacy fixed-size statistics > buffer structure. > - `V4L2_META_FMT_NEO_ISP_EXT_STATS` used for the generic v4l2-isp > extensible statistics structure, supporting a non-fixed-size buffer > and changeable ISP statistics blocks. Uh interesting, you have existing userspace that needs legacy formats ? > > Signed-off-by: Antoine Bouyer > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 4 ++++ > include/uapi/linux/videodev2.h | 6 ++++++ > 2 files changed, 10 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 37d33d4a363d..c797cf11be38 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1471,6 +1471,10 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_C3ISP_STATS: descr = "Amlogic C3 ISP Statistics"; break; > case V4L2_META_FMT_MALI_C55_PARAMS: descr = "ARM Mali-C55 ISP Parameters"; break; > case V4L2_META_FMT_MALI_C55_STATS: descr = "ARM Mali-C55 ISP 3A Statistics"; break; > + case V4L2_META_FMT_NEO_ISP_PARAMS: descr = "NXP Neo ISP 3A Parameters"; break; > + case V4L2_META_FMT_NEO_ISP_EXT_PARAMS: descr = "NXP Neo ISP ext 3A Parameters"; break; > + case V4L2_META_FMT_NEO_ISP_STATS: descr = "NXP Neo ISP 3A Statistics"; break; > + case V4L2_META_FMT_NEO_ISP_EXT_STATS: descr = "NXP Neo ISP ext 3A Statistics"; break; > case V4L2_PIX_FMT_NV12_8L128: descr = "NV12 (8x128 Linear)"; break; > case V4L2_PIX_FMT_NV12M_8L128: descr = "NV12M (8x128 Linear)"; break; > case V4L2_PIX_FMT_NV12_10BE_8L128: descr = "10-bit NV12 (8x128 Linear, BE)"; break; > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 848e86617d5c..5f4992452c66 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -889,6 +889,12 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_MALI_C55_PARAMS v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */ > #define V4L2_META_FMT_MALI_C55_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */ > > +/* Vendor specific - used for NXP NEOISP sub-system */ > +#define V4L2_META_FMT_NEO_ISP_PARAMS v4l2_fourcc('N', 'N', 'I', 'P') /* NXP NEOISP Parameters */ > +#define V4L2_META_FMT_NEO_ISP_EXT_PARAMS v4l2_fourcc('N', 'N', 'E', 'P') /* NXP NEOISP Ext Params */ > +#define V4L2_META_FMT_NEO_ISP_STATS v4l2_fourcc('N', 'N', 'I', 'S') /* NXP NEOISP Statistics */ > +#define V4L2_META_FMT_NEO_ISP_EXT_STATS v4l2_fourcc('N', 'N', 'E', 'S') /* NXP NEOISP Ext Stats */ > + > #ifdef __KERNEL__ > /* > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when > -- > 2.52.0 > >