From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Conor Dooley <conor@kernel.org>
Cc: Linus Walleij <linusw@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
Xianwei Zhao <xianwei.zhao@amlogic.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] pinctrl: pinconf-generic: move ..dt_node_to_map_pinmux() to amlogic-am4 driver
Date: Wed, 4 Feb 2026 16:22:42 +0200 [thread overview]
Message-ID: <aYNWMndBWxxoPABG@smile.fi.intel.com> (raw)
In-Reply-To: <20260204-crawlers-nacho-d7c9021cdb6f@spud>
On Wed, Feb 04, 2026 at 02:15:10PM +0000, Conor Dooley wrote:
> On Wed, Feb 04, 2026 at 09:05:34AM +0100, Andy Shevchenko wrote:
> > On Wed, Feb 04, 2026 at 12:34:36AM +0100, Linus Walleij wrote:
> > > On Tue, Feb 3, 2026 at 5:17 PM Conor Dooley <conor@kernel.org> wrote:
...
> > Note, please, remove extra '.' (dot) in the Subject.o
>
> fwiw, the .. was intentional cos I was truncating the pinconf_generic
> from the function since the subject was really long, not referring to
> a member of an ops struct.
Yes, and that's how we refer to the callbacks — with a single dot and parentheses:
.my_cool_cb()
Alternatively
->my_cool_cb()
but it one character longer and TBH it slightly less readable (I personally
used the latter and then switched to the former in the recent years).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-04 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 16:17 [RFC] pinctrl: pinconf-generic: move ..dt_node_to_map_pinmux() to amlogic-am4 driver Conor Dooley
2026-02-03 23:34 ` Linus Walleij
2026-02-04 8:05 ` Andy Shevchenko
2026-02-04 14:15 ` Conor Dooley
2026-02-04 14:22 ` Andy Shevchenko [this message]
2026-02-04 14:26 ` Andy Shevchenko
2026-02-04 15:50 ` Conor Dooley
2026-02-04 16:16 ` Andy Shevchenko
2026-02-04 17:08 ` Conor Dooley
2026-02-06 11:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYNWMndBWxxoPABG@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox