* [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()
@ 2026-02-05 5:09 Chen Ni
2026-02-06 3:34 ` Peng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Chen Ni @ 2026-02-05 5:09 UTC (permalink / raw)
To: andersson, mathieu.poirier, Frank.Li, s.hauer, kernel, festevam
Cc: linux-remoteproc, imx, linux-arm-kernel, linux-kernel, Chen Ni
Add error checking for regmap_attach_dev() call in
imx_rproc_mmio_detect_mode() function to ensure proper error
propagation.
Return the value of regmap_attach_dev() if it fails to prevent
proceeding with an incomplete regmap setup.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/remoteproc/imx_rproc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index f5f916d67905..0e23f519c247 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -1007,7 +1007,9 @@ static int imx_rproc_mmio_detect_mode(struct rproc *rproc)
}
priv->regmap = regmap;
- regmap_attach_dev(dev, regmap, &config);
+ ret = regmap_attach_dev(dev, regmap, &config);
+ if (ret)
+ return dev_err_probe(dev, ret, "regmap attach failed\n");
if (priv->gpr) {
ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()
2026-02-05 5:09 [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode() Chen Ni
@ 2026-02-06 3:34 ` Peng Fan
2026-02-06 3:41 ` Peng Fan
2026-02-06 16:10 ` Mathieu Poirier
0 siblings, 2 replies; 4+ messages in thread
From: Peng Fan @ 2026-02-06 3:34 UTC (permalink / raw)
To: Chen Ni, andersson@kernel.org, mathieu.poirier@linaro.org,
Frank Li, s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com
Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
> Subject: [PATCH] remoteproc: imx_rproc: Check return value of
> regmap_attach_dev() in imx_rproc_mmio_detect_mode()
>
> Add error checking for regmap_attach_dev() call in
> imx_rproc_mmio_detect_mode() function to ensure proper error
> propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/remoteproc/imx_rproc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c
> b/drivers/remoteproc/imx_rproc.c index f5f916d67905..0e23f519c247
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1007,7 +1007,9 @@ static int
> imx_rproc_mmio_detect_mode(struct rproc *rproc)
> }
>
> priv->regmap = regmap;
> - regmap_attach_dev(dev, regmap, &config);
> + ret = regmap_attach_dev(dev, regmap, &config);
> + if (ret)
> + return dev_err_probe(dev, ret, "regmap attach
> failed\n");
In the main probe, there is already dev_err_probe for
detect_mode. So I would use below style as other error
return in imx_rproc_mmio_detect_mode():
dev_err("regmap attach failed\n");
return ret;
Let's wait Mathieu's view.
Regards
Peng.
>
> if (priv->gpr) {
> ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()
2026-02-06 3:34 ` Peng Fan
@ 2026-02-06 3:41 ` Peng Fan
2026-02-06 16:10 ` Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Peng Fan @ 2026-02-06 3:41 UTC (permalink / raw)
To: Peng Fan, Chen Ni, andersson@kernel.org,
mathieu.poirier@linaro.org, Frank Li, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com
Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] remoteproc: imx_rproc: Check return value of
> regmap_attach_dev() in imx_rproc_mmio_detect_mode()
>
> > Subject: [PATCH] remoteproc: imx_rproc: Check return value of
> > regmap_attach_dev() in imx_rproc_mmio_detect_mode()
> >
> > Add error checking for regmap_attach_dev() call in
> > imx_rproc_mmio_detect_mode() function to ensure proper error
> > propagation.
> >
> > Return the value of regmap_attach_dev() if it fails to prevent
> > proceeding with an incomplete regmap setup.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > ---
> > drivers/remoteproc/imx_rproc.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index
> f5f916d67905..0e23f519c247
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -1007,7 +1007,9 @@ static int
> > imx_rproc_mmio_detect_mode(struct rproc *rproc)
> > }
> >
> > priv->regmap = regmap;
> > - regmap_attach_dev(dev, regmap, &config);
> > + ret = regmap_attach_dev(dev, regmap, &config);
> > + if (ret)
> > + return dev_err_probe(dev, ret, "regmap attach
> > failed\n");
>
>
> In the main probe, there is already dev_err_probe for detect_mode. So
> I would use below style as other error return in
> imx_rproc_mmio_detect_mode():
> dev_err("regmap attach failed\n");
> return ret;
BTW, as Philipp mentioned in [1].
dev_err_probe is unnecessary here
[1] https://lore.kernel.org/imx/fb5e20b7-b858-4099-ad8b-900c367e1b22@web.de/T/#mc9a0a582fae1c7a0e9a203691549dfa7bccfa8f8
Regards
Peng
>
> Let's wait Mathieu's view.
>
> Regards
> Peng.
>
> >
> > if (priv->gpr) {
> > ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> > --
> > 2.25.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode()
2026-02-06 3:34 ` Peng Fan
2026-02-06 3:41 ` Peng Fan
@ 2026-02-06 16:10 ` Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2026-02-06 16:10 UTC (permalink / raw)
To: Peng Fan
Cc: Chen Ni, andersson@kernel.org, Frank Li, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
linux-remoteproc@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Fri, Feb 06, 2026 at 03:34:41AM +0000, Peng Fan wrote:
> > Subject: [PATCH] remoteproc: imx_rproc: Check return value of
> > regmap_attach_dev() in imx_rproc_mmio_detect_mode()
> >
> > Add error checking for regmap_attach_dev() call in
> > imx_rproc_mmio_detect_mode() function to ensure proper error
> > propagation.
> >
> > Return the value of regmap_attach_dev() if it fails to prevent
> > proceeding with an incomplete regmap setup.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> > ---
> > drivers/remoteproc/imx_rproc.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index f5f916d67905..0e23f519c247
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -1007,7 +1007,9 @@ static int
> > imx_rproc_mmio_detect_mode(struct rproc *rproc)
> > }
> >
> > priv->regmap = regmap;
> > - regmap_attach_dev(dev, regmap, &config);
> > + ret = regmap_attach_dev(dev, regmap, &config);
> > + if (ret)
> > + return dev_err_probe(dev, ret, "regmap attach
> > failed\n");
>
>
> In the main probe, there is already dev_err_probe for
> detect_mode. So I would use below style as other error
> return in imx_rproc_mmio_detect_mode():
> dev_err("regmap attach failed\n");
> return ret;
>
> Let's wait Mathieu's view.
>
I agreew with Peng's assessment.
> Regards
> Peng.
>
> >
> > if (priv->gpr) {
> > ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> > --
> > 2.25.1
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-06 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-05 5:09 [PATCH] remoteproc: imx_rproc: Check return value of regmap_attach_dev() in imx_rproc_mmio_detect_mode() Chen Ni
2026-02-06 3:34 ` Peng Fan
2026-02-06 3:41 ` Peng Fan
2026-02-06 16:10 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox