Re: [PATCH 2/2] arm64: dts: imx93-tqma9352: improve eMMC pad configuration

[Frank Li <Frank.li@nxp.com>]

On Mon, Feb 09, 2026 at 04:50:14PM +0100, Alexander Stein wrote:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> Use DSE x4 an PullUp for CMD an DAT, DSE x4 and PullDown for CLK.
> This improves stability and detection at low temperatures under -25°C.

Nit:

Use DSE x4 an PullUp for CMD an DAT, DSE x4 and PullDown for CLK to improve
stability and detection at low temperatures under -25°C.

If you think it is okay, I can update it when apply it.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Fixes: 0b5fdfaa8e45 ("arm64: dts: freescale: imx93-tqma9352: set SION for cmd and data pad of USDHC")
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  .../boot/dts/freescale/imx93-tqma9352.dtsi    | 26 +++++++++----------
>  1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index 3a23e2eb9febe..ce34a296495c4 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -271,21 +271,21 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07	0x106
>  	/* enable SION for data and cmd pad due to ERR052021 */
>  	pinctrl_usdhc1: usdhc1grp {
>  		fsl,pins = <
> -			/* PD | FSEL 3 | DSE X5 */
> -			MX93_PAD_SD1_CLK__USDHC1_CLK		0x5be
> +			/* PD | FSEL 3 | DSE X4 */
> +			MX93_PAD_SD1_CLK__USDHC1_CLK		0x59e
>  			/* HYS | FSEL 0 | no drive */
>  			MX93_PAD_SD1_STROBE__USDHC1_STROBE	0x1000
> -			/* HYS | FSEL 3 | X5 */
> -			MX93_PAD_SD1_CMD__USDHC1_CMD		0x400011be
> -			/* HYS | FSEL 3 | X4 */
> -			MX93_PAD_SD1_DATA0__USDHC1_DATA0	0x4000119e
> -			MX93_PAD_SD1_DATA1__USDHC1_DATA1	0x4000119e
> -			MX93_PAD_SD1_DATA2__USDHC1_DATA2	0x4000119e
> -			MX93_PAD_SD1_DATA3__USDHC1_DATA3	0x4000119e
> -			MX93_PAD_SD1_DATA4__USDHC1_DATA4	0x4000119e
> -			MX93_PAD_SD1_DATA5__USDHC1_DATA5	0x4000119e
> -			MX93_PAD_SD1_DATA6__USDHC1_DATA6	0x4000119e
> -			MX93_PAD_SD1_DATA7__USDHC1_DATA7	0x4000119e
> +			/* HYS | PU | FSEL 3 | DSE X4 */
> +			MX93_PAD_SD1_CMD__USDHC1_CMD		0x4000139e
> +			/* HYS | PU | FSEL 3 | DSE X4 */
> +			MX93_PAD_SD1_DATA0__USDHC1_DATA0	0x4000139e
> +			MX93_PAD_SD1_DATA1__USDHC1_DATA1	0x4000139e
> +			MX93_PAD_SD1_DATA2__USDHC1_DATA2	0x4000139e
> +			MX93_PAD_SD1_DATA3__USDHC1_DATA3	0x4000139e
> +			MX93_PAD_SD1_DATA4__USDHC1_DATA4	0x4000139e
> +			MX93_PAD_SD1_DATA5__USDHC1_DATA5	0x4000139e
> +			MX93_PAD_SD1_DATA6__USDHC1_DATA6	0x4000139e
> +			MX93_PAD_SD1_DATA7__USDHC1_DATA7	0x4000139e
>  		>;
>  	};
>
> --
> 2.43.0
>