From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "Bjorn Andersson" <andersson@kernel.org>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
linux-renesas-soc@vger.kernel.org,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Antonio Borneo" <antonio.borneo@foss.st.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Lee Jones" <lee@kernel.org>, "Linus Walleij" <linusw@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-spi@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, "Mark Brown" <broonie@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Srinivas Kandagatla" <srini@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Wilken Gottwalt" <wilken.gottwalt@posteo.net>,
"Will Deacon" <will@kernel.org>
Subject: Re: [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair
Date: Tue, 10 Feb 2026 09:20:52 +0200 [thread overview]
Message-ID: <aYrcVE9HsDNAwqIB@smile.fi.intel.com> (raw)
In-Reply-To: <aYo60vooftdem4Lt@ninjato>
On Mon, Feb 09, 2026 at 08:51:46PM +0100, Wolfram Sang wrote:
> > > Moving maintainers from CC to To ;) Do you, in general, approve this
> > > change to the headers?
> >
> > Certainly, I don't think we should force unnatural slicing of drivers
> > across the source tree.
>
> Cool, glad you like it.
>
> > I've always found the current model unergonomic, resolving this part
> > might very well have the side effect that Andy is looking for (and I'd
> > welcome that).
>
> Yeah probably, but frankly the task of redesigning hwlock-allocation is
> a bit exceeding my bandwidth for this project. Can we make this a second
> step on top of this series?
How do you see it's done if others will (*) start (ab)using that struct
directly?
> And if so, would be this series acceptable
> as-is then (modulo the better include-sorting mentioned by Andy)?
*From my experience it's not the Q "will they or not?", the Q is "when?"
they start abusing it. I really prefer to hide as much as possible from
day 1. Maybe the structure can be split to two? Currently IIO has a
(painful and long) conversion from open to opaque. Taking this into account
I really don't won't to repeat this design mistake. But it's all up to
the maintainers, of course. Just my deep worries about this... while
the idea, as I said, I fully support.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-10 7:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 18:46 [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair Wolfram Sang
2026-01-25 18:46 ` [RFC PATCH 1/4] hwspinlock: refactor existing headers into provider.h Wolfram Sang
2026-01-25 18:46 ` [RFC PATCH 2/4] hwspinlock: refactor existing headers into consumer.h Wolfram Sang
2026-01-25 18:46 ` [RFC PATCH 3/4] treewide: convert hwspinlock users to the new consumer header file Wolfram Sang
2026-01-26 9:54 ` Andy Shevchenko
2026-01-26 11:36 ` Mark Brown
2026-01-26 9:59 ` [RFC PATCH 0/4] hwspinlock: refactor headers into public provider/consumer pair Andy Shevchenko
2026-01-26 10:13 ` Wolfram Sang
2026-01-26 10:20 ` Andy Shevchenko
2026-01-26 10:29 ` Wolfram Sang
2026-01-27 11:41 ` Wolfram Sang
2026-02-09 11:14 ` Wolfram Sang
2026-02-09 11:35 ` Andy Shevchenko
2026-02-09 16:13 ` Bjorn Andersson
2026-02-09 19:51 ` Wolfram Sang
2026-02-09 21:37 ` Bjorn Andersson
2026-02-10 7:20 ` Andy Shevchenko [this message]
2026-02-10 10:44 ` Wolfram Sang
2026-02-10 15:14 ` Andy Shevchenko
2026-01-26 10:14 ` Wilken Gottwalt
2026-01-26 10:16 ` Wolfram Sang
2026-01-26 10:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYrcVE9HsDNAwqIB@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=andy@kernel.org \
--cc=antonio.borneo@foss.st.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=boqun.feng@gmail.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=konradybcio@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mingo@redhat.com \
--cc=nuno.sa@analog.com \
--cc=orsonzhai@gmail.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=samuel@sholland.org \
--cc=skhan@linuxfoundation.org \
--cc=srini@kernel.org \
--cc=tglx@kernel.org \
--cc=wens@kernel.org \
--cc=wilken.gottwalt@posteo.net \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox