From: Keith Busch <kbusch@kernel.org>
To: Yu Kuai <yukuai@fnnas.com>
Cc: Daniel Wagner <dwagner@suse.de>, Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, sagi@grimberg.me, sven@kernel.org, j@jannau.net,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
tj@kernel.org, nilay@linux.ibm.com, ming.lei@redhat.com,
neal@gompa.dev, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] nvme-apple: move blk_mq_update_nr_hw_queues after nvme_unfreeze
Date: Wed, 11 Feb 2026 05:57:34 -0700 [thread overview]
Message-ID: <aYx8vo5kY-nEir3b@kbusch-mbp> (raw)
In-Reply-To: <baa254f9-c41c-44f7-959a-8ce69e1768fa@fnnas.com>
On Wed, Feb 11, 2026 at 09:57:26AM +0800, Yu Kuai wrote:
> If I understand this correctly, it seems fine to make progress with this set,
> currently IO can return error during the race window, and this can be finally
> fixed with this reinsert.
Yeah, if you can just make sure to add an equivalent patch for nvme-pci,
otherwise the last patch in this series will deadlock it.
Some experiments I've run over the last day have me convinced no one is
actually hitting queue count changes in nvme-pci, so I'm not concerned
with opening that race to this scenario. You'd get IO errors either way;
your proposal just potentially gives you more of them, but I don't think
encountering that is practical reality right now anyway.
next prev parent reply other threads:[~2026-02-11 12:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 8:29 [PATCH 0/4] blk-mq/nvme: fix debugfs creation with frozen queue Yu Kuai
2026-02-09 8:29 ` [PATCH 1/4] nvme-rdma: move blk_mq_update_nr_hw_queues after nvme_unfreeze Yu Kuai
2026-02-09 14:57 ` Christoph Hellwig
2026-02-11 7:21 ` Nilay Shroff
2026-02-09 8:29 ` [PATCH 2/4] nvme-tcp: " Yu Kuai
2026-02-09 14:57 ` Christoph Hellwig
2026-02-11 7:22 ` Nilay Shroff
2026-02-09 8:29 ` [PATCH 3/4] nvme-apple: " Yu Kuai
2026-02-09 14:58 ` Christoph Hellwig
2026-02-09 15:35 ` Keith Busch
2026-02-10 6:47 ` Yu Kuai
2026-02-10 15:09 ` Keith Busch
2026-02-10 15:41 ` Christoph Hellwig
2026-02-10 16:01 ` Keith Busch
2026-02-10 16:28 ` Daniel Wagner
2026-02-11 1:57 ` Yu Kuai
2026-02-11 12:57 ` Keith Busch [this message]
2026-02-10 8:10 ` Nilay Shroff
2026-02-10 15:12 ` Keith Busch
2026-02-11 7:23 ` Nilay Shroff
2026-02-09 8:29 ` [PATCH 4/4] blk-mq: use blk_queue_enter/exit to protect debugfs file creation Yu Kuai
2026-02-09 14:59 ` Christoph Hellwig
2026-02-09 16:40 ` Bart Van Assche
2026-02-09 17:33 ` Keith Busch
2026-02-09 17:51 ` Bart Van Assche
2026-02-10 6:59 ` Yu Kuai
2026-02-10 15:41 ` Christoph Hellwig
2026-02-11 7:20 ` Nilay Shroff
2026-02-11 8:06 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYx8vo5kY-nEir3b@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=neal@gompa.dev \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
--cc=sven@kernel.org \
--cc=tj@kernel.org \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox