From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hugo Villeneuve <hugo@hugovil.com>,
robin@protonic.nl, andy@kernel.org, geert@linux-m68k.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
hvilleneuve@dimonoff.com, mkorpershoek@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
lee@kernel.org, alexander.sverdlin@gmail.com,
marek.vasut@gmail.com, akurz@blala.de,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3 4/4] Input: charlieplex_keypad: add GPIO charlieplex keypad
Date: Wed, 25 Feb 2026 19:21:36 +0200 [thread overview]
Message-ID: <aZ8voAddPvMLCvc4@smile.fi.intel.com> (raw)
In-Reply-To: <aZ8tocPCKqTXqbC0@google.com>
On Wed, Feb 25, 2026 at 09:14:16AM -0800, Dmitry Torokhov wrote:
> On Wed, Feb 25, 2026 at 11:56:52AM -0500, Hugo Villeneuve wrote:
> > On Wed, 25 Feb 2026 11:41:55 -0500
> > Hugo Villeneuve <hugo@hugovil.com> wrote:
> > > On Wed, 25 Feb 2026 18:12:13 +0200
> > > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > > > On Wed, Feb 25, 2026 at 10:54:01AM -0500, Hugo Villeneuve wrote:
...
> > > > > +#include <linux/of.h>
> > > >
> > > > Is this in use? Or you wanted mod_devicetable.h for OF ID table?
> > >
> > > I need only OF ID table, so will replace with mod_devicetable.h.
> >
> > Hi Andy,
> > finally I need <linux/of.h> for of_match_ptr()...
> >
> > But I will keep <mod_devicetable.h> ...
>
> Do we need the dependency on OF? We may include of match pointer
> unconditionally and the driver could be used on ACPI systems with
> PRP0001 HID.
Not only that. of_match_ptr() or ACPI_PTR() shouldn't be used in a new code
(there are, of course, _rare_ corner cases, which this one is not one of).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-25 17:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 15:53 [PATCH v3 0/4] input: add GPIO-based charlieplex keypad Hugo Villeneuve
2026-02-25 15:53 ` [PATCH v3 1/4] dt-bindings: input: add debounce-delay-ms common property Hugo Villeneuve
2026-02-25 15:53 ` [PATCH v3 2/4] dt-bindings: input: add settling-time-us " Hugo Villeneuve
2026-02-25 15:54 ` [PATCH v3 3/4] dt-bindings: input: add GPIO charlieplex keypad Hugo Villeneuve
2026-02-26 9:32 ` Geert Uytterhoeven
2026-02-26 14:48 ` Hugo Villeneuve
2026-02-26 15:35 ` Hugo Villeneuve
2026-02-25 15:54 ` [PATCH v3 4/4] Input: charlieplex_keypad: " Hugo Villeneuve
2026-02-25 16:12 ` Andy Shevchenko
2026-02-25 16:41 ` Hugo Villeneuve
2026-02-25 16:56 ` Hugo Villeneuve
2026-02-25 17:14 ` Dmitry Torokhov
2026-02-25 17:21 ` Andy Shevchenko [this message]
2026-02-25 17:36 ` Hugo Villeneuve
2026-02-25 17:12 ` Dmitry Torokhov
2026-02-25 17:27 ` Hugo Villeneuve
2026-02-26 9:20 ` [PATCH v3 0/4] input: add GPIO-based " Geert Uytterhoeven
2026-02-26 14:27 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ8voAddPvMLCvc4@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akurz@blala.de \
--cc=alexander.sverdlin@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@kernel.org \
--cc=robh@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox