From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8965CE63F2A for ; Mon, 16 Feb 2026 07:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Opw+PLS0BWHyZnDPu+flYAjCe3cBc75M/F2mBVqI99A=; b=qnuaeEXjv++ltzNFhDvjjUf8iR 5r21Bzfpx0ESXK/RKFLd7Tqj3lPwiEuccBPa/lrC7Cm0XmKv76WMutJttDYZ8A9lo/27GsD92/5fh +gtmyuzhL0lm9A8q80XSpO6JKVSuyR3Nh6hVx+LjKvz88o42oQg1pZfm03pCV9eRdWxaiP+TRsWP7 YNH92xyS2dGGfybe6Fo0/y26lqpXRU3u5JIR5351ksFggOYkDXha1Vy/mf1JD3gTFiwV5Z+OAkNQB aArsKwMbxdtMEO+z+gx+EI6JmK/UAfuNwZtCDzRHbh0GF7skvlKeJr6vQOZJZMNXFYwqBpZ69smbW it8lzMCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vrtDr-000000065tR-3czh; Mon, 16 Feb 2026 07:40:47 +0000 Received: from mgamail.intel.com ([192.198.163.13]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vrtDp-000000065sg-2DX7 for linux-arm-kernel@lists.infradead.org; Mon, 16 Feb 2026 07:40:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771227646; x=1802763646; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rzl01EmAAF3JPmfSnc9X96TJUHoCxLOHucj5Oexql0w=; b=GKJ6V8PT/DaG4p45uLJbfGpFBsTHY2/hl+jefDsO9VTGzpaDNno3X+RN m1E0Wtg5MXKX4LdFK8WqTCA6IP9Ble3K/CoWWjnf+oBk5c8GxSVtG3Wrd Ih5eO2meQwbxnZe4lxzOcPEZrDNU9xhw/vh86eTWHEaF7/n6vzZ6uo2oI fumXh1n5l94kwkMRo5e5mH2HXKelzWMZeBsVAjMEz5uaqpL1aLvzZmn1c 8J8kOWJRFDjSNKIzt4QHMlpcRz/unkcVR4ax9lrGK8eMxrG8wny7Dxa2J ghht7NcrDMQJobXeUI1BcJpkPPqpnjdqKuaZidsqRlBwY/2+Mxjkpl4Lj g==; X-CSE-ConnectionGUID: HmaykFUJQkeX8+kgGnkC6g== X-CSE-MsgGUID: iGNPZuxARMqFPuz8XX8+4Q== X-IronPort-AV: E=McAfee;i="6800,10657,11702"; a="74904118" X-IronPort-AV: E=Sophos;i="6.21,293,1763452800"; d="scan'208";a="74904118" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2026 23:40:45 -0800 X-CSE-ConnectionGUID: BH0UtUILRuu9c8XvwWIhyw== X-CSE-MsgGUID: tFeetPcMQWKoSU6GurUL/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,293,1763452800"; d="scan'208";a="212096952" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.188]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2026 23:40:35 -0800 Date: Mon, 16 Feb 2026 09:40:33 +0200 From: Andy Shevchenko To: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Torgue , Andy Shevchenko , Antonio Borneo , Arnd Bergmann , Baolin Wang , Bjorn Andersson , Boqun Feng , Chen-Yu Tsai , Chunyan Zhang , Danilo Krummrich , David Lechner , driver-core@lists.linux.dev, Greg Kroah-Hartman , Ingo Molnar , Jernej Skrabec , Jonathan Cameron , Jonathan Corbet , Konrad Dybcio , Lee Jones , Linus Walleij , linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Mark Brown , Maxime Coquelin , Nuno =?iso-8859-1?Q?S=E1?= , Orson Zhai , Peter Zijlstra , "Rafael J. Wysocki" , Samuel Holland , Shuah Khan , Srinivas Kandagatla , Thomas Gleixner , Waiman Long , Wilken Gottwalt , Will Deacon Subject: Re: [RFC v2 PATCH 00/13] hwspinlock: move device alloc into core and refactor includes Message-ID: References: <20260215225501.6365-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260215225501.6365-1-wsa+renesas@sang-engineering.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260215_234045_588561_5E0CC1E2 X-CRM114-Status: GOOD ( 25.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 15, 2026 at 11:54:40PM +0100, Wolfram Sang wrote: > My ultimate goal is to allow hwspinlock provider drivers outside of the > subsystem directory. It turned out that a simple split of the headers > files into a public provider and a public consumer header file is not > enough because core internal structure need to stay hidden. Even more, > their opaqueness could and should even be increased. That would also > allow the core to handle the de-/allocation of the hwspinlock device > itself. > > This series does all that. Patches 1-7 abstract access to internal > structures away using helpers. Patch 8 then move hwspinlock device > handling to the core, simplifying drivers. The remaining patches > refactor the headers until the internal one is gone and the public ones > are divided into provider and consumer parts. More details are given in > the patch descriptions. > > One note about using a callback to initialize hwspinlock priv: I also > experimented with a dedicated 'set_priv' helper function. It felt a bit > clumsy to me. Drivers would need to save the 'bank' pointer again and > iterate over it. Because most drivers will only have a simple callback > anyhow, it looked leaner to me. > > This series is based on the cleanup series "hwspinlock: remove > platform_data from subsystem" and has been tested on a Renesas > SparrowHawk board (R-Car V4H) with a yet-to-be-upstreamed hwspinlock > driver for the MFIS IP core. A branch can be found here (the MFIS driver > is still WIP): > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/hwspinlock/refactor-alloc-buildtest > > Buildbots seem to be happy, too. > > Looking forward to comments. I especially wonder if the last patch > should stay as-is or if it should be broken out, so individual > subsystems can pick up their part (with a fallback in place, of course, > until the last user is converted). Coincidentally I have briefly reviewed it in the Git tree before you have sent this to ML. I like the whole series, but what I have missed is the explanation of the removal of Contact: comment in some of the files. -- With Best Regards, Andy Shevchenko