From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v1 03/11] arm64: dts: freescale: imx8mm-var-som: Update FEC support with MaxLinear PHY
Date: Wed, 18 Feb 2026 15:59:51 +0100 [thread overview]
Message-ID: <aZXT5wMGQgMKHCXQ@Lord-Beerus.station> (raw)
In-Reply-To: <fac81a12-92c9-4e29-96ca-473c18fca675@lunn.ch>
Hi Andrew,
On Wed, Feb 18, 2026 at 02:23:40PM +0100, Andrew Lunn wrote:
> On Wed, Feb 18, 2026 at 09:59:31AM +0100, Stefano Radaelli wrote:
> > Hi Andrew,
> >
> > On Tue, Feb 17, 2026 at 09:43:16PM +0100, Andrew Lunn wrote:
> > >
> > > And here you loose me. RGMII is between the MAC and the PHY. The PHY
> > > is on the SOM, so there is no need for RGMII to leave the SOM.
> > >
> > > MDIO is can understand going to the carrier, because there can be
> > > other devices on the bus, such as an Ethernet switch.
> > >
> > > You say the LEDs are not on the SOM. So they should not be listed in
> > > the .dtsi file for the SOM. It could be the RJ45 is a cheap one,
> > > without LEDs. The colours will depend on the RJ45 socket. It could be
> > > a single LED is connected to the front panel, which is typical of STB
> > > etc. So the LEDs are a board property, not a SOM property.
> > >
> > > > > > Two LEDs are defined to match the VAR-SOM carrier design:
> > > > > > * LED@0: Yellow, netdev trigger.
> > > > > > * LED@1: Green, netdev trigger.
> > > > >
> > > > > Where are the LEDs? You say "carrier design", so are they on the
> > > > > carrier? The DT properties should then be in the .dts file for the
> > > > > carrier.
> > > > >
> > > >
> > > > The LED signals are driven directly by the PHY and originate on the SOM.
> > > > They are exposed on the SOM connector and are typically routed straight
> > > > to the RJ45 integrated LEDs on the carrier.
> > >
> > > The problem here is 'typically', not absolutely required, otherwise
> > > the magic smoke will escape making the box useless.
> > >
> >
> > You are right sorry for the confusion: RGMII is internal between the MAC
> > and the PHY and does not leave the SOM. What is exposed on the SOM
> > connector are the MDI pairs towards the magnetics/RJ45 and the PHY LED
> > output signals.
>
> O.K, that is what i expected.
>
> > Given that the actual LEDs are implemented on the carrier side (RJ45
> > with integrated LEDs, pull-ups and LED supply), would you prefer that
> > the LED description is moved out of the SOM .dtsi and into the carrier
> > .dts?
>
> Yes please.
>
> > My idea would be to keep the Ethernet controller/PHY node fully
> > described in the SOM .dtsi (since the PHY is on-module), and add only
> > the LED subnode/definition in the carrier .dts where the LEDs are
> > actually present.
>
> Yes. That is good.
>
> Thanks
> Andrew
I will send the v2 with led descriptions in Symphony dts instead of SOM
dtsi.
Thank you again,
Best Regards,
Stefano
next prev parent reply other threads:[~2026-02-18 15:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 18:42 [PATCH v1 00/11] arm64: dts: freescale: imx8mm-var-som: Align SOM and Symphony DTSs Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 01/11] arm64: dts: imx8mm-var-som: Move UART4 description to Symphony carrier Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 02/11] arm64: dts: freescale: imx8mm-var-som: Align fsl,pins tables Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 03/11] arm64: dts: freescale: imx8mm-var-som: Update FEC support with MaxLinear PHY Stefano Radaelli
2026-02-17 18:54 ` Andrew Lunn
2026-02-17 19:31 ` Stefano Radaelli
2026-02-17 20:43 ` Andrew Lunn
2026-02-18 8:59 ` Stefano Radaelli
2026-02-18 13:23 ` Andrew Lunn
2026-02-18 14:59 ` Stefano Radaelli [this message]
2026-02-17 18:42 ` [PATCH v1 04/11] arm64: dts: imx8mm-var-som: Add support for WM8904 audio codec Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 05/11] arm64: dts: freescale: imx8mm-var-som: Add MCP251xFD CAN controller Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 06/11] arm64: dts: freescale: imx8mm-var-som: Update WiFi/BT configuration Stefano Radaelli
2026-02-17 18:59 ` Fabio Estevam
2026-02-17 19:42 ` Stefano Radaelli
2026-02-18 16:35 ` Frank Li
2026-02-18 17:18 ` Stefano Radaelli
2026-02-24 14:57 ` Stefano Radaelli
2026-02-24 21:30 ` Frank Li
2026-02-26 17:44 ` Stefano Radaelli
2026-02-26 20:29 ` Frank Li
2026-02-17 18:42 ` [PATCH v1 07/11] arm64: dts: imx8mm-var-som-symphony: Move USB configuration from SOM Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 08/11] arm64: dts: imx8mm-var-som-symphony: Enable uSD on USDHC2 Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 09/11] arm64: dts: imx8mm-var-som-symphony: Add TPM2 support Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 10/11] arm64: dts: freescale: imx8mm-var-som-symphony: Enable I2C4 Stefano Radaelli
2026-02-17 18:42 ` [PATCH v1 11/11] arm64: dts: imx8mm-var-som-symphony: Enable PCIe Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZXT5wMGQgMKHCXQ@Lord-Beerus.station \
--to=stefano.radaelli21@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=stefano.r@variscite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox