From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49DA2C5AD69 for ; Fri, 20 Feb 2026 19:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2fkxRy1ThcTRLWk8+gjT6KJiNOFoa7HuzAZINSGE3vg=; b=xWQrsn56TlS/LKKXlx6mxiQMu+ N6AiKhcP6Q6gQsDK3iiLsTO2q5F3U4dE1Wi6bB59LLf9ZkJLK+Ezlxy/ju5Tev2hYb7ZwPdH1EL1s h0spDUCKa/Y0go6gFMQkhkSmYrcJ27PK6bAFZz+tUXFkrIEMMm9GcM2+HVph4Dcpp8bgk43CH97Ju 6BkfjPZ0ZTUs10bylc4l3JsLcfV0DRyjGF1xkXL4W3q6jOsn0PTgL2xIfcwHpyxWBb3ZtgFg8OmI7 AwG6Lw2Yym2h9fqKGNkhLw0to4C41QmVmnm7WeWkRZJ9f14LHvPlPd1ngRIvenT2wwdibrfPJg5Cc GO/E8TDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vtVxo-0000000FUoJ-2gih; Fri, 20 Feb 2026 19:14:56 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vtVxm-0000000FUnG-0EIu; Fri, 20 Feb 2026 19:14:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 56FE8418D8; Fri, 20 Feb 2026 19:14:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA755C116C6; Fri, 20 Feb 2026 19:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771614892; bh=N/dul5YjHzDXPfrduHVCi4Yg6lOyDfk2HzDDWaV+YQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dl4K9twKTKk+64XuV3tx697p+tSKE4KpQAY+Nm3YF1p4RQ05z2krCL7vET+svQbq5 VG8ENPLrxvLm/+whZxz7wR4sSkpTeUfkYv0ng1u1YVUiDdnp8o8K/ltQpAb0sRhhOy rXgnEi1fxdVV7wKy6o/+ac2dBU905VE6WwRTURFE2/UJPkevi35wRQJ3wcx8pxvJL3 qH7yoJBL8zTJatIySTsfhPDUB1BBxBRzyo1NKjJzbcnEssXaEJKTQi0Oye1uhAaXPh P3BILrh7CooTpzS9Xd2cs8bvXzY3zgzfP1rVyzHWfNebJK+Q3V4jNuZh9AQyF9VNxU mNL8AGmVqa1wA== Date: Fri, 20 Feb 2026 11:14:49 -0800 From: Namhyung Kim To: Sean Christopherson Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Xin Li , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mingwei Zhang , Xudong Hao , Sandipan Das , Dapeng Mi , Xiong Zhang , Manali Shukla , Jim Mattson Subject: Re: [PATCH v6 42/44] KVM: VMX: Dedup code for adding MSR to VMCS's auto list Message-ID: References: <20251206001720.468579-1-seanjc@google.com> <20251206001720.468579-43-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260220_111454_134905_5CED456F X-CRM114-Status: GOOD ( 26.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 20, 2026 at 08:46:07AM -0800, Sean Christopherson wrote: > On Thu, Feb 19, 2026, Namhyung Kim wrote: > > Hello, > > > > On Fri, Dec 05, 2025 at 04:17:18PM -0800, Sean Christopherson wrote: > > > Add a helper to add an MSR to a VMCS's "auto" list to deduplicate the code > > > in add_atomic_switch_msr(), and so that the functionality can be used in > > > the future for managing the MSR auto-store list. > > > > > > No functional change intended. > > > > > > Signed-off-by: Sean Christopherson > > > --- > > > arch/x86/kvm/vmx/vmx.c | 41 +++++++++++++++++++---------------------- > > > 1 file changed, 19 insertions(+), 22 deletions(-) > > > > > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > > > index 018e01daab68..3f64d4b1b19c 100644 > > > --- a/arch/x86/kvm/vmx/vmx.c > > > +++ b/arch/x86/kvm/vmx/vmx.c > > > @@ -1093,12 +1093,28 @@ static __always_inline void add_atomic_switch_msr_special(struct vcpu_vmx *vmx, > > > vm_exit_controls_setbit(vmx, exit); > > > } > > > > > > +static void vmx_add_auto_msr(struct vmx_msrs *m, u32 msr, u64 value, > > > + unsigned long vmcs_count_field, struct kvm *kvm) > > > +{ > > > + int i; > > > + > > > + i = vmx_find_loadstore_msr_slot(m, msr); > > > + if (i < 0) { > > > + if (KVM_BUG_ON(m->nr == MAX_NR_LOADSTORE_MSRS, kvm)) > > > + return; > > > + > > > + i = m->nr++; > > > + m->val[i].index = msr; > > > + vmcs_write32(vmcs_count_field, m->nr); > > > + } > > > + m->val[i].value = value; > > > +} > > > + > > > static void add_atomic_switch_msr(struct vcpu_vmx *vmx, unsigned msr, > > > u64 guest_val, u64 host_val) > > > { > > > struct msr_autoload *m = &vmx->msr_autoload; > > > struct kvm *kvm = vmx->vcpu.kvm; > > > - int i; > > > > > > switch (msr) { > > > case MSR_EFER: > > > @@ -1132,27 +1148,8 @@ static void add_atomic_switch_msr(struct vcpu_vmx *vmx, unsigned msr, > > > wrmsrq(MSR_IA32_PEBS_ENABLE, 0); > > > } > > > > > > - i = vmx_find_loadstore_msr_slot(&m->guest, msr); > > > - if (i < 0) { > > > - if (KVM_BUG_ON(m->guest.nr == MAX_NR_LOADSTORE_MSRS, kvm)) > > > - return; > > > - > > > - i = m->guest.nr++; > > > - m->guest.val[i].index = msr; > > > - vmcs_write32(VM_ENTRY_MSR_LOAD_COUNT, m->guest.nr); > > > - } > > > - m->guest.val[i].value = guest_val; > > > - > > > - i = vmx_find_loadstore_msr_slot(&m->host, msr); > > > - if (i < 0) { > > > - if (KVM_BUG_ON(m->host.nr == MAX_NR_LOADSTORE_MSRS, kvm)) > > > - return; > > > - > > > - i = m->host.nr++; > > > - m->host.val[i].index = msr; > > > - vmcs_write32(VM_EXIT_MSR_LOAD_COUNT, m->host.nr); > > > - } > > > - m->host.val[i].value = host_val; > > > + vmx_add_auto_msr(&m->guest, msr, guest_val, VM_ENTRY_MSR_LOAD_COUNT, kvm); > > > + vmx_add_auto_msr(&m->guest, msr, host_val, VM_EXIT_MSR_LOAD_COUNT, kvm); > > > > Shouldn't it be &m->host for the host_val? > > Ouch. Yes. How on earth did this escape testing... Ah, because in practice > only MSR_IA32_PEBS_ENABLE goes through the load lists, and the VM-Entry load list > will use the guest's value due to VM_ENTRY_MSR_LOAD_COUNT not covering the bad > host value. > > Did you happen to run into problems when using PEBS events in the host? No, I just found it by reading the patch. > > Regardless, do you want to send a patch? Either way, I'll figure out a way to > verify the bug and the fix. Sure, will do. Thanks, Namhyung