[PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Cristian Ciocaltea]

When building device trees for the RK3576 based boards, DTC shows the
following complaint:

  rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"

Provide the register blocks in the expected address-based order.

Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576")
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
index 49ccdf12ef7e..45eb0d053a6f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
@@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {
 
 		vdec: video-codec@27b00000 {
 			compatible = "rockchip,rk3576-vdec";
-			reg = <0x0 0x27b00100 0x0 0x500>,
-			      <0x0 0x27b00000 0x0 0x100>,
+			reg = <0x0 0x27b00000 0x0 0x100>,
+			      <0x0 0x27b00100 0x0 0x500>,
 			      <0x0 0x27b00600 0x0 0x100>;
-			reg-names = "function", "link", "cache";
+			reg-names = "link", "function", "cache";
 			interrupts = <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&cru ACLK_RKVDEC_ROOT>, <&cru HCLK_RKVDEC>,
 				 <&cru ACLK_RKVDEC_ROOT_BAK>, <&cru CLK_RKVDEC_CORE>,

---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 2147 bytes --]

Hi,

On Mon, Feb 23, 2026 at 02:25:05PM +0200, Cristian Ciocaltea wrote:
> When building device trees for the RK3576 based boards, DTC shows the
> following complaint:
> 
>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
> 
> Provide the register blocks in the expected address-based order.
> 
> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---

This fixes this warning, but instead creates a new one, because the
reg-names order is fixed in the DT binding:

   reg:
     minItems: 1
     items:
       - description: The function configuration registers base
       - description: The link table configuration registers base
       - description: The cache configuration registers base
  
   reg-names:
     items:
       - const: function
       - const: link
       - const: cache

Greetings,

-- Sebastian

>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 49ccdf12ef7e..45eb0d053a6f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {
>  
>  		vdec: video-codec@27b00000 {
>  			compatible = "rockchip,rk3576-vdec";
> -			reg = <0x0 0x27b00100 0x0 0x500>,
> -			      <0x0 0x27b00000 0x0 0x100>,
> +			reg = <0x0 0x27b00000 0x0 0x100>,
> +			      <0x0 0x27b00100 0x0 0x500>,
>  			      <0x0 0x27b00600 0x0 0x100>;
> -			reg-names = "function", "link", "cache";
> +			reg-names = "link", "function", "cache";
>  			interrupts = <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&cru ACLK_RKVDEC_ROOT>, <&cru HCLK_RKVDEC>,
>  				 <&cru ACLK_RKVDEC_ROOT_BAK>, <&cru CLK_RKVDEC_CORE>,
> 
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Diederik de Haas]

On Mon Feb 23, 2026 at 3:31 PM CET, Sebastian Reichel wrote:
> On Mon, Feb 23, 2026 at 02:25:05PM +0200, Cristian Ciocaltea wrote:
>> When building device trees for the RK3576 based boards, DTC shows the
>> following complaint:
>> 
>>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
>> 
>> Provide the register blocks in the expected address-based order.
>> 
>> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576")
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>
> This fixes this warning, but instead creates a new one, because the
> reg-names order is fixed in the DT binding:
>
>    reg:
>      minItems: 1
>      items:
>        - description: The function configuration registers base
>        - description: The link table configuration registers base
>        - description: The cache configuration registers base
>   
>    reg-names:
>      items:
>        - const: function
>        - const: link
>        - const: cache

See also the prior discussion wrt this:
https://lore.kernel.org/linux-rockchip/edabca63-594e-44ae-8a3d-0f60987a8664@collabora.com/

>
> Greetings,
>
> -- Sebastian
>
>>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> index 49ccdf12ef7e..45eb0d053a6f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> @@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {
>>  
>>  		vdec: video-codec@27b00000 {
>>  			compatible = "rockchip,rk3576-vdec";
>> -			reg = <0x0 0x27b00100 0x0 0x500>,
>> -			      <0x0 0x27b00000 0x0 0x100>,
>> +			reg = <0x0 0x27b00000 0x0 0x100>,
>> +			      <0x0 0x27b00100 0x0 0x500>,
>>  			      <0x0 0x27b00600 0x0 0x100>;
>> -			reg-names = "function", "link", "cache";
>> +			reg-names = "link", "function", "cache";
>>  			interrupts = <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
>>  			clocks = <&cru ACLK_RKVDEC_ROOT>, <&cru HCLK_RKVDEC>,
>>  				 <&cru ACLK_RKVDEC_ROOT_BAK>, <&cru CLK_RKVDEC_CORE>,
>> 
>> ---
>> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
>> change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98
>> 

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Nicolas Dufresne]

[-- Attachment #1: Type: text/plain, Size: 1961 bytes --]

Hi Cristian,

Le lundi 23 février 2026 à 14:25 +0200, Cristian Ciocaltea a écrit :
> When building device trees for the RK3576 based boards, DTC shows the
> following complaint:
> 
>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg):
> /soc/video-codec@27b00000: simple-bus unit address format error, expected
> "27b00100"
> 
> Provide the register blocks in the expected address-based order.
> 
> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on
> rk3576")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 49ccdf12ef7e..45eb0d053a6f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {
>  
>  		vdec: video-codec@27b00000 {
>  			compatible = "rockchip,rk3576-vdec";
> -			reg = <0x0 0x27b00100 0x0 0x500>,
> -			      <0x0 0x27b00000 0x0 0x100>,
> +			reg = <0x0 0x27b00000 0x0 0x100>,
> +			      <0x0 0x27b00100 0x0 0x500>,
>  			      <0x0 0x27b00600 0x0 0x100>;
> -			reg-names = "function", "link", "cache";
> +			reg-names = "link", "function", "cache";

I have a vague memory it was done on purpose, due to the "items" in the bindings
requiring to follow the same order. I was not enable to run the DT checks today
(some pythonic version miss-match issue), but wanted to raise the flag.

Nicolas

>  			interrupts = <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&cru ACLK_RKVDEC_ROOT>, <&cru HCLK_RKVDEC>,
>  				 <&cru ACLK_RKVDEC_ROOT_BAK>, <&cru
> CLK_RKVDEC_CORE>,
> 
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260223-vdec-reg-order-rk3576-cc2ec6e05e98

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Cristian Ciocaltea]

On 2/23/26 4:39 PM, Diederik de Haas wrote:
> On Mon Feb 23, 2026 at 3:31 PM CET, Sebastian Reichel wrote:
>> On Mon, Feb 23, 2026 at 02:25:05PM +0200, Cristian Ciocaltea wrote:
>>> When building device trees for the RK3576 based boards, DTC shows the
>>> following complaint:
>>>
>>>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"
>>>
>>> Provide the register blocks in the expected address-based order.
>>>
>>> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576")
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>> ---
>>
>> This fixes this warning, but instead creates a new one, because the
>> reg-names order is fixed in the DT binding:
>>
>>    reg:
>>      minItems: 1
>>      items:
>>        - description: The function configuration registers base
>>        - description: The link table configuration registers base
>>        - description: The cache configuration registers base
>>   
>>    reg-names:
>>      items:
>>        - const: function
>>        - const: link
>>        - const: cache

Oh, right, missed to check the binding.. :-(

> 
> See also the prior discussion wrt this:
> https://lore.kernel.org/linux-rockchip/edabca63-594e-44ae-8a3d-0f60987a8664@collabora.com/

That's interesting, I'm also not able to trigger the warning on RK3588.

Regardless, the binding can be easily adjusted with the patch below.  Hence I'm
going to handle this in v2, unless there's a reason against moving further.

Thanks,
Cristian


--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -34,10 +34,12 @@ properties:
       - description: The cache configuration registers base

   reg-names:
-    items:
+    oneOf:
       - const: function
-      - const: link
-      - const: cache
+      - items:
+          - const: link
+          - const: function
+          - const: cache

   interrupts:
     maxItems: 1

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Cristian Ciocaltea]

Hi Nicolas,

On 2/23/26 4:51 PM, Nicolas Dufresne wrote:
> Hi Cristian,
> 
> Le lundi 23 février 2026 à 14:25 +0200, Cristian Ciocaltea a écrit :
>> When building device trees for the RK3576 based boards, DTC shows the
>> following complaint:
>>
>>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg):
>> /soc/video-codec@27b00000: simple-bus unit address format error, expected
>> "27b00100"
>>
>> Provide the register blocks in the expected address-based order.
>>
>> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on
>> rk3576")
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> index 49ccdf12ef7e..45eb0d053a6f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
>> @@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {
>>  
>>  		vdec: video-codec@27b00000 {
>>  			compatible = "rockchip,rk3576-vdec";
>> -			reg = <0x0 0x27b00100 0x0 0x500>,
>> -			      <0x0 0x27b00000 0x0 0x100>,
>> +			reg = <0x0 0x27b00000 0x0 0x100>,
>> +			      <0x0 0x27b00100 0x0 0x500>,
>>  			      <0x0 0x27b00600 0x0 0x100>;
>> -			reg-names = "function", "link", "cache";
>> +			reg-names = "link", "function", "cache";
> 
> I have a vague memory it was done on purpose, due to the "items" in the bindings
> requiring to follow the same order. I was not enable to run the DT checks today
> (some pythonic version miss-match issue), but wanted to raise the flag.

As I mentioned in my previous reply, I think we should change the binding to
allow using the correct order.

Thanks,
cristian

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Nicolas Dufresne]

[-- Attachment #1: Type: text/plain, Size: 2629 bytes --]

Hi,

Le lundi 23 février 2026 à 19:07 +0200, Cristian Ciocaltea a écrit :
> On 2/23/26 4:39 PM, Diederik de Haas wrote:
> > On Mon Feb 23, 2026 at 3:31 PM CET, Sebastian Reichel wrote:
> > > On Mon, Feb 23, 2026 at 02:25:05PM +0200, Cristian Ciocaltea wrote:
> > > > When building device trees for the RK3576 based boards, DTC shows the
> > > > following complaint:
> > > > 
> > > >   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg):
> > > > /soc/video-codec@27b00000: simple-bus unit address format error,
> > > > expected "27b00100"
> > > > 
> > > > Provide the register blocks in the expected address-based order.
> > > > 
> > > > Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video
> > > > Decoder on rk3576")
> > > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> > > > ---
> > > 
> > > This fixes this warning, but instead creates a new one, because the
> > > reg-names order is fixed in the DT binding:
> > > 
> > >    reg:
> > >      minItems: 1
> > >      items:
> > >        - description: The function configuration registers base
> > >        - description: The link table configuration registers base
> > >        - description: The cache configuration registers base
> > >   
> > >    reg-names:
> > >      items:
> > >        - const: function
> > >        - const: link
> > >        - const: cache
> 
> Oh, right, missed to check the binding.. :-(
> 
> > 
> > See also the prior discussion wrt this:
> > https://lore.kernel.org/linux-rockchip/edabca63-594e-44ae-8a3d-0f60987a8664@collabora.com/
> 
> That's interesting, I'm also not able to trigger the warning on RK3588.
> 
> Regardless, the binding can be easily adjusted with the patch below.  Hence
> I'm
> going to handle this in v2, unless there's a reason against moving further.
> 
> Thanks,
> Cristian
> 
> 
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -34,10 +34,12 @@ properties:
>        - description: The cache configuration registers base
> 
>    reg-names:
> -    items:
> +    oneOf:

Is there a better keyword for that, cause picking 3 of a one of is clearly
confusing to read.

Nicolas

>        - const: function
> -      - const: link
> -      - const: cache
> +      - items:
> +          - const: link
> +          - const: function
> +          - const: cache
> 
>    interrupts:
>      maxItems: 1

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Hi,

On Mon, Feb 23, 2026 at 07:07:42PM +0200, Cristian Ciocaltea wrote:
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -34,10 +34,12 @@ properties:
>        - description: The cache configuration registers base
> 
>    reg-names:
> -    items:
> +    oneOf:
>        - const: function
> -      - const: link
> -      - const: cache
> +      - items:
> +          - const: link
> +          - const: function
> +          - const: cache
> 
>    interrupts:
>      maxItems: 1
> 

With that change the descriptions in the reg section are wrong.

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Cristian Ciocaltea]

Hi Sebastian,

On 2/23/26 8:21 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Feb 23, 2026 at 07:07:42PM +0200, Cristian Ciocaltea wrote:
>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> @@ -34,10 +34,12 @@ properties:
>>        - description: The cache configuration registers base
>>
>>    reg-names:
>> -    items:
>> +    oneOf:
>>        - const: function
>> -      - const: link
>> -      - const: cache
>> +      - items:
>> +          - const: link
>> +          - const: function
>> +          - const: cache
>>
>>    interrupts:
>>      maxItems: 1
>>
> 
> With that change the descriptions in the reg section are wrong.

Yeah, I assumed it'd be acceptable for the description to document just once all
possible items, to avoid repeating this for all possible combinations.

E.g. this is from Documentation/devicetree/bindings/net/snps,dwmac.yaml:

  resets:
    minItems: 1
    items:
      - description: GMAC stmmaceth reset
      - description: AHB reset

  reset-names:
    oneOf:
      - items:
          - enum: [stmmaceth, ahb]
      - items:
          - const: stmmaceth
          - const: ahb

Thanks,
Cristian

Re: [PATCH] arm64: dts: rockchip: Fix vdec register blocks order on RK3576

[Cristian Ciocaltea]

On 2/23/26 8:29 PM, Cristian Ciocaltea wrote:
> Hi Sebastian,
> 
> On 2/23/26 8:21 PM, Sebastian Reichel wrote:
>> Hi,
>>
>> On Mon, Feb 23, 2026 at 07:07:42PM +0200, Cristian Ciocaltea wrote:
>>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>>> @@ -34,10 +34,12 @@ properties:
>>>        - description: The cache configuration registers base
>>>
>>>    reg-names:
>>> -    items:
>>> +    oneOf:
>>>        - const: function
>>> -      - const: link
>>> -      - const: cache
>>> +      - items:
>>> +          - const: link
>>> +          - const: function
>>> +          - const: cache
>>>
>>>    interrupts:
>>>      maxItems: 1
>>>
>>
>> With that change the descriptions in the reg section are wrong.
> 
> Yeah, I assumed it'd be acceptable for the description to document just once all
> possible items, to avoid repeating this for all possible combinations.
> 
> E.g. this is from Documentation/devicetree/bindings/net/snps,dwmac.yaml:
> 
>   resets:
>     minItems: 1
>     items:
>       - description: GMAC stmmaceth reset
>       - description: AHB reset
> 
>   reset-names:
>     oneOf:
>       - items:
>           - enum: [stmmaceth, ahb]
>       - items:
>           - const: stmmaceth
>           - const: ahb

I dropped the descriptions in v2, as we discussed they don't provide much value
anyway:

https://lore.kernel.org/all/20260223-vdec-reg-order-rk3576-v2-0-daf4942dfc02@collabora.com/