From: Frank Li <Frank.li@nxp.com>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Vignesh R <vigneshr@ti.com>, Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Roger Quadros <rogerq@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/12] i2c: mxs: set device parent and of_node through the adapter struct
Date: Mon, 23 Feb 2026 12:19:39 -0500 [thread overview]
Message-ID: <aZyMKxTNPyJVGd-u@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260223-i2c-adap-dev-config-v2-8-d78db0a6fcf7@oss.qualcomm.com>
On Mon, Feb 23, 2026 at 10:05:54AM +0100, Bartosz Golaszewski wrote:
> Configure the parent device and the OF-node using dedicated fields in
> struct i2c_adapter and avoid dereferencing the internal struct device.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/i2c/busses/i2c-mxs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
> index 08c9091a1e35151bac8d4adb80abdbd29a62b95a..bfbd96ee2f483cd1dd872c3448eaa6a17940d70f 100644
> --- a/drivers/i2c/busses/i2c-mxs.c
> +++ b/drivers/i2c/busses/i2c-mxs.c
> @@ -849,9 +849,9 @@ static int mxs_i2c_probe(struct platform_device *pdev)
> adap->owner = THIS_MODULE;
> adap->algo = &mxs_i2c_algo;
> adap->quirks = &mxs_i2c_quirks;
> - adap->dev.parent = dev;
> + adap->parent = dev;
> adap->nr = pdev->id;
> - adap->dev.of_node = pdev->dev.of_node;
> + adap->of_node = pdev->dev.of_node;
> i2c_set_adapdata(adap, i2c);
> err = i2c_add_numbered_adapter(adap);
> if (err) {
>
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-02-23 17:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 9:05 [PATCH v2 00/12] i2c: configure parent device and OF node through the adapter struct Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 01/12] i2c: allow setting the " Bartosz Golaszewski
2026-03-02 7:47 ` Kalle Niemi
2026-03-02 8:55 ` Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 02/12] i2c: qcom-geni: set device parent and of_node " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 03/12] i2c: bcm-kona: " Bartosz Golaszewski
2026-02-23 17:30 ` Florian Fainelli
2026-02-23 9:05 ` [PATCH v2 04/12] i2c: keba: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 05/12] i2c: omap: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 06/12] i2c: rcar: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 07/12] i2c: st: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 08/12] i2c: mxs: " Bartosz Golaszewski
2026-02-23 17:19 ` Frank Li [this message]
2026-02-23 9:05 ` [PATCH v2 09/12] i2c: highlander: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 10/12] i2c: gpio: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 11/12] i2c: nomadik: " Bartosz Golaszewski
2026-02-23 9:05 ` [PATCH v2 12/12] i2c: bcm2835: " Bartosz Golaszewski
2026-02-23 11:32 ` Dave Stevenson
2026-02-23 17:31 ` Florian Fainelli
2026-02-23 14:08 ` [PATCH v2 00/12] i2c: configure parent device and OF node " Geert Uytterhoeven
2026-02-23 14:43 ` Bartosz Golaszewski
2026-02-26 20:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZyMKxTNPyJVGd-u@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@kernel.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=imx@lists.linux.dev \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=magnus.damm@gmail.com \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=patrice.chotard@foss.st.com \
--cc=rjui@broadcom.com \
--cc=rogerq@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=viken.dadhaniya@oss.qualcomm.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox