From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EFFC433E1 for ; Wed, 8 Jul 2020 17:00:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59CB12078D for ; Wed, 8 Jul 2020 17:00:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cj8fU+M5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LPOU23/W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59CB12078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ExddL3V7LKiHYKPkbMWtcV+lLIys7pvQjUC1EtNzEUs=; b=cj8fU+M5bazFEH2axEr1Mki4K UgyBytcgRO4NczGZVOSUuGXO08KEdd+EIQFfYCer37oTC031uS/A/L3hqdR7C/jXBb+3DBiT3GL3s eqsvlVd+7QxngSQsr4hAwAZ7Xn5OE9uHul2wDRseoQ+Vd6nHBpV0s0pdtgYupZTt1UhUN5hORSZ9A QYIr/VFnBWguA0WEOzIpgHnmJ7kiH+vUvnmYPJQZF2JWNAft6uvddC35V2fJAdICp5ZeJw8/IEELb 8NAl4fD3Sru+MqgbV0N0DaNLlKMhjNDscuZPvHQl+x3sFd4VKJGMl5HYI8ucXSgGlegDwyZ9AJ1VV AjttRwLag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtDPy-0007xf-Si; Wed, 08 Jul 2020 16:59:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtDPw-0007we-I4 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 16:59:33 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EFD11206F6; Wed, 8 Jul 2020 16:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594227571; bh=uh4+uFjSS8z4pzDfvQDdc+cDo68c1srgnsXeCX9tkrM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LPOU23/WvkxwZI/Js3Zh7GK/6l9f479mhy5NmU59FlaNEvxCW0kiCAXv03Cq25GdU 0Q7cNxfNnZ5pAnPqAswpQedsrGbgbH250JStUEa1C+5lH13PgW38dBl/PbI4olK495 wprTQbPlJqgZVFFbs3QBnEqdjTdZ60UZMHgeHm4A= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jtDPt-00A9GR-GX; Wed, 08 Jul 2020 17:59:29 +0100 MIME-Version: 1.0 Date: Wed, 08 Jul 2020 17:59:29 +0100 From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH] KVM: arm64: Fix definition of PAGE_HYP_DEVICE In-Reply-To: <20200708162546.26176-1-will@kernel.org> References: <20200708162546.26176-1-will@kernel.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kernel-team@android.com, catalin.marinas@arm.com, james.morse@arm.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_125932_670708_BF48920F X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , stable@vger.kernel.org, James Morse , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-07-08 17:25, Will Deacon wrote: > PAGE_HYP_DEVICE is intended to encode attribute bits for an EL2 stage-1 > pte mapping a device. Unfortunately, it includes PROT_DEVICE_nGnRE > which > encodes attributes for EL1 stage-1 mappings such as UXN and nG, which > are > RES0 for EL2, and DBM which is meaningless as TCR_EL2.HD is not set. > > Fix the definition of PAGE_HYP_DEVICE so that it doesn't set RES0 bits > at EL2. > > Cc: Marc Zyngier > Cc: Catalin Marinas > Cc: James Morse > Cc: > Signed-off-by: Will Deacon > --- > Marc -- I'm happy to take this as a fix via arm64 with your Ack. > Please just let me know. > > arch/arm64/include/asm/pgtable-prot.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marc Zyngier Thanks for fixing this! M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel