From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8071ECA0FED for ; Tue, 9 Sep 2025 10:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/IUdjMztn2lEK5HOnU9D0CF10p+pvtJH5MIMXBxLW58=; b=3dZYId0MJS7qV0JfMyZCLpWny2 gbXub5AHL23+AJXlyUncSKTIuJf8585WsX0dIHKrq/qL1j3T8TMeaBoTsyN94itaQ2HzHuU7uo1m/ UtdLbTgJX/oOYYeBT9RR62CiICloq8I9F/KC8HNVADlJajycRVh6Z0wiTUh8JOfZf2pi5rW9ds+F8 eQrtgjRJH104EPi+PJ26NyQyrqWFUA0H4UB2ARqoTE4gH8u912X8E4Ng6fMTOud2+Liyy7ithGm4K duaIwpZ6f0a1M1aGAGv9x9JH87y+kv4502LV9h5lWxolhmFacGDBOTtRpJoNk+VKBl2PVnwxGcCo9 4/JzTi2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvvlY-00000006Sct-24oI; Tue, 09 Sep 2025 10:40:00 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvuQQ-00000005rS8-0XBf for linux-arm-kernel@lists.infradead.org; Tue, 09 Sep 2025 09:14:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757409245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/IUdjMztn2lEK5HOnU9D0CF10p+pvtJH5MIMXBxLW58=; b=SfZMqIPNLyTsgFxg61S9EQBDvXBmxiyKWgC1K1aIlgavbFbuIinTf91BZftatBUXpTaSBe v7czNi77iNCOSy789dgVXqGaYnRBDE7zH3kBq6fzcyvTJGTYs5nhK/hSLr//mkRSchBsNB eWVs3r24rEkAyj4TLRjMq7sB19gZ+PA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-8U0OKSqCN4C_kYxLd5yN7w-1; Tue, 09 Sep 2025 05:14:04 -0400 X-MC-Unique: 8U0OKSqCN4C_kYxLd5yN7w-1 X-Mimecast-MFC-AGG-ID: 8U0OKSqCN4C_kYxLd5yN7w_1757409240 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3df3e935ec8so2494241f8f.0 for ; Tue, 09 Sep 2025 02:14:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757409240; x=1758014040; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/IUdjMztn2lEK5HOnU9D0CF10p+pvtJH5MIMXBxLW58=; b=lpxDFHmHwfOAXZxQj26TRSyJc2jPnISbZPxSMxvLRew12+l4qGyOtGIZ/2ynrRzduN euFDQX4hPcPs8P4UALZeMB9V6xaTbuZpIxvAJlrtKoXmJkfHOBl5CWdlSvWsi67Fqcqv vQaxnXbegW8UsT8KDXGaxUhlyLBA7tXSqavhODEBBIaovA9UtkO4qKNKn14UXBZc/nID HsMxulH7e73ZRb00TpK5eCGZR9BbEjy4Ou7hTvtXZi22hFcXiBgIckJmyD5gCbDlQsXA yyngycsuM6AotFhg1hSE/0CUw3bfKa2i8BfdbxiQboey+AVfxNPb7v9qkpOC7ZxeggTa ZTmw== X-Forwarded-Encrypted: i=1; AJvYcCXPDxHD4ylnWRaKQ4bc2STp+/ICvPOa/VXsd0Ed7A3o2/wI3/6t/Lh7zNWenSnWdOsNC6jKpNvQM4hpof4M3ElP@lists.infradead.org X-Gm-Message-State: AOJu0Yx0wDp77dfO8TUg/kmfurGRsILj7ULHZ5ERzHjY1g6dYNgRkiIh QIVI+EWAsLzXJ/5qoR5BJ+EJ3kZQGfBAyc1tWQSGPucpxPailruFy202CZV8XK5wFKZU8zgKTxe fxkePrsyGqeiQP5W8m453/OsQcRfW2V472oUhAe3CHy4iV2EZ9ao30dhYtpaTSysWYf54b9/T79 rr X-Gm-Gg: ASbGnctSFy/9xgwMkvfKNoac+AGaUrBcpr2XffFYFlw11tPK5nw1fN/Y2AFSGLGU712 tNUwP/v9k3++ffdB18mml2mxtmfgdLicDiEs+j9NQPrAemQsJi1Kcyz9q0zE4qCDhv/fYGcA3A0 L99TL1g9OZPOxGIARsHnpS8eXyBkG8hgNFFsMEYkbF6oB+WaB3iD/kjKinBqwyS3b4uB6hDpdwX e5P31K+wbf1QccCticiCv406NCMlHIHUk/ZoANAJq0BF2B5D7TbLh9FO25EJHhENiQhpblp4yow U04ZS0D4FZJAYEBYI8MyrTbMaJ7OtyWHYD4ge2tO740fzpuigclzQoqJ0jolE/g5NO64xR7Iqdc MlbCLGuGhSc9YjWflnoi69yft/Qcey7vdujYozgjj3J/gCbjJ5f6EMZ1we7RCgDFLohg= X-Received: by 2002:a05:6000:3101:b0:3e3:59cc:65ba with SMTP id ffacd0b85a97d-3e64374208dmr2787714f8f.50.1757409239541; Tue, 09 Sep 2025 02:13:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhnq/C72ezwSRJLO4zISvano2xfvFhth932RgVfDh+sCEuObRa/4tJAM3JVWrXDipaf397Wg== X-Received: by 2002:a05:6000:3101:b0:3e3:59cc:65ba with SMTP id ffacd0b85a97d-3e64374208dmr2787666f8f.50.1757409238983; Tue, 09 Sep 2025 02:13:58 -0700 (PDT) Received: from ?IPV6:2003:d8:2f23:9c00:d1f6:f7fe:8f14:7e34? (p200300d82f239c00d1f6f7fe8f147e34.dip0.t-ipconnect.de. [2003:d8:2f23:9c00:d1f6:f7fe:8f14:7e34]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e75223f2e5sm1797097f8f.52.2025.09.09.02.13.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 02:13:58 -0700 (PDT) Message-ID: Date: Tue, 9 Sep 2025 11:13:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] x86/xen: support nested lazy_mmu sections (again) To: Kevin Brodsky , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Alexander Gordeev , Andreas Larsson , Andrew Morton , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org References: <20250908073931.4159362-1-kevin.brodsky@arm.com> <20250908073931.4159362-5-kevin.brodsky@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250908073931.4159362-5-kevin.brodsky@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tRH-UGscfiKs1cHiLDQqXaThcKbwXY9Ueu4DJDjM14I_1757409240 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250909_021406_385001_73C1567D X-CRM114-Status: GOOD ( 24.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08.09.25 09:39, Kevin Brodsky wrote: > Commit 49147beb0ccb ("x86/xen: allow nesting of same lazy mode") > originally introduced support for nested lazy sections (LAZY_MMU and > LAZY_CPU). It later got reverted by commit c36549ff8d84 as its > implementation turned out to be intolerant to preemption. > > Now that the lazy_mmu API allows enter() to pass through a state to > the matching leave() call, we can support nesting again for the > LAZY_MMU mode in a preemption-safe manner. If xen_enter_lazy_mmu() is > called inside an active lazy_mmu section, xen_lazy_mode will already > be set to XEN_LAZY_MMU and we can then return LAZY_MMU_NESTED to > instruct the matching xen_leave_lazy_mmu() call to leave > xen_lazy_mode unchanged. > > The only effect of this patch is to ensure that xen_lazy_mode > remains set to XEN_LAZY_MMU until the outermost lazy_mmu section > ends. xen_leave_lazy_mmu() still calls xen_mc_flush() > unconditionally. > > Signed-off-by: Kevin Brodsky > --- > arch/x86/include/asm/paravirt.h | 6 ++---- > arch/x86/include/asm/paravirt_types.h | 4 ++-- > arch/x86/xen/mmu_pv.c | 11 ++++++++--- > 3 files changed, 12 insertions(+), 9 deletions(-) > > diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h > index 65a0d394fba1..4ecd3a6b1dea 100644 > --- a/arch/x86/include/asm/paravirt.h > +++ b/arch/x86/include/asm/paravirt.h > @@ -529,14 +529,12 @@ static inline void arch_end_context_switch(struct task_struct *next) > #define __HAVE_ARCH_ENTER_LAZY_MMU_MODE > static inline lazy_mmu_state_t arch_enter_lazy_mmu_mode(void) > { > - PVOP_VCALL0(mmu.lazy_mode.enter); > - > - return LAZY_MMU_DEFAULT; > + return PVOP_CALL0(lazy_mmu_state_t, mmu.lazy_mode.enter); > } > > static inline void arch_leave_lazy_mmu_mode(lazy_mmu_state_t state) > { > - PVOP_VCALL0(mmu.lazy_mode.leave); > + PVOP_VCALL1(mmu.lazy_mode.leave, state); > } > > static inline void arch_flush_lazy_mmu_mode(void) > diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h > index bc1af86868a3..b7c567ccbf32 100644 > --- a/arch/x86/include/asm/paravirt_types.h > +++ b/arch/x86/include/asm/paravirt_types.h > @@ -45,8 +45,8 @@ typedef int lazy_mmu_state_t; > > struct pv_lazy_ops { > /* Set deferred update mode, used for batching operations. */ > - void (*enter)(void); > - void (*leave)(void); > + lazy_mmu_state_t (*enter)(void); > + void (*leave)(lazy_mmu_state_t); > void (*flush)(void); > } __no_randomize_layout; > #endif > diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c > index 2039d5132ca3..6e5390ff06a5 100644 > --- a/arch/x86/xen/mmu_pv.c > +++ b/arch/x86/xen/mmu_pv.c > @@ -2130,9 +2130,13 @@ static void xen_set_fixmap(unsigned idx, phys_addr_t phys, pgprot_t prot) > #endif > } > > -static void xen_enter_lazy_mmu(void) > +static lazy_mmu_state_t xen_enter_lazy_mmu(void) > { > + if (this_cpu_read(xen_lazy_mode) == XEN_LAZY_MMU) > + return LAZY_MMU_NESTED; > + You mention above "preemption-safe manner" above, so I am wondering, what if we get preempted immediately after doing the this_cpu_read() and get scheduled on another CPU? -- Cheers David / dhildenb