From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9251FC433E0 for ; Tue, 12 Jan 2021 11:05:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F8B22310C for ; Tue, 12 Jan 2021 11:05:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F8B22310C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aQJ9NJtKcSA9nNiTea8V5JbiTEFflNPsgJa35tVq6m4=; b=KG+v6jj+ljtkTVWdUmajIc3nS OXZlCVA2rVcrXIPHAFaPNooAp5Un/NgEZitAZHT4ITghLZ0cMrRGwOUT+tpoLRSOP2aiuVEKxlMPe nm1zIB2becNvzbXTtIFPm54EnERAVMhZA48qnhpU8ihh+M+6yaygaS3FGb/gN+zyHKfzrzKUBh9sh EZVogPo7mm92Jg3v3zXHOJOn9MfD7gE+8LZXmgZAbzazMuBtdQP0c/yweVPITdQOYTeO01EptyP65 rYrRUQya8g4W1Py1iGM+Hj5TiEqlP+EPxMyAvGbE4y/XaXWyVbedTbaRAyXjjMgt9GvyE5ZtSlzpD 0l8wvhfpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzHSM-0007VM-W9; Tue, 12 Jan 2021 11:03:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzHSJ-0007UA-O6 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 11:03:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69CBD1042; Tue, 12 Jan 2021 03:03:15 -0800 (PST) Received: from [10.57.39.145] (unknown [10.57.39.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB9263F66E; Tue, 12 Jan 2021 03:03:11 -0800 (PST) Subject: Re: [PATCH v1 1/7] coresight: etm-perf: Add support for PID tracing for kernel at EL2 To: Leo Yan , Mike Leach References: <20210109074435.626855-1-leo.yan@linaro.org> <20210109074435.626855-2-leo.yan@linaro.org> <20210112085826.GC18965@leoy-ThinkPad-X240s> From: Suzuki K Poulose Message-ID: Date: Tue, 12 Jan 2021 11:03:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210112085826.GC18965@leoy-ThinkPad-X240s> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_060319_869925_3F48B284 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Al Grant , Denis Nikitin , Mathieu Poirier , Alexander Shishkin , Jiri Olsa , Coresight ML , John Garry , Linux Kernel Mailing List , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Will Deacon , linux-arm-kernel , Daniel Kiss Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/12/21 8:58 AM, Leo Yan wrote: > Hi Mike, > > On Mon, Jan 11, 2021 at 04:22:39PM +0000, Mike Leach wrote: > > [...] > >>> diff --git a/include/linux/coresight-pmu.h b/include/linux/coresight-pmu.h >>> index b0e35eec6499..927c6285ce5d 100644 >>> --- a/include/linux/coresight-pmu.h >>> +++ b/include/linux/coresight-pmu.h >>> @@ -11,16 +11,19 @@ >>> #define CORESIGHT_ETM_PMU_SEED 0x10 >>> >>> /* ETMv3.5/PTM's ETMCR config bit */ >>> -#define ETM_OPT_CYCACC 12 >>> -#define ETM_OPT_CTXTID 14 >>> -#define ETM_OPT_TS 28 >>> -#define ETM_OPT_RETSTK 29 >>> +#define ETM_OPT_CYCACC 12 >>> +#define ETM_OPT_CTXTID 14 >>> +#define ETM_OPT_CTXTID_IN_VMID 15 >> >> Minor issue here - ETMv3.x / PTM cannot trace CXTID in VMID so this >> may better be named ETM4_OPT_CTXTID_IN_VMID, rather than be grouped >> with the ETM3.5 options? > > I looked into this suggestion but found it's complex than I assumed. > This config bits are not only used for ETMv3.x / PTM, it's also used > as an configuration interface between user space in Perf and kernel > drivers. > Exactly. I believe this problematic. We are stuckwith using the ETM3.x/PTM config bits for the CS_ETM pmu, which is a bit wierd and the allocation of the config bits are sparse. The problem with changing them now, will break older perf tools decoding a perf.data from a newer kernel. I believe we are stuck with this. I would recommend simply updating the comment to reflect that, thats the generic CS PMU ABI for configuration which was initially based on ETM3.x. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel