From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lee Yongjun <jun85566@gmail.com>
Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property
Date: Fri, 6 Mar 2026 09:43:39 +0100 [thread overview]
Message-ID: <aa5093fc-18a9-4f23-ac18-0057204fe5b4@kernel.org> (raw)
In-Reply-To: <20260306-phenomenal-hamster-of-memory-819b2b@quoll>
On 06/03/2026 09:42, Krzysztof Kozlowski wrote:
> On Fri, Mar 06, 2026 at 08:47:03AM +0900, Lee Yongjun wrote:
>> The Broadcom iProc SDHCI controller supports DMA, but its binding
>> schema does not allow the 'dma-coherent' property.
>>
>> As a result, dtbs_check reports the following validation errors
>> on the Northstar2 SoC:
>>
>> mmc@66420000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>> are not allowed ('dma-coherent' was unexpected)
>> mmc@66430000 (brcm,sdhci-iproc-cygnus): Unevaluated properties
>> are not allowed ('dma-coherent' was unexpected)
>>
>> Allow the 'dma-coherent' property in the schema to fix the validation
>> errors and accurately reflect the hardware capability.
>
> So is the hardware capable of coherent DMA or not? Entire commit msg is
> silent about this and says how you fix warning without actually telling
> us that it is a correct fix.
>
Heh, why am I reviewing it, it's obviously non-tested. Code is already
there!
NAK
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-06 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 23:47 [PATCH] dt-bindings: mmc: brcm,iproc-sdhci: allow dma-coherent property Lee Yongjun
2026-03-06 0:06 ` Florian Fainelli
2026-03-06 1:21 ` Rob Herring (Arm)
2026-03-06 8:42 ` Krzysztof Kozlowski
2026-03-06 8:43 ` Krzysztof Kozlowski [this message]
[not found] ` <CAJ8Y1dTJ5yNPP8BN46BfDdLAvuWxW+OrZ+P538Bp9+3_6XankA@mail.gmail.com>
2026-03-06 8:45 ` Krzysztof Kozlowski
2026-03-06 11:06 ` Lee Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5093fc-18a9-4f23-ac18-0057204fe5b4@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jun85566@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox