From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B22B0E7C4F4 for ; Thu, 5 Oct 2023 08:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BP/fRZVFiJWfOHfUT5To3g+95ClYvUh2raKJjT/XdEs=; b=3Fqw12YWb1Iyjd 7DnK46NTpaDW44UMdUrqFGcQMwTRavL7O2wJnR0UocJyQmuFZq0Yz/cyueHGLvtLlYzieAip2JBfv Jqxs6Nl6IWWkfnJFbXn0S2ACabqFhXN5dRKubCEYIIwizH3Zqz/7LWuFcRyh9rASyKt6ZTKB9kl7i i3aa8TQ0mk3olBI5TRlBLvLAyUfB/9Ru7rMbK/fLOIGhvTNXYQA5614qUU2SgG2lcUYB5Tbhk7MSh 3pB1I+LzAZSz5yrQGNE03GF4MzaVmAqq1NRMvdH6X6ae1UJjTcDTent7dqakmVQ90mkzu8trfeVTm EtHrJfkHiT6bkIPQ29jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoJcB-001fSH-0f; Thu, 05 Oct 2023 08:21:47 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoJc7-001fRX-1e for linux-arm-kernel@lists.infradead.org; Thu, 05 Oct 2023 08:21:44 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-690d8c05784so561443b3a.2 for ; Thu, 05 Oct 2023 01:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696494100; x=1697098900; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6xF4VcmjAf7zdGNHFHYPdHCqEwDNHCYpzit/ZJRYbdY=; b=PKQXhFaRF+03ZHlZ5IcRRhNFY2HyBmleH7qen0A0MJNKX4umKrartkfJBR97TslsXq CWW5DiGx4267NqzsFU7zIgofhyUHI7UnV32hMjW/Yr5k4KtadfA4fy3dBdFePAz5uMdG s3K7AsxNitACJrHHKkdxwPi01fnyf24QDgKUKAr/hOxjxG7nscjlqAzL9yvVqrp0I2tI T6NZNIpOOwhiXMiLPoFP/khCiQfHsOamYa+34hH/WTP5aea9fFqteM6ohFUbrmYUcEjO leVq77O1v/t6OotZOAxWc7AgK1kgXLquHuknylbxdcRmMjqeY2caeEXR0AeveWjx0Qdc kF3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696494100; x=1697098900; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6xF4VcmjAf7zdGNHFHYPdHCqEwDNHCYpzit/ZJRYbdY=; b=Xc4LxQjeg4pnBnPPtSKlKV9IEkb860UKe5I5A7upvDIuBRQA+Fde24KL9OJ8sqe9w7 ohuzRielHjgMybB3gq3EcKK675+cthp3+2RWykzBbkEAjYIKwWUieI/AovvIYPEX9G/p UKQz2iUBhbdwJYcrJwU1wGZ3UNHh0a7ux7ZD/XJEffI1L9uAG3tSCZlY7pu1pGg1dAvE +NoOJaq5xhpPD3y7zeOSkflVfwtcaWoTbNq1prCaPOfTE3doQA4cExH0fYtqQYRAvElI yoH90yVJ2Eou3mX3O6To/4C+L/E06QG1mrcpdozfM7HBUQI6c3d45dMbGZC0QkhBr0R+ yqeA== X-Gm-Message-State: AOJu0YypazTUG8S6NB0wAFUMdDAp8fuiUJouIu3qVbXuO7gwmZ1nxSGe L6XROq5PwX6DKDXV27dJ4KI= X-Google-Smtp-Source: AGHT+IFKBdwGGId/1JAn0eJrQXX5wPVt+NoaMAx1n6nayA0VFCwN8qF7d/i7qqYCoj4hKXcATdIsBg== X-Received: by 2002:a05:6a20:3d95:b0:159:b7dc:2295 with SMTP id s21-20020a056a203d9500b00159b7dc2295mr4774516pzi.9.1696494100161; Thu, 05 Oct 2023 01:21:40 -0700 (PDT) Received: from [172.16.116.58] ([103.15.228.93]) by smtp.gmail.com with ESMTPSA id du6-20020a056a002b4600b0068a13b0b300sm842288pfb.11.2023.10.05.01.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 01:21:39 -0700 (PDT) Message-ID: Date: Thu, 5 Oct 2023 13:51:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v7 1/3] dt-bindings: net: Add ti,cc1352p7 To: Krzysztof Kozlowski , greybus-dev@lists.linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, vaishnav@beagleboard.org, jkridner@beagleboard.org, nm@ti.com, krzysztof.kozlowski+dt@linaro.org, vigneshr@ti.com, kristo@kernel.org, robh+dt@kernel.org, conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org References: <20231004184639.462510-1-ayushdevel1325@gmail.com> <20231004184639.462510-2-ayushdevel1325@gmail.com> Content-Language: en-US From: Ayush Singh In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_012143_546607_4850A257 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >> Signed-off-by: Ayush Singh >> --- >> .../devicetree/bindings/net/ti,cc1352p7.yaml | 51 +++++++++++++++++++ >> MAINTAINERS | 6 +++ >> 2 files changed, 57 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,cc1352p7.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml >> new file mode 100644 >> index 000000000000..291ba34c389b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,cc1352p7.yaml >> @@ -0,0 +1,51 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,cc1352p7.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments Simplelink CC1352P7 wireless MCU >> + >> +description: >> + The cc1352p7 mcu can be connected via SPI or UART. >> + >> +maintainers: >> + - Ayush Singh >> + >> +properties: >> + compatible: >> + const: ti,cc1352p7 >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + description: >> + sclk_hf is the main system (mcu and peripherals) clock >> + sclk_lf is low-frequency system clock > This does no go here, but to clocks. I wrote how it should be done. > Don't ignore the feedback. It was suggested to use `clock-names` by Nishanth Menon in the previous email, so I thought this was what it meant. I will remove clock-names if that's better. >> + items: >> + - const: sclk_hf >> + - const: sclk_lf >> + >> + reset-gpios: true > > No, really, why do you change correct code into incorrect one? Who asked > you to drop maxItems? I found that many bindings (`display/ilitek,ili9486.yaml`, `iio/dac/adi,ad5758.yaml`) use this pattern instead of `maxItems` for `reset-gpios`. So I assumed it was some sort of convention. I will change it back to `maxItems`. Sincerely, Ayush Singh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel