linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc
@ 2024-06-24  2:41 Jiapeng Chong
  2024-06-24 14:42 ` Yannick FERTRE
  2024-07-15  9:10 ` Raphael Gallais-Pou
  0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2024-06-24  2:41 UTC (permalink / raw)
  To: yannick.fertre
  Cc: raphael.gallais-pou, philippe.cornu, maarten.lankhorst, mripard,
	tzimmermann, airlied, daniel, mcoquelin.stm32, alexandre.torgue,
	dri-devel, linux-stm32, linux-arm-kernel, linux-kernel,
	Jiapeng Chong, Abaci Robot

The function are defined in the ltdc.c file, but not called
anywhere, so delete the unused function.

drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9403
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/stm/ltdc.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 5576fdae4962..3f280155e25c 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -491,11 +491,6 @@ static inline struct ltdc_device *plane_to_ltdc(struct drm_plane *plane)
 	return (struct ltdc_device *)plane->dev->dev_private;
 }
 
-static inline struct ltdc_device *encoder_to_ltdc(struct drm_encoder *enc)
-{
-	return (struct ltdc_device *)enc->dev->dev_private;
-}
-
 static inline enum ltdc_pix_fmt to_ltdc_pixelformat(u32 drm_fmt)
 {
 	enum ltdc_pix_fmt pf;
-- 
2.20.1.7.g153144c



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc
  2024-06-24  2:41 [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc Jiapeng Chong
@ 2024-06-24 14:42 ` Yannick FERTRE
  2024-07-15  9:10 ` Raphael Gallais-Pou
  1 sibling, 0 replies; 3+ messages in thread
From: Yannick FERTRE @ 2024-06-24 14:42 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: raphael.gallais-pou, philippe.cornu, maarten.lankhorst, mripard,
	tzimmermann, airlied, daniel, mcoquelin.stm32, alexandre.torgue,
	dri-devel, linux-stm32, linux-arm-kernel, linux-kernel,
	Abaci Robot

Hi Jiapeng,

Thanks for the patch.

Acked-by: Yannick Fertre <yannick.fertre@foss.st.com>

Best regards


Le 24/06/2024 à 04:41, Jiapeng Chong a écrit :
> The function are defined in the ltdc.c file, but not called
> anywhere, so delete the unused function.
>
> drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9403
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/gpu/drm/stm/ltdc.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 5576fdae4962..3f280155e25c 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -491,11 +491,6 @@ static inline struct ltdc_device *plane_to_ltdc(struct drm_plane *plane)
>   	return (struct ltdc_device *)plane->dev->dev_private;
>   }
>   
> -static inline struct ltdc_device *encoder_to_ltdc(struct drm_encoder *enc)
> -{
> -	return (struct ltdc_device *)enc->dev->dev_private;
> -}
> -
>   static inline enum ltdc_pix_fmt to_ltdc_pixelformat(u32 drm_fmt)
>   {
>   	enum ltdc_pix_fmt pf;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc
  2024-06-24  2:41 [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc Jiapeng Chong
  2024-06-24 14:42 ` Yannick FERTRE
@ 2024-07-15  9:10 ` Raphael Gallais-Pou
  1 sibling, 0 replies; 3+ messages in thread
From: Raphael Gallais-Pou @ 2024-07-15  9:10 UTC (permalink / raw)
  To: Jiapeng Chong, yannick.fertre
  Cc: philippe.cornu, maarten.lankhorst, mripard, tzimmermann, airlied,
	daniel, mcoquelin.stm32, alexandre.torgue, dri-devel, linux-stm32,
	linux-arm-kernel, linux-kernel, Abaci Robot


On 6/24/24 04:41, Jiapeng Chong wrote:
> The function are defined in the ltdc.c file, but not called
> anywhere, so delete the unused function.
>
> drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9403
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>


Hi Jiapeng,

Applied on drm-misc-next.

Thanks,
Raphaël



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-15  9:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24  2:41 [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc Jiapeng Chong
2024-06-24 14:42 ` Yannick FERTRE
2024-07-15  9:10 ` Raphael Gallais-Pou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).