[PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

[PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

[liangxu.xu]

From: liangxu xu <liangxu.xu@mediatek.com>

Add dt-binding documentation of dp for MediaTek MT8188 SoC.

Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,dp.yaml       | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
index ff781f2174a0..2aef1eb32e11 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
@@ -21,6 +21,8 @@ description: |
 properties:
   compatible:
     enum:
+      - mediatek,mt8188-dp-tx
+      - mediatek,mt8188-edp-tx
       - mediatek,mt8195-dp-tx
       - mediatek,mt8195-edp-tx
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

[Krzysztof Kozlowski]

On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> From: liangxu xu <liangxu.xu@mediatek.com>
> 
> Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> 
> Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> ---

Where is the DTS? Where are driver changes?

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

[liangxu.xu]

On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> > From: liangxu xu <liangxu.xu@mediatek.com>
> > 
> > Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> > 
> > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > ---
> 
> Where is the DTS? Where are driver changes?
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof:

If you want to see the synchronous changes of dts and binding files,
then I will attach this binding file changes when sending dts later.

The driver change of mt8188 reuses that of mt8195. The driver link is
as follows:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?id=48f4230642ee32a97ddf4be492838ce96089f040

Best Regards,
LiangXu


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

[Rob Herring]

On Mon, Sep 26, 2022 at 10:52:04AM +0800, liangxu.xu wrote:
> On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> > > From: liangxu xu <liangxu.xu@mediatek.com>
> > > 
> > > Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> > > 
> > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > > ---
> > 
> > Where is the DTS? Where are driver changes?
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Hi Krzysztof:
> 
> If you want to see the synchronous changes of dts and binding files,
> then I will attach this binding file changes when sending dts later.
> 
> The driver change of mt8188 reuses that of mt8195. The driver link is
> as follows:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?id=48f4230642ee32a97ddf4be492838ce96089f040

So the 8188 block is backwards compatible with the 8195 block? 
That's good, but not what your schema says because you have not defined 
a fallback compatible for the driver to use.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

[liangxu.xu]

On Mon, 2022-09-26 at 16:54 -0500, Rob Herring wrote:
> On Mon, Sep 26, 2022 at 10:52:04AM +0800, liangxu.xu wrote:
> > On Fri, 2022-09-23 at 13:16 +0200, Krzysztof Kozlowski wrote:
> > > On 23/09/2022 03:39, liangxu.xu@mediatek.com wrote:
> > > > From: liangxu xu <liangxu.xu@mediatek.com>
> > > > 
> > > > Add dt-binding documentation of dp for MediaTek MT8188 SoC.
> > > > 
> > > > Signed-off-by: liangxu xu <liangxu.xu@mediatek.com>
> > > > ---
> > > 
> > > Where is the DTS? Where are driver changes?
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > 
> > Hi Krzysztof:
> > 
> > If you want to see the synchronous changes of dts and binding
> > files,
> > then I will attach this binding file changes when sending dts
> > later.
> > 
> > The driver change of mt8188 reuses that of mt8195. The driver link
> > is
> > as follows:
> > 
> > 
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?id=48f4230642ee32a97ddf4be492838ce96089f040__;!!CTRNKA9wMg0ARbw!zWA5kU-1QLhCsHN3BeMSN_gCpc5yrXC0qHv9Qxdqs0o510rEVJNZRrulCCCERJIA-SA$
> >  
> 
> So the 8188 block is backwards compatible with the 8195 block? 
> That's good, but not what your schema says because you have not
> defined 
> a fallback compatible for the driver to use.
> 
> Rob

Hi Rob:

Yes, please ignore this patch. According to krzysztof's suggestion, I
will re-send a patch of mt8188 multiplexing mt8195 compatiable after
the mt8188 dts file exists.

Best Regards
LiangXu


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel