From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85895FD0068 for ; Sun, 1 Mar 2026 13:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Q7wucS6pURwPgHIHcP2h2EzaAhhqWaFY4RLsBpkyUQ=; b=M1+kz6FS+2n4VhiTGsW4CDh1NM jimjePNuPzGxLYeOZ3KfPfLJCWjG+mbxJOyNIsxcRN35ZBCQdEOcl4I5+UezBtAyIaBClVRonxFmo idySiKsqZAUaFCAVsPCVRZrdC+iC2wgaLoa6/yPlxNk8TQwv3Ujfo0GfyNOqWxqRUj9Q/+yqRvR5f 9q6IPE3XB6Up7XLbRvGtKlxbIhGTgslJI/pjT1/w50jQIfjBCHHowXTdrYbux2Hf7wB6YIQ8cmCns DWdn2q/z6J9N5cagihPZoF+0LASYoIQ89Dd0x3G2FZn+q1BtqSu3mJpqbgXygk62OvwJI8gu3V7b9 hAvO8wDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwh1M-0000000BXSt-1JBZ; Sun, 01 Mar 2026 13:39:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwh1I-0000000BXSW-4AoX; Sun, 01 Mar 2026 13:39:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1Q7wucS6pURwPgHIHcP2h2EzaAhhqWaFY4RLsBpkyUQ=; b=dF0Wv6tLgza0gUbPq4l/7IJhcO nGOxj81ENoCMwLZD3V0kkqlB8vinRdDF+U4zojPxN2FQhri+VE76vSqHJiHO7y0bjUppSqVKN+ols 4QviiLN7JWTWU8cedj7/MIVjFkEoQfLXZpWM3F7iGMuxk33IvtONkj6PpN0HVMV1++QFetrnvjBgd 9vRETjyYjTuizmQw7Sh90+wUP1B8Ro2eHRiHjnxPykLP/RUBoto2GmlpKbOZzOKpzy4FjhcFyYD9/ pKBimEoFdRNBCBEg4Sa+Y73UsRyFdqotusGT+dnK4eNRGLcLEdtcG94bWYCVk6tA2m4Aed9S1bwXk qOIM41iw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35798) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vwh18-000000002zk-02mS; Sun, 01 Mar 2026 13:39:30 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vwh13-0000000052b-2zUf; Sun, 01 Mar 2026 13:39:25 +0000 Date: Sun, 1 Mar 2026 13:39:25 +0000 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: Andrew Lunn , Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: Re: [PATCH RESEND2 net-next 0/8] net: stmmac: qcom-ethqos: further serdes reorganisation Message-ID: References: <20260227165556.5cf9e844@kernel.org> <20260228083111.5df8550c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260228083111.5df8550c@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260301_053941_327782_E64367A8 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 28, 2026 at 08:31:11AM -0800, Jakub Kicinski wrote: > On Fri, 27 Feb 2026 16:55:56 -0800 Jakub Kicinski wrote: > > On Sat, 28 Feb 2026 00:11:29 +0000 Russell King (Oracle) wrote: > > > The AI review for patch 7 says: > > > > > > This commit fixes a bug but lacks a Fixes: tag. The commit modifies > > > behavior introduced in 360000820ae2 ("phy: qcom-sgmii-eth: add > > > .set_mode() and .validate() methods") by making phy_power_on() call > > > qcom_dwmac_sgmii_phy_calibrate() to restore the previous setup, and by > > > making qcom_dwmac_sgmii_phy_set_mode() check if the PHY is powered on > > > before attempting calibration. > > > > > > Should this commit include: > > > > > > Fixes: 360000820ae2 ("phy: qcom-sgmii-eth: add .set_mode() and .validate() methods") > > > > > > which is _wrong_, this isn't a bug fix. > > > > Yes, that's what I thought but then I saw the other thread.. > > Trying to apply this now but stmmac parts don't apply on Linus's tree, > and Vinod wants a tag :( What do we do? The problem will be that this series has dependencies on the first batch of qcom-ethqos patches, particularly: cd0aa6515350 ("net: stmmac: pass interface mode into fix_mac_speed() method") b560938163db ("net: stmmac: qcom-ethqos: pass phy interface mode to configs") fb42f19e671f ("net: stmmac: qcom-ethqos: move SerDes speed configuration") which enables the change in the third patch of this series - and without the third patch, none of the following patches in this series can be applied. I'm not sure what to suggest either. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!